Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18018C49ED7 for ; Thu, 19 Sep 2019 11:05:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD7FA21927 for ; Thu, 19 Sep 2019 11:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="hkmFGLMe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD7FA21927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAuFM-0003Of-Ip; Thu, 19 Sep 2019 11:05:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAuFM-0003O1-1b for xen-devel@lists.xenproject.org; Thu, 19 Sep 2019 11:05:12 +0000 X-Inumbo-ID: 4bed6f82-dacd-11e9-978d-bc764e2007e4 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4bed6f82-dacd-11e9-978d-bc764e2007e4; Thu, 19 Sep 2019 11:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568891089; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WPGPd+U3DwPsd1GZMMH/6DxaE93zWxQ3yiYCslf+xeM=; b=hkmFGLMeMI/7jCARPjbCZTJHZudMZG3kdhN+9Tc2JO/tWl6wW9qMsS2A byavZnnat2xDjLlwitkWK/DV12tx3c+Km+Xs3EqQlZ0mYCfLWCW8y5pBW M2tphvLg217O6VvLqxCFJq4CPNS0f4ncQiP8uXEHfyZZAHi44dI6JC59F E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: FPX8ygMcS1Xv95JRazkHa2B9OBNE7MprPCrM4JNwrNqd3YroZho6EIzgKdoT0EDim4R3WjX+UH zv+i4GpVICSVEPgzreAlw247HcRQV3jbkWlEl+DkbMHGgCotl08KYYevhXLfFyKj4a2kY8pnWO eh/3NNlxcxpDeonfKo+yiqm1w7+CgQnk1RyPNnsFDspCPDvbWgTatYn34VmTrUX8yTH3Bv+yL8 IJE5k/rAZhzeJzIqeYIRWaNHX1QgP4TNm2Tdwy/7niVf8EhukvfrEZWhuKyOzt5uEzokl9yJtC mvY= X-SBRS: 2.7 X-MesageID: 5840082 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,523,1559534400"; d="scan'208";a="5840082" From: Anthony PERARD To: Date: Thu, 19 Sep 2019 12:04:39 +0100 Message-ID: <20190919110443.817594-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919110443.817594-1-anthony.perard@citrix.com> References: <20190919110443.817594-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 5/9] libxl_disk: Reorganise libxl_cdrom_insert X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBvZiBjdXR0aW5nIGxpYnhsX2Nkcm9tX2luc2VydCBpbnRv IHNldmVyYWwKZnVuY3Rpb25zIHRvIGFsbG93IGFzeW5jaHJvbm91cyBjYWxsYmFja3MuCgpObyBm dW5jdGlvbmFsIGNoYW5nZXMuCgpTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9u eS5wZXJhcmRAY2l0cml4LmNvbT4KQWNrZWQtYnk6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBl dS5jaXRyaXguY29tPgotLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2Rpc2suYyB8IDU4ICsrKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzMiBpbnNl cnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4 bF9kaXNrLmMgYi90b29scy9saWJ4bC9saWJ4bF9kaXNrLmMKaW5kZXggYmM5ZTJkNWE3NGUyLi40 NWJmNTU1MDYxZGYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2Rpc2suYworKysgYi90 b29scy9saWJ4bC9saWJ4bF9kaXNrLmMKQEAgLTY0Nyw3ICs2NDcsNyBAQCBpbnQgbGlieGxfY2Ry b21faW5zZXJ0KGxpYnhsX2N0eCAqY3R4LCB1aW50MzJfdCBkb21pZCwgbGlieGxfZGV2aWNlX2Rp c2sgKmRpc2ssCiB7CiAgICAgQU9fQ1JFQVRFKGN0eCwgZG9taWQsIGFvX2hvdyk7CiAgICAgaW50 IG51bSA9IDAsIGk7Ci0gICAgbGlieGxfZGV2aWNlX2Rpc2sgKmRpc2tzID0gTlVMTCwgZGlza19z YXZlZCwgZGlza19lbXB0eTsKKyAgICBsaWJ4bF9kZXZpY2VfZGlzayAqZGlza3MgPSBOVUxMLCBk aXNrX3NhdmVkOwogICAgIGxpYnhsX2RvbWFpbl9jb25maWcgZF9jb25maWc7CiAgICAgaW50IHJj LCBkbV92ZXI7CiAgICAgbGlieGxfX2RldmljZSBkZXZpY2U7CkBAIC02NTgsMTYgKzY1OCw5IEBA IGludCBsaWJ4bF9jZHJvbV9pbnNlcnQobGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLCBs aWJ4bF9kZXZpY2VfZGlzayAqZGlzaywKICAgICBmbGV4YXJyYXlfdCAqaW5zZXJ0ID0gTlVMTCwg KmVtcHR5ID0gTlVMTDsKIAogICAgIGxpYnhsX2RvbWFpbl9jb25maWdfaW5pdCgmZF9jb25maWcp OwotICAgIGxpYnhsX2RldmljZV9kaXNrX2luaXQoJmRpc2tfZW1wdHkpOwogICAgIGxpYnhsX2Rl dmljZV9kaXNrX2luaXQoJmRpc2tfc2F2ZWQpOwogICAgIGxpYnhsX2RldmljZV9kaXNrX2NvcHko Y3R4LCAmZGlza19zYXZlZCwgZGlzayk7CiAKLSAgICBkaXNrX2VtcHR5LmZvcm1hdCA9IExJQlhM X0RJU0tfRk9STUFUX0VNUFRZOwotICAgIGRpc2tfZW1wdHkudmRldiA9IGxpYnhsX19zdHJkdXAo Tk9HQywgZGlzay0+dmRldik7Ci0gICAgZGlza19lbXB0eS5wZGV2X3BhdGggPSBsaWJ4bF9fc3Ry ZHVwKE5PR0MsICIiKTsKLSAgICBkaXNrX2VtcHR5LmlzX2Nkcm9tID0gMTsKLSAgICBsaWJ4bF9f ZGV2aWNlX2Rpc2tfc2V0ZGVmYXVsdChnYywgZG9taWQsICZkaXNrX2VtcHR5LCBmYWxzZSk7Ci0K ICAgICBsaWJ4bF9kb21haW5fdHlwZSB0eXBlID0gbGlieGxfX2RvbWFpbl90eXBlKGdjLCBkb21p ZCk7CiAgICAgaWYgKHR5cGUgPT0gTElCWExfRE9NQUlOX1RZUEVfSU5WQUxJRCkgewogICAgICAg ICByYyA9IEVSUk9SX0ZBSUw7CkBAIC03MjEsMjMgKzcxNCw2IEBAIGludCBsaWJ4bF9jZHJvbV9p bnNlcnQobGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLCBsaWJ4bF9kZXZpY2VfZGlzayAq ZGlzaywKICAgICBiZV9wYXRoID0gbGlieGxfX2RldmljZV9iYWNrZW5kX3BhdGgoZ2MsICZkZXZp Y2UpOwogICAgIGxpYnhsX3BhdGggPSBsaWJ4bF9fZGV2aWNlX2xpYnhsX3BhdGgoZ2MsICZkZXZp Y2UpOwogCi0gICAgaW5zZXJ0ID0gZmxleGFycmF5X21ha2UoZ2MsIDQsIDEpOwotCi0gICAgZmxl eGFycmF5X2FwcGVuZF9wYWlyKGluc2VydCwgInR5cGUiLAotICAgICAgICAgICAgICAgICAgICAg ICAgICBsaWJ4bF9fZGV2aWNlX2Rpc2tfc3RyaW5nX29mX2JhY2tlbmQoZGlzay0+YmFja2VuZCkp OwotICAgIGlmIChkaXNrLT5mb3JtYXQgIT0gTElCWExfRElTS19GT1JNQVRfRU1QVFkpCi0gICAg ICAgIGZsZXhhcnJheV9hcHBlbmRfcGFpcihpbnNlcnQsICJwYXJhbXMiLAotICAgICAgICAgICAg ICAgICAgICAgICAgR0NTUFJJTlRGKCIlczolcyIsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgbGlieGxfX2RldmljZV9kaXNrX3N0cmluZ19vZl9mb3JtYXQoZGlzay0+Zm9ybWF0KSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNrLT5wZGV2X3BhdGgpKTsKLSAgICBlbHNlCi0g ICAgICAgIGZsZXhhcnJheV9hcHBlbmRfcGFpcihpbnNlcnQsICJwYXJhbXMiLCAiIik7Ci0KLSAg ICBlbXB0eSA9IGZsZXhhcnJheV9tYWtlKGdjLCA0LCAxKTsKLSAgICBmbGV4YXJyYXlfYXBwZW5k X3BhaXIoZW1wdHksICJ0eXBlIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2Rl dmljZV9kaXNrX3N0cmluZ19vZl9iYWNrZW5kKGRpc2stPmJhY2tlbmQpKTsKLSAgICBmbGV4YXJy YXlfYXBwZW5kX3BhaXIoZW1wdHksICJwYXJhbXMiLCAiIik7Ci0KICAgICAvKiBOb3RlOiBDVFgg bG9jayBpcyBhbHJlYWR5IGhlbGQgYXQgdGhpcyBwb2ludCBzbyBsb2NrIGhpZXJhcmNoeQogICAg ICAqIGlzIG1haW50YWluZWQuCiAgICAgICovCkBAIC03NTAsMTEgKzcyNiwyNyBAQCBpbnQgbGli eGxfY2Ryb21faW5zZXJ0KGxpYnhsX2N0eCAqY3R4LCB1aW50MzJfdCBkb21pZCwgbGlieGxfZGV2 aWNlX2Rpc2sgKmRpc2ssCiAgICAgLyogV2UgbmVlZCB0byBlamVjdCB0aGUgb3JpZ2luYWwgaW1h Z2UgZmlyc3QuIFRoaXMgaXMgaW1wbGVtZW50ZWQKICAgICAgKiBieSBpbnNlcnRpbmcgZW1wdHkg bWVkaWEuIEpTT04gaXMgbm90IHVwZGF0ZWQuCiAgICAgICovCisKICAgICBpZiAoZG1fdmVyID09 IExJQlhMX0RFVklDRV9NT0RFTF9WRVJTSU9OX1FFTVVfWEVOKSB7CisgICAgICAgIGxpYnhsX2Rl dmljZV9kaXNrIGRpc2tfZW1wdHk7CisKKyAgICAgICAgbGlieGxfZGV2aWNlX2Rpc2tfaW5pdCgm ZGlza19lbXB0eSk7CisgICAgICAgIGRpc2tfZW1wdHkuZm9ybWF0ID0gTElCWExfRElTS19GT1JN QVRfRU1QVFk7CisgICAgICAgIGRpc2tfZW1wdHkudmRldiA9IGxpYnhsX19zdHJkdXAoTk9HQywg ZGlzay0+dmRldik7CisgICAgICAgIGRpc2tfZW1wdHkucGRldl9wYXRoID0gbGlieGxfX3N0cmR1 cChOT0dDLCAiIik7CisgICAgICAgIGRpc2tfZW1wdHkuaXNfY2Ryb20gPSAxOworICAgICAgICBs aWJ4bF9fZGV2aWNlX2Rpc2tfc2V0ZGVmYXVsdChnYywgZG9taWQsICZkaXNrX2VtcHR5LCBmYWxz ZSk7CisKICAgICAgICAgcmMgPSBsaWJ4bF9fcW1wX2luc2VydF9jZHJvbShnYywgZG9taWQsICZk aXNrX2VtcHR5KTsKKyAgICAgICAgbGlieGxfZGV2aWNlX2Rpc2tfZGlzcG9zZSgmZGlza19lbXB0 eSk7CiAgICAgICAgIGlmIChyYykgZ290byBvdXQ7CiAgICAgfQogCisgICAgZW1wdHkgPSBmbGV4 YXJyYXlfbWFrZShnYywgNCwgMSk7CisgICAgZmxleGFycmF5X2FwcGVuZF9wYWlyKGVtcHR5LCAi dHlwZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX19kZXZpY2VfZGlza19zdHJp bmdfb2ZfYmFja2VuZChkaXNrLT5iYWNrZW5kKSk7CisgICAgZmxleGFycmF5X2FwcGVuZF9wYWly KGVtcHR5LCAicGFyYW1zIiwgIiIpOworCiAgICAgZm9yICg7OykgewogICAgICAgICByYyA9IGxp YnhsX194c190cmFuc2FjdGlvbl9zdGFydChnYywgJnQpOwogICAgICAgICBpZiAocmMpIGdvdG8g b3V0OwpAQCAtNzgxLDYgKzc3MywxMCBAQCBpbnQgbGlieGxfY2Ryb21faW5zZXJ0KGxpYnhsX2N0 eCAqY3R4LCB1aW50MzJfdCBkb21pZCwgbGlieGxfZGV2aWNlX2Rpc2sgKmRpc2ssCiAgICAgICAg IGlmIChyYyA8IDApIGdvdG8gb3V0OwogICAgIH0KIAorICAgIC8qCisgICAgICogTm93IHRoYXQg dGhlIGRyaXZlIGlzIGVtcHR5LCB3ZSBjYW4gaW5zZXJ0IHRoZSBuZXcgbWVkaWEuCisgICAgICov CisKICAgICByYyA9IGxpYnhsX19nZXRfZG9tYWluX2NvbmZpZ3VyYXRpb24oZ2MsIGRvbWlkLCAm ZF9jb25maWcpOwogICAgIGlmIChyYykgZ290byBvdXQ7CiAKQEAgLTc5NCw2ICs3OTAsMTcgQEAg aW50IGxpYnhsX2Nkcm9tX2luc2VydChsaWJ4bF9jdHggKmN0eCwgdWludDMyX3QgZG9taWQsIGxp YnhsX2RldmljZV9kaXNrICpkaXNrLAogICAgICAgICBpZiAocmMpIGdvdG8gb3V0OwogICAgIH0K IAorICAgIGluc2VydCA9IGZsZXhhcnJheV9tYWtlKGdjLCA0LCAxKTsKKyAgICBmbGV4YXJyYXlf YXBwZW5kX3BhaXIoaW5zZXJ0LCAidHlwZSIsCisgICAgICAgICAgICAgICAgICAgICAgbGlieGxf X2RldmljZV9kaXNrX3N0cmluZ19vZl9iYWNrZW5kKGRpc2stPmJhY2tlbmQpKTsKKyAgICBpZiAo ZGlzay0+Zm9ybWF0ICE9IExJQlhMX0RJU0tfRk9STUFUX0VNUFRZKQorICAgICAgICBmbGV4YXJy YXlfYXBwZW5kX3BhaXIoaW5zZXJ0LCAicGFyYW1zIiwKKyAgICAgICAgICAgICAgICAgICAgR0NT UFJJTlRGKCIlczolcyIsCisgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fZGV2aWNlX2Rp c2tfc3RyaW5nX29mX2Zvcm1hdChkaXNrLT5mb3JtYXQpLAorICAgICAgICAgICAgICAgICAgICAg ICAgZGlzay0+cGRldl9wYXRoKSk7CisgICAgZWxzZQorICAgICAgICBmbGV4YXJyYXlfYXBwZW5k X3BhaXIoaW5zZXJ0LCAicGFyYW1zIiwgIiIpOworCiAgICAgZm9yICg7OykgewogICAgICAgICBy YyA9IGxpYnhsX194c190cmFuc2FjdGlvbl9zdGFydChnYywgJnQpOwogICAgICAgICBpZiAocmMp IGdvdG8gb3V0OwpAQCAtODMxLDcgKzgzOCw2IEBAIGludCBsaWJ4bF9jZHJvbV9pbnNlcnQobGli eGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLCBsaWJ4bF9kZXZpY2VfZGlzayAqZGlzaywKIG91 dDoKICAgICBsaWJ4bF9feHNfdHJhbnNhY3Rpb25fYWJvcnQoZ2MsICZ0KTsKICAgICBsaWJ4bF9f ZGV2aWNlX2xpc3RfZnJlZSgmbGlieGxfX2Rpc2tfZGV2dHlwZSwgZGlza3MsIG51bSk7Ci0gICAg bGlieGxfZGV2aWNlX2Rpc2tfZGlzcG9zZSgmZGlza19lbXB0eSk7CiAgICAgbGlieGxfZGV2aWNl X2Rpc2tfZGlzcG9zZSgmZGlza19zYXZlZCk7CiAgICAgbGlieGxfZG9tYWluX2NvbmZpZ19kaXNw b3NlKCZkX2NvbmZpZyk7CiAKLS0gCkFudGhvbnkgUEVSQVJECgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==