Received: by 2002:adf:ef42:0:0:0:0:0 with SMTP id c2csp920333wrp; Thu, 19 Sep 2019 05:19:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwi/rk5BYVa14cKhzp7KQeEF6eSjzoHhkRuoWtm/WddeE9czDHOBUx2viYPDKN07Rcjx6WS X-Received: by 2002:ad4:418c:: with SMTP id e12mr7665816qvp.70.1568895558286; Thu, 19 Sep 2019 05:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568895558; cv=none; d=google.com; s=arc-20160816; b=i0xnWg0q4P4T1hRonvR2ndLbucDCUVDtKw+v3UwviZfxirTDhBwytMcnbtvC8+zZ8s QYfal0xJGg5METL+mfCLmbO3tZyq6Lg2bBYgYcYMgeB5xEJlz8HjJpZwvajPZ8V/TQVq 0qc/aaLPjXcznYzSUACLWZfQHkSHz6RkUf6PYk41JYS4BdqTTNe/s9MHDYlRCH5yVtvX yWJEks1WMdapGuHpAGW9ynvUsw3r0Ggy72wpSYQUXlnsBTACoBbCmU7baTbYIKDNurNs yieGLqjb0hccuddCd6YcpruzGMrZ+2QPTA4BlknMDu4N6aoe/vpQI4PyccdPHvWN91qI 7ZpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from; bh=ZMEFKpiRQdv9ZrmUZ7Ju2pj8J6AzVj9rgiqSk0aqWtY=; b=iE9MJ2WdbBmC50PtcV1HvuG0igCz2A0313GdP2mhVeo4Wm1Yc0vl8VdePJ06O2vget iD5ZOOkkD4SkwqzKdK84+x1i3+oj+fCrzGy18iaTL6+qsWERDkQq8hkkQ0JAS2G0Ic8w ziC1rYdmXaa79T/M0LnhozR4Xm2XQWvYyfjNkYKdkqiV4euGJoOqAtZOPe1F9Z0VK9wo 3IpdOU7i9L7DB0i1nlFfz6k4lYWdi5WaoAJG2lhX4NPe+mXUD/Uz5Amu/oWJQR7fMRlb 9EWdCyOm+N2qgZxqk6tVEJ9dBtwbX7CFMV0aw4LxjL7jQYULdcr2iNc8yp98KCstjdSW IAuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 2si6245315qvy.187.2019.09.19.05.19.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Sep 2019 05:19:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:43342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAvP3-00055H-NN for alex.bennee@linaro.org; Thu, 19 Sep 2019 08:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37617) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAvOo-00054c-MA for qemu-arm@nongnu.org; Thu, 19 Sep 2019 08:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAvOn-0003nl-He for qemu-arm@nongnu.org; Thu, 19 Sep 2019 08:19:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39858) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAvOn-0003mw-Bk; Thu, 19 Sep 2019 08:19:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82AE2369AC; Thu, 19 Sep 2019 12:19:00 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-220.ams2.redhat.com [10.36.117.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3242660BF1; Thu, 19 Sep 2019 12:18:48 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, alex.williamson@redhat.com, peterx@redhat.com Date: Thu, 19 Sep 2019 14:18:40 +0200 Message-Id: <20190919121845.29520-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 19 Sep 2019 12:19:00 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-arm] [PATCH v2 0/5] Allow memory_region_register_iommu_notifier() to fail X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mst@redhat.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: Jn/ra8mTbHsH This series allows the memory_region_register_iommu_notifier() to fail. As of now, when a MAP notifier is attempted to be registered along with SMMUv3, Intel iommu without caching mode or AMD IOMMU, we exit in the IOMMU MR notify_flag_changed() callback. In case of VFIO assigned device hotplug, this could be handled more nicely directly within the VFIO code, simply rejecting the hotplug without exiting. This is what the series achieves by handling the memory_region_register_iommu_notifier() returned value. Best Regards Eric This series can be found at: https://github.com/eauger/qemu/tree/v4.1.0_register_iommu_notifier_fail_v= 2 History: v1 -> v2: - Intel IOMMU now handles the problem differently with machine init done notifier and machine hotplug allowed hook. - use assert(!ret) - message rewording in SMMUv3 Follow-up of "VFIO/SMMUv3: Fail on VFIO/HW nested paging detection" https://patchew.org/QEMU/20190829090141.21821-1-eric.auger@redhat.com/ Eric Auger (5): memory: allow memory_region_register_iommu_notifier() to fail vfio/common: Handle memory_region_register_iommu_notifier() failure exec: assert on memory_region_register_iommu_notifier() failure vhost: assert on memory_region_register_iommu_notifier() failure amd_iommu: Let amdvi_iommu_notify_flag_changed() fail exec.c | 6 ++++-- hw/arm/smmuv3.c | 12 +++++++----- hw/i386/amd_iommu.c | 9 +++++---- hw/i386/intel_iommu.c | 7 ++++--- hw/ppc/spapr_iommu.c | 7 ++++--- hw/vfio/common.c | 8 ++++++-- hw/virtio/vhost.c | 5 +++-- include/exec/memory.h | 18 +++++++++++++----- memory.c | 28 ++++++++++++++++++---------- 9 files changed, 64 insertions(+), 36 deletions(-) --=20 2.20.1