From: Jakub Kicinski Subject: Re: [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Date: Sun, 22 Sep 2019 15:12:57 -0700 Message-ID: <20190922151257.51173d89@cakuba.netronome.com> References: <20190920053817.13754-1-christophe.roullier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190920053817.13754-1-christophe.roullier@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Christophe Roullier Cc: mark.rutland@arm.com, robh@kernel.org, alexandre.torgue@st.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com, andrew@lunn.ch, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote: > Some improvements (manage syscfg as optional clock, update slew rate of > ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) > Fix warning build message when W=1 There seems to be some new features/cleanups (or improvements as you say) here. Could you explain the negative impact not applying these changes will have? Patches 1 and 3 in particular. net-next is now closed [1], and will reopen some time after the merge window is over. For now we are only expecting fixes for the net tree. Could you (a) provide stronger motivation these changes are fixes; or (b) separate the fixes from improvements? Thank you! [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html