From: "Zhao, Yong" Subject: [PATCH 1/2] drm/amdkfd: Fix NULL pointer dereference for set_scratch_backing_va() Date: Mon, 23 Sep 2019 20:00:21 +0000 Message-ID: <20190923200008.11998-1-Yong.Zhao@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "Zhao, Yong" Q3VycmVudGx5IHRoaXMgZnVuY3Rpb24gcG9pbnRlciBpcyBtaXNzaW5nIGZvciBHRlgxMC4gQ29u c2lkZXJpbmcgaXQgaXMKYSB2b2lkIGZ1bmN0aW9uIHNpbmNlIEdGWDksIGZpeCBpdCBieSBjaGVj a2luZyB0aGUgZnVuY3Rpb24gcG9pbnRlcgpiZWZvcmUgZGVyZWZlcmVuY2luZyBpdC4KCkNoYW5n ZS1JZDogSTFkYzhlNTE2M2YyNTkyNTEzNTdiZmFhNDJhOTFmZjk5MWZiYTZkZDUKU2lnbmVkLW9m Zi1ieTogWW9uZyBaaGFvIDxZb25nLlpoYW9AYW1kLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkX2FyY3R1cnVzLmMgICB8ICAxIC0KIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ2Z4X3Y5LmMgICAgIHwgMTAgLS0tLS0tLS0t LQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2FtZGtmZF9nZnhfdjkuaCAgICAg fCAgMiAtLQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYyAgICAgICAg ICAgICAgfCAgMiArLQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2RldmljZV9xdWV1 ZV9tYW5hZ2VyLmMgfCAgNSArKystLQogZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNsdWRlL2tnZF9r ZmRfaW50ZXJmYWNlLmggICAgICAgfCAgNSArKysrKwogNiBmaWxlcyBjaGFuZ2VkLCA5IGluc2Vy dGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRfYXJjdHVydXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9hbWRrZmRfYXJjdHVydXMuYwppbmRleCAzOTc2OGQ2Y2IwN2MuLjNhYmFm OTJjYWY1YyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Ft ZGtmZF9hcmN0dXJ1cy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9h bWRrZmRfYXJjdHVydXMuYwpAQCAtMjgzLDcgKzI4Myw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg a2ZkMmtnZF9jYWxscyBrZmQya2dkID0gewogCQkJa2dkX2dmeF92OV9nZXRfYXRjX3ZtaWRfcGFz aWRfbWFwcGluZ19wYXNpZCwKIAkuZ2V0X2F0Y192bWlkX3Bhc2lkX21hcHBpbmdfdmFsaWQgPQog CQkJa2dkX2dmeF92OV9nZXRfYXRjX3ZtaWRfcGFzaWRfbWFwcGluZ192YWxpZCwKLQkuc2V0X3Nj cmF0Y2hfYmFja2luZ192YSA9IGtnZF9nZnhfdjlfc2V0X3NjcmF0Y2hfYmFja2luZ192YSwKIAku Z2V0X3RpbGVfY29uZmlnID0ga2dkX2dmeF92OV9nZXRfdGlsZV9jb25maWcsCiAJLnNldF92bV9j b250ZXh0X3BhZ2VfdGFibGVfYmFzZSA9IGtnZF9nZnhfdjlfc2V0X3ZtX2NvbnRleHRfcGFnZV90 YWJsZV9iYXNlLAogCS5pbnZhbGlkYXRlX3RsYnMgPSBrZ2RfZ2Z4X3Y5X2ludmFsaWRhdGVfdGxi cywKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRf Z2Z4X3Y5LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkX2dmeF92 OS5jCmluZGV4IDRhMTI2ZGY5Mzg4NS4uNzQ1Y2FlNWI2MjgyIDEwMDY0NAotLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkX2dmeF92OS5jCisrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ2Z4X3Y5LmMKQEAgLTc3NSwxNSArNzc1 LDYgQEAgdWludDMyX3Qga2dkX2dmeF92OV9hZGRyZXNzX3dhdGNoX2dldF9vZmZzZXQoc3RydWN0 IGtnZF9kZXYgKmtnZCwKIAlyZXR1cm4gMDsKIH0KIAotdm9pZCBrZ2RfZ2Z4X3Y5X3NldF9zY3Jh dGNoX2JhY2tpbmdfdmEoc3RydWN0IGtnZF9kZXYgKmtnZCwKLQkJCQkJdWludDY0X3QgdmEsIHVp bnQzMl90IHZtaWQpCi17Ci0JLyogTm8gbG9uZ2VyIG5lZWRlZCBvbiBHRlh2OS4gVGhlIHNjcmF0 Y2ggYmFzZSBhZGRyZXNzIGlzCi0JICogcGFzc2VkIHRvIHRoZSBzaGFkZXIgYnkgdGhlIENQLiBJ dCdzIHRoZSB1c2VyIG1vZGUgZHJpdmVyJ3MKLQkgKiByZXNwb25zaWJpbGl0eS4KLQkgKi8KLX0K LQogdm9pZCBrZ2RfZ2Z4X3Y5X3NldF92bV9jb250ZXh0X3BhZ2VfdGFibGVfYmFzZShzdHJ1Y3Qg a2dkX2RldiAqa2dkLCB1aW50MzJfdCB2bWlkLAogCQl1aW50NjRfdCBwYWdlX3RhYmxlX2Jhc2Up CiB7CkBAIC04MjksNyArODIwLDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBrZmQya2dkX2NhbGxz IGtmZDJrZ2QgPSB7CiAJCQlrZ2RfZ2Z4X3Y5X2dldF9hdGNfdm1pZF9wYXNpZF9tYXBwaW5nX3Bh c2lkLAogCS5nZXRfYXRjX3ZtaWRfcGFzaWRfbWFwcGluZ192YWxpZCA9CiAJCQlrZ2RfZ2Z4X3Y5 X2dldF9hdGNfdm1pZF9wYXNpZF9tYXBwaW5nX3ZhbGlkLAotCS5zZXRfc2NyYXRjaF9iYWNraW5n X3ZhID0ga2dkX2dmeF92OV9zZXRfc2NyYXRjaF9iYWNraW5nX3ZhLAogCS5nZXRfdGlsZV9jb25m aWcgPSBrZ2RfZ2Z4X3Y5X2dldF90aWxlX2NvbmZpZywKIAkuc2V0X3ZtX2NvbnRleHRfcGFnZV90 YWJsZV9iYXNlID0ga2dkX2dmeF92OV9zZXRfdm1fY29udGV4dF9wYWdlX3RhYmxlX2Jhc2UsCiAJ LmludmFsaWRhdGVfdGxicyA9IGtnZF9nZnhfdjlfaW52YWxpZGF0ZV90bGJzLApkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2FtZGtmZF9nZnhfdjkuaCBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ2Z4X3Y5LmgKaW5kZXggMjZk ODg3OWJmZjlkLi4yMjViZjY0MDAxZTQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ2Z4X3Y5LmgKKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2FtZGtmZF9nZnhfdjkuaApAQCAtNjEsOCArNjEsNiBAQCB1aW50MTZfdCBr Z2RfZ2Z4X3Y5X2dldF9hdGNfdm1pZF9wYXNpZF9tYXBwaW5nX3Bhc2lkKHN0cnVjdCBrZ2RfZGV2 ICprZ2QsCiAJCXVpbnQ4X3Qgdm1pZCk7CiB2b2lkIGtnZF9nZnhfdjlfc2V0X3ZtX2NvbnRleHRf cGFnZV90YWJsZV9iYXNlKHN0cnVjdCBrZ2RfZGV2ICprZ2QsIHVpbnQzMl90IHZtaWQsCiAJCXVp bnQ2NF90IHBhZ2VfdGFibGVfYmFzZSk7Ci12b2lkIGtnZF9nZnhfdjlfc2V0X3NjcmF0Y2hfYmFj a2luZ192YShzdHJ1Y3Qga2dkX2RldiAqa2dkLAotCQkJCQl1aW50NjRfdCB2YSwgdWludDMyX3Qg dm1pZCk7CiBpbnQga2dkX2dmeF92OV9pbnZhbGlkYXRlX3RsYnMoc3RydWN0IGtnZF9kZXYgKmtn ZCwgdWludDE2X3QgcGFzaWQpOwogaW50IGtnZF9nZnhfdjlfaW52YWxpZGF0ZV90bGJzX3ZtaWQo c3RydWN0IGtnZF9kZXYgKmtnZCwgdWludDE2X3Qgdm1pZCk7CiBpbnQga2dkX2dmeF92OV9nZXRf dGlsZV9jb25maWcoc3RydWN0IGtnZF9kZXYgKmtnZCwKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1ka2ZkL2tmZF9jaGFyZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtm ZC9rZmRfY2hhcmRldi5jCmluZGV4IGE1Mzg2NGJiNzBiYi4uZDE0YWVkOTgzNjYzIDEwMDY0NAot LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY2hhcmRldi5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9jaGFyZGV2LmMKQEAgLTExMjgsNyArMTEyOCw3IEBA IHN0YXRpYyBpbnQga2ZkX2lvY3RsX3NldF9zY3JhdGNoX2JhY2tpbmdfdmEoc3RydWN0IGZpbGUg KmZpbGVwLAogCW11dGV4X3VubG9jaygmcC0+bXV0ZXgpOwogCiAJaWYgKGRldi0+ZHFtLT5zY2hl ZF9wb2xpY3kgPT0gS0ZEX1NDSEVEX1BPTElDWV9OT19IV1MgJiYKLQkgICAgcGRkLT5xcGQudm1p ZCAhPSAwKQorCSAgICBwZGQtPnFwZC52bWlkICE9IDAgJiYgZGV2LT5rZmQya2dkLT5zZXRfc2Ny YXRjaF9iYWNraW5nX3ZhKQogCQlkZXYtPmtmZDJrZ2QtPnNldF9zY3JhdGNoX2JhY2tpbmdfdmEo CiAJCQlkZXYtPmtnZCwgYXJncy0+dmFfYWRkciwgcGRkLT5xcGQudm1pZCk7CiAKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5j IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2RldmljZV9xdWV1ZV9tYW5hZ2VyLmMK aW5kZXggYzgyNjYzNDkzOGQyLi45YTUzYmM3OWZiNDIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5jCisrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5jCkBAIC0yMjAsOCAr MjIwLDkgQEAgc3RhdGljIGludCBhbGxvY2F0ZV92bWlkKHN0cnVjdCBkZXZpY2VfcXVldWVfbWFu YWdlciAqZHFtLAogCS8qIGludmFsaWRhdGUgdGhlIFZNIGNvbnRleHQgYWZ0ZXIgcGFzaWQgYW5k IHZtaWQgbWFwcGluZyBpcyBzZXQgdXAgKi8KIAlrZmRfZmx1c2hfdGxiKHFwZF90b19wZGQocXBk KSk7CiAKLQlkcW0tPmRldi0+a2ZkMmtnZC0+c2V0X3NjcmF0Y2hfYmFja2luZ192YSgKLQkJZHFt LT5kZXYtPmtnZCwgcXBkLT5zaF9oaWRkZW5fcHJpdmF0ZV9iYXNlLCBxcGQtPnZtaWQpOworCWlm IChkcW0tPmRldi0+a2ZkMmtnZC0+c2V0X3NjcmF0Y2hfYmFja2luZ192YSkKKwkJZHFtLT5kZXYt PmtmZDJrZ2QtPnNldF9zY3JhdGNoX2JhY2tpbmdfdmEoZHFtLT5kZXYtPmtnZCwKKwkJCQlxcGQt PnNoX2hpZGRlbl9wcml2YXRlX2Jhc2UsIHFwZC0+dm1pZCk7CiAKIAlyZXR1cm4gMDsKIH0KZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvaW5jbHVkZS9rZ2Rfa2ZkX2ludGVyZmFjZS5o IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNsdWRlL2tnZF9rZmRfaW50ZXJmYWNlLmgKaW5kZXgg OThiOTUzM2U2NzJiLi5lNGY3YmJhMTFhM2EgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvaW5jbHVkZS9rZ2Rfa2ZkX2ludGVyZmFjZS5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv aW5jbHVkZS9rZ2Rfa2ZkX2ludGVyZmFjZS5oCkBAIC0yOTgsOCArMjk4LDEzIEBAIHN0cnVjdCBr ZmQya2dkX2NhbGxzIHsKIAkJCQkJc3RydWN0IGtnZF9kZXYgKmtnZCwKIAkJCQkJdWludDhfdCB2 bWlkKTsKIAorCS8qIE5vIGxvbmdlciBuZWVkZWQgZnJvbSBHRlh2OSBvbndhcmQuIFRoZSBzY3Jh dGNoIGJhc2UgYWRkcmVzcyBpcworCSAqIHBhc3NlZCB0byB0aGUgc2hhZGVyIGJ5IHRoZSBDUC4g SXQncyB0aGUgdXNlciBtb2RlIGRyaXZlcidzCisJICogcmVzcG9uc2liaWxpdHkuCisJICovCiAJ dm9pZCAoKnNldF9zY3JhdGNoX2JhY2tpbmdfdmEpKHN0cnVjdCBrZ2RfZGV2ICprZ2QsCiAJCQkJ dWludDY0X3QgdmEsIHVpbnQzMl90IHZtaWQpOworCiAJaW50ICgqZ2V0X3RpbGVfY29uZmlnKShz dHJ1Y3Qga2dkX2RldiAqa2dkLCBzdHJ1Y3QgdGlsZV9jb25maWcgKmNvbmZpZyk7CiAKIAl2b2lk ICgqc2V0X3ZtX2NvbnRleHRfcGFnZV90YWJsZV9iYXNlKShzdHJ1Y3Qga2dkX2RldiAqa2dkLAot LSAKMi4xNy4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=