Received: by 2002:adf:ef42:0:0:0:0:0 with SMTP id c2csp3628915wrp; Tue, 24 Sep 2019 01:26:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwzvLmHnbnuh5KcZS/nAHNjihBJE1eVRn0fW2GgEA6jXqdwGcJIAfdaSWjC8H7YeX4wTo0L X-Received: by 2002:a50:d2d4:: with SMTP id q20mr1395431edg.172.1569313586611; Tue, 24 Sep 2019 01:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569313586; cv=none; d=google.com; s=arc-20160816; b=Mr8DBYbSOLDHrgP9+R7DbD4gngPy1tmIKJrEGWlf68gyN2nwIw8ZKfScVtCcnY07xr HlnIgoBboAhzYqWCyC15dEjRMdkhbXi6RgLlZyWmfL++MM7/ft+sr+UOA8R/7Y4B+rZt b7og+vCNxsyuX1A9qpBevfXg6zFYsNLbCgV6nm6KPhV13UtA+UAGGKlptsvyz0kuFakV Kl26z7rJvKoyetyn4WnsAIaXWM4QbywEPeglFpm03uPvu4pHQB0ZGxhjZAL2+tAJee1m zPE1qVFKQqT6eeLFCsiH7VzCS/REH52QicmO4nijwZa8iwfDZ9zHe0X/Gh8ZXjpMvj9Y bx9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from; bh=qt4tec24JPosEqNnC+WNWUe4AomNWj3v5BBOR+iRPpo=; b=ZbzRLxNDMrVxN3AALs2a6DwLd6Tc1bQrlhGmeXZkGwYts4GMO84J4U5a7trtfLAPQj v69pWUc/7w0x7VoOtu8zvSfeYqm52TprvSL4jRtnLQIk/Y7jsvw4e6+th1/jcWYhIVVg gxF0Ax8vsXq3Sq/W7LwDK9+P8cuFh0N+67M0+wRhidvCcwrZjuAT2W4uNqAXv4j+qSsa ucJDCdE5xRT/7FJaxvUR1Vlo1LtvYXDke7XpYYXPw2T/D4s4RDVylO28i26QHPBclq7p mIENFuGQHI0rFMFSKRkT7mB6KWYY8+C1s0bdB82IhDtwbYMDThBd5TyhigfsGRLC//Z2 Ho7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h7si469526ejx.59.2019.09.24.01.26.26 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Sep 2019 01:26:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:42500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCg9Q-0000gk-HT for alex.bennee@linaro.org; Tue, 24 Sep 2019 04:26:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46840) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCg8e-0000fI-Kk for qemu-arm@nongnu.org; Tue, 24 Sep 2019 04:25:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCg8a-0006sH-TD for qemu-arm@nongnu.org; Tue, 24 Sep 2019 04:25:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51510) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCg8Z-0006rV-TG; Tue, 24 Sep 2019 04:25:32 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A375368DA; Tue, 24 Sep 2019 08:25:28 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2BFE60852; Tue, 24 Sep 2019 08:25:18 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, alex.williamson@redhat.com, peterx@redhat.com, aik@ozlabs.ru, david@gibson.dropbear.id.au Subject: [PATCH v4 0/2] Allow memory_region_register_iommu_notifier() to fail Date: Tue, 24 Sep 2019 10:25:15 +0200 Message-Id: <20190924082517.13724-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 24 Sep 2019 08:25:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: sa0SBNfp2c1n This series allows the memory_region_register_iommu_notifier() to fail. As of now, when a MAP notifier is attempted to be registered along with SMMUv3 or AMD IOMMU, we exit in the IOMMU MR notify_flag_changed() callback. In case of VFIO assigned device hotplug, this could be handled more nicely directly within the VFIO code, simply rejecting the hotplug without exiting. This is what the series achieves by handling the memory_region_register_iommu_notifier() returned value and Error object. To propagate errors collected during vfio_listener_region_add() we now store the error handle inside the VFIO container instead of a returned value. The message now is: (QEMU) device_add id=3Dhot0 driver=3Dvfio-pci host=3D0000:89:00.0 bus=3Dp= cie.1 {"error": {"class": "GenericError", "desc": "vfio 0000:89:00.0: failed to setup container for group 2: memory listener initialization failed: Region smmuv3-iommu-memory-region-0-6: device 01.00.0 requires iommu MAP notifier which is not currently supported"}} Best Regards Eric This series can be found at: https://github.com/eauger/qemu/tree/v4.1.0_register_iommu_notifier_fail_v= 4 History: v3 -> v4: - added Peter's R-b on 2d patch - 1st patch: restore hw_error, remove useless ret assignment, improve DMA host window error message, remove local mr variable v2 -> v3: - also pass an Error handle (suggested by Peter) v1 -> v2: - Intel IOMMU now handles the problem differently with machine init done notifier and machine hotplug allowed hook. - use assert(!ret) - message rewording in SMMUv3 Follow-up of "VFIO/SMMUv3: Fail on VFIO/HW nested paging detection" https://patchew.org/QEMU/20190829090141.21821-1-eric.auger@redhat.com/ Eric Auger (2): vfio: Turn the container error into an Error handle memory: allow memory_region_register_iommu_notifier() to fail exec.c | 10 +++++-- hw/arm/smmuv3.c | 18 ++++++------ hw/i386/amd_iommu.c | 17 +++++++----- hw/i386/intel_iommu.c | 8 ++++-- hw/ppc/spapr_iommu.c | 8 ++++-- hw/vfio/common.c | 52 +++++++++++++++++++++++------------ hw/vfio/spapr.c | 4 ++- hw/virtio/vhost.c | 9 ++++-- include/exec/memory.h | 21 ++++++++++---- include/hw/vfio/vfio-common.h | 2 +- memory.c | 31 +++++++++++++-------- 11 files changed, 120 insertions(+), 60 deletions(-) --=20 2.20.1