Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA162C432C2 for ; Wed, 25 Sep 2019 16:55:39 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47635207E0 for ; Wed, 25 Sep 2019 16:55:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47635207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=users.sourceforge.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x8PGtXJ5023563; Wed, 25 Sep 2019 18:55:33 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 8B091779A; Wed, 25 Sep 2019 18:55:33 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 0FE6E76D9 for ; Wed, 25 Sep 2019 18:55:32 +0200 (CEST) Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.141]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x8PGscrA027211 for ; Wed, 25 Sep 2019 18:54:39 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4F2A8160062 for ; Wed, 25 Sep 2019 18:54:38 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46dkgJ5vHnz6tm6; Wed, 25 Sep 2019 18:54:36 +0200 (CEST) From: Michele Martone To: cocci@systeme.lip6.fr Date: Wed, 25 Sep 2019 18:54:14 +0200 Message-Id: <20190925165414.23602-1-michelemartone@users.sourceforge.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 25 Sep 2019 18:55:34 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 25 Sep 2019 18:54:39 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: nicolas.palix@imag.fr Subject: [Cocci] [PATCH] clarify misleading warning message X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr One may think that when warning that "should %s be a metavariable?" Coccinelle also treats a given symbol %s as a metavariable. Better state explicitly that this is not the case. --- parsing_cocci/check_meta.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parsing_cocci/check_meta.ml b/parsing_cocci/check_meta.ml index e728d8f5..b857d3f6 100644 --- a/parsing_cocci/check_meta.ml +++ b/parsing_cocci/check_meta.ml @@ -84,7 +84,7 @@ let rec ident context old_metas table minus i = not err(* warn only once per id *) && not info.Ast0.isSymbolIdent then warning - (Printf.sprintf "line %d: should %s be a metavariable?" rl name) + (Printf.sprintf "line %d: should %s be a metavariable? treating it as symbol." rl name) | _ -> ()) | Ast0.MetaId(name,_,seedval,_) -> check_table table minus name; -- 2.20.1 _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci