From: Tom Rini Date: Wed, 25 Sep 2019 17:21:16 -0400 Subject: [U-Boot] [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig define In-Reply-To: References: <20190818213603.28171-1-lukma@denx.de> <20190818213603.28171-9-lukma@denx.de> <20190917092225.00b5439d@jawa> <20190917230642.19cce14d@jawa> Message-ID: <20190925212116.GH11486@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Sep 25, 2019 at 02:42:03PM -0600, Simon Glass wrote: > Hi Lukasz, > > On Tue, 17 Sep 2019 at 15:06, Lukasz Majewski wrote: > > > > On Tue, 17 Sep 2019 14:19:33 -0500 > > Adam Ford wrote: > > > > > On Tue, Sep 17, 2019 at 1:34 PM Simon Glass wrote: > > > > > > > > Hi Lukasz, > > > > > > > > On Tue, 17 Sep 2019 at 00:22, Lukasz Majewski > > > > wrote: > > > > > > > > > > Hi Simon, > > > > > > > > > > > On Sun, 18 Aug 2019 at 19:30, Peng Fan > > > > > > wrote: > > > > > > > > > > > > > > > Subject: [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig > > > > > > > > define > > > > > > > > > > > > > > > > This define indicates if DM_GPIO shall be supported in SPL. > > > > > > > > This allows proper operation of DM converted GPIO drivers > > > > > > > > in SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also > > > > > > > > support not yet DM/DTS converted boards. > > > > > > > > > > > > > > Many of the drivers list the SPL_DM options under their respective > > > heading. For example, SPL_DM_USB is under the USB menu right next to > > > the option to select CONFIG_DM_USB. > > > If we're going to add the option to separate DM_GPIO from SPL_DM_GPIO, > > > I would suggest following that pattern and place it in the GPIO menu > > > so they are next to each other and make the dependency obvious. > > > > For the current patch I've followed the pattern and added SPL_DM_GPIO > > to the "spl" submenu of menuconfig. > > > > And as I've written in the other mail - I think that SPL_DM_GPIO shall > > depend on DM_GPIO. > > > > Considering the above - shall I place SPL_DM_GPIO next to DM_GPIO > > section or to the "spl" submenu? > > That makes sense to me. At some point we should change them all. > > +Tom Rini for comment too Should we get consistent? Yes. One of our not yet solved well enough problems is what are we going to do about SPL/TPL, image size and conflicting requirements. For now I think having these options be in the spl menu makes some future shuffling easier to do. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: