From: "james qian wang (Arm Technology China)" Subject: Re: drm/komeda: Adds power management support Date: Thu, 26 Sep 2019 03:25:33 +0000 Message-ID: <20190926032526.GA5374@jamwan02-TSP300> References: <20190923015908.26627-1-lowry.li@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id B281B6EC34 for ; Thu, 26 Sep 2019 03:25:54 +0000 (UTC) In-Reply-To: <20190923015908.26627-1-lowry.li@arm.com> Content-Language: en-US Content-ID: <749D52C9C4E423429C4D8095F1855F04@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Lowry Li (Arm Technology China)" Cc: nd , Ayan Halder , "airlied@linux.ie" , Liviu Dudau , "Jonathan Chai (Arm Technology China)" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Julien Yin (Arm Technology China)" , "seanpaul@chromium.org" , Mihail Atanassov List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBTZXAgMjMsIDIwMTkgYXQgMDE6NTk6MjVBTSArMDAwMCwgTG93cnkgTGkgKEFybSBU ZWNobm9sb2d5IENoaW5hKSB3cm90ZToKPiBGcm9tOiAiTG93cnkgTGkgKEFybSBUZWNobm9sb2d5 IENoaW5hKSIgPExvd3J5LkxpQGFybS5jb20+Cj4gCj4gQWRkcyBzeXN0ZW0gcG93ZXIgbWFuYWdl bWVudCBzdXBwb3J0IGluIEtNUyBrZXJuZWwgZHJpdmVyLgo+IAo+IERlcGVuZHMgb246Cj4gaHR0 cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Nlcmllcy82MjM3Ny8KPiAKPiBDaGFuZ2Vz IHNpbmNlIHYxOgo+IFNpbmNlIHdlIGhhdmUgdW5pZmllZCBtY2xrL3BjbGsvcGlwZWxpbmUtPmFj bGsgdG8gb25lIG1jbGssIHdoaWNoIHdpbGwKPiBiZSB0dXJuZWQgb24vb2ZmIHdoZW4gY3J0YyBh dG9taWMgZW5hYmxlL2Rpc2FibGUsIHJlbW92ZWQgcnVudGltZSBwb3dlcgo+IG1hbmFnZW1lbnQu Cj4gUmVtb3ZlcyBydW4gdGltZSBnZXQvcHV0IHJlbGF0ZWQgZmxvdy4KPiBBZGRzIHRvIGRpc2Fi bGUgdGhlIGFjbGsgd2hlbiByZWdpc3RlciBhY2Nlc3MgZmluaXNoZWQuCj4gCj4gQ2hhbmdlcyBz aW5jZSB2MjoKPiBSZWJhc2VzIHRvIHRoZSBkcm0tbWlzYy1uZXh0IGJyYW5jaC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBMb3dyeSBMaSAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpIDxsb3dyeS5saUBhcm0u Y29tPgoKTG9va3MgZ29vZCB0byBtZS4KClJldmlld2VkLWJ5OiBKYW1lcyBRaWFuIFdhbmcgKEFy bSBUZWNobm9sb2d5IENoaW5hKSA8amFtZXMucWlhbi53YW5nQGFybS5jb20+Cgp3aWxsIHB1c2gg aXQgdG8gZHJtLW1pc2MtbmV4dC4KCj4gLS0tCj4gIC4uLi9ncHUvZHJtL2FybS9kaXNwbGF5L2tv bWVkYS9rb21lZGFfY3J0Yy5jICB8ICAxIC0KPiAgLi4uL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29t ZWRhL2tvbWVkYV9kZXYuYyAgIHwgNjUgKysrKysrKysrKysrKysrKystLQo+ICAuLi4vZ3B1L2Ry bS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Rldi5oICAgfCAgMyArCj4gIC4uLi9ncHUvZHJt L2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZHJ2LmMgICB8IDMwICsrKysrKysrLQo+ICA0IGZp bGVzIGNoYW5nZWQsIDkxIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2NydGMuYyBi L2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2NydGMuYwo+IGluZGV4 IDM4ZDVjYjIwZTkwOC4uYjQ3YzBkYWJkMGQxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2NydGMuYwo+IEBAIC01LDcgKzUsNiBAQAo+ICAg Kgo+ICAgKi8KPiAgI2luY2x1ZGUgPGxpbnV4L2Nsay5oPgo+IC0jaW5jbHVkZSA8bGludXgvcG1f cnVudGltZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvc3BpbmxvY2suaD4KPiAgCj4gICNpbmNsdWRl IDxkcm0vZHJtX2F0b21pYy5oPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rp c3BsYXkva29tZWRhL2tvbWVkYV9kZXYuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9r b21lZGEva29tZWRhX2Rldi5jCj4gaW5kZXggYmVlNDYzM2NkZDlmLi44YTAzMzI0ZjAyYTUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZGV2 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9kZXYu Ywo+IEBAIC0yNTgsNyArMjU4LDcgQEAgc3RydWN0IGtvbWVkYV9kZXYgKmtvbWVkYV9kZXZfY3Jl YXRlKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCQkJICBwcm9kdWN0LT5wcm9kdWN0X2lkLAo+ICAJ CQkgIE1BTElEUF9DT1JFX0lEX1BST0RVQ1RfSUQobWRldi0+Y2hpcC5jb3JlX2lkKSk7Cj4gIAkJ ZXJyID0gLUVOT0RFVjsKPiAtCQlnb3RvIGVycl9jbGVhbnVwOwo+ICsJCWdvdG8gZGlzYWJsZV9j bGs7Cj4gIAl9Cj4gIAo+ICAJRFJNX0lORk8oIkZvdW5kIEFSTSBNYWxpLUQleCB2ZXJzaW9uIHIl ZHAlZFxuIiwKPiBAQCAtMjcxLDE5ICsyNzEsMTkgQEAgc3RydWN0IGtvbWVkYV9kZXYgKmtvbWVk YV9kZXZfY3JlYXRlKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCWVyciA9IG1kZXYtPmZ1bmNzLT5l bnVtX3Jlc291cmNlcyhtZGV2KTsKPiAgCWlmIChlcnIpIHsKPiAgCQlEUk1fRVJST1IoImVudW1l cmF0ZSBkaXNwbGF5IHJlc291cmNlIGZhaWxlZC5cbiIpOwo+IC0JCWdvdG8gZXJyX2NsZWFudXA7 Cj4gKwkJZ290byBkaXNhYmxlX2NsazsKPiAgCX0KPiAgCj4gIAllcnIgPSBrb21lZGFfcGFyc2Vf ZHQoZGV2LCBtZGV2KTsKPiAgCWlmIChlcnIpIHsKPiAgCQlEUk1fRVJST1IoInBhcnNlIGRldmlj ZSB0cmVlIGZhaWxlZC5cbiIpOwo+IC0JCWdvdG8gZXJyX2NsZWFudXA7Cj4gKwkJZ290byBkaXNh YmxlX2NsazsKPiAgCX0KPiAgCj4gIAllcnIgPSBrb21lZGFfYXNzZW1ibGVfcGlwZWxpbmVzKG1k ZXYpOwo+ICAJaWYgKGVycikgewo+ICAJCURSTV9FUlJPUigiYXNzZW1ibGUgZGlzcGxheSBwaXBl bGluZXMgZmFpbGVkLlxuIik7Cj4gLQkJZ290byBlcnJfY2xlYW51cDsKPiArCQlnb3RvIGRpc2Fi bGVfY2xrOwo+ICAJfQo+ICAKPiAgCWRldi0+ZG1hX3Bhcm1zID0gJm1kZXYtPmRtYV9wYXJtczsK PiBAQCAtMjk2LDExICsyOTYsMTQgQEAgc3RydWN0IGtvbWVkYV9kZXYgKmtvbWVkYV9kZXZfY3Jl YXRlKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCWlmIChtZGV2LT5pb21tdSAmJiBtZGV2LT5mdW5j cy0+Y29ubmVjdF9pb21tdSkgewo+ICAJCWVyciA9IG1kZXYtPmZ1bmNzLT5jb25uZWN0X2lvbW11 KG1kZXYpOwo+ICAJCWlmIChlcnIpIHsKPiArCQkJRFJNX0VSUk9SKCJjb25uZWN0IGlvbW11IGZh aWxlZC5cbiIpOwo+ICAJCQltZGV2LT5pb21tdSA9IE5VTEw7Cj4gLQkJCWdvdG8gZXJyX2NsZWFu dXA7Cj4gKwkJCWdvdG8gZGlzYWJsZV9jbGs7Cj4gIAkJfQo+ICAJfQo+ICAKPiArCWNsa19kaXNh YmxlX3VucHJlcGFyZShtZGV2LT5hY2xrKTsKPiArCj4gIAllcnIgPSBzeXNmc19jcmVhdGVfZ3Jv dXAoJmRldi0+a29iaiwgJmtvbWVkYV9zeXNmc19hdHRyX2dyb3VwKTsKPiAgCWlmIChlcnIpIHsK PiAgCQlEUk1fRVJST1IoImNyZWF0ZSBzeXNmcyBncm91cCBmYWlsZWQuXG4iKTsKPiBAQCAtMzEz LDYgKzMxNiw4IEBAIHN0cnVjdCBrb21lZGFfZGV2ICprb21lZGFfZGV2X2NyZWF0ZShzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4gIAo+ICAJcmV0dXJuIG1kZXY7Cj4gIAo+ICtkaXNhYmxlX2NsazoKPiAr CWNsa19kaXNhYmxlX3VucHJlcGFyZShtZGV2LT5hY2xrKTsKPiAgZXJyX2NsZWFudXA6Cj4gIAlr b21lZGFfZGV2X2Rlc3Ryb3kobWRldik7Cj4gIAlyZXR1cm4gRVJSX1BUUihlcnIpOwo+IEBAIC0z MzAsOCArMzM1LDEyIEBAIHZvaWQga29tZWRhX2Rldl9kZXN0cm95KHN0cnVjdCBrb21lZGFfZGV2 ICptZGV2KQo+ICAJZGVidWdmc19yZW1vdmVfcmVjdXJzaXZlKG1kZXYtPmRlYnVnZnNfcm9vdCk7 Cj4gICNlbmRpZgo+ICAKPiArCWlmIChtZGV2LT5hY2xrKQo+ICsJCWNsa19wcmVwYXJlX2VuYWJs ZShtZGV2LT5hY2xrKTsKPiArCj4gIAlpZiAobWRldi0+aW9tbXUgJiYgbWRldi0+ZnVuY3MtPmRp c2Nvbm5lY3RfaW9tbXUpCj4gLQkJbWRldi0+ZnVuY3MtPmRpc2Nvbm5lY3RfaW9tbXUobWRldik7 Cj4gKwkJaWYgKG1kZXYtPmZ1bmNzLT5kaXNjb25uZWN0X2lvbW11KG1kZXYpKQo+ICsJCQlEUk1f RVJST1IoImRpc2Nvbm5lY3QgaW9tbXUgZmFpbGVkLlxuIik7Cj4gIAltZGV2LT5pb21tdSA9IE5V TEw7Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IG1kZXYtPm5fcGlwZWxpbmVzOyBpKyspIHsKPiBA QCAtMzU5LDMgKzM2OCw0NyBAQCB2b2lkIGtvbWVkYV9kZXZfZGVzdHJveShzdHJ1Y3Qga29tZWRh X2RldiAqbWRldikKPiAgCj4gIAlkZXZtX2tmcmVlKGRldiwgbWRldik7Cj4gIH0KPiArCj4gK2lu dCBrb21lZGFfZGV2X3Jlc3VtZShzdHJ1Y3Qga29tZWRhX2RldiAqbWRldikKPiArewo+ICsJaW50 IHJldCA9IDA7Cj4gKwo+ICsJY2xrX3ByZXBhcmVfZW5hYmxlKG1kZXYtPmFjbGspOwo+ICsKPiAr CWlmIChtZGV2LT5pb21tdSAmJiBtZGV2LT5mdW5jcy0+Y29ubmVjdF9pb21tdSkgewo+ICsJCXJl dCA9IG1kZXYtPmZ1bmNzLT5jb25uZWN0X2lvbW11KG1kZXYpOwo+ICsJCWlmIChyZXQgPCAwKSB7 Cj4gKwkJCURSTV9FUlJPUigiY29ubmVjdCBpb21tdSBmYWlsZWQuXG4iKTsKPiArCQkJZ290byBk aXNhYmxlX2NsazsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0ID0gbWRldi0+ZnVuY3MtPmVuYWJs ZV9pcnEobWRldik7Cj4gKwo+ICtkaXNhYmxlX2NsazoKPiArCWNsa19kaXNhYmxlX3VucHJlcGFy ZShtZGV2LT5hY2xrKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICtpbnQga29tZWRh X2Rldl9zdXNwZW5kKHN0cnVjdCBrb21lZGFfZGV2ICptZGV2KQo+ICt7Cj4gKwlpbnQgcmV0ID0g MDsKPiArCj4gKwljbGtfcHJlcGFyZV9lbmFibGUobWRldi0+YWNsayk7Cj4gKwo+ICsJaWYgKG1k ZXYtPmlvbW11ICYmIG1kZXYtPmZ1bmNzLT5kaXNjb25uZWN0X2lvbW11KSB7Cj4gKwkJcmV0ID0g bWRldi0+ZnVuY3MtPmRpc2Nvbm5lY3RfaW9tbXUobWRldik7Cj4gKwkJaWYgKHJldCA8IDApIHsK PiArCQkJRFJNX0VSUk9SKCJkaXNjb25uZWN0IGlvbW11IGZhaWxlZC5cbiIpOwo+ICsJCQlnb3Rv IGRpc2FibGVfY2xrOwo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXQgPSBtZGV2LT5mdW5jcy0+ZGlz YWJsZV9pcnEobWRldik7Cj4gKwo+ICtkaXNhYmxlX2NsazoKPiArCWNsa19kaXNhYmxlX3VucHJl cGFyZShtZGV2LT5hY2xrKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Rldi5oIGIvZHJpdmVy cy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZGV2LmgKPiBpbmRleCA4YWNmOGMw NjAxY2MuLjQxNDIwMDIzM2I2NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rp c3BsYXkva29tZWRhL2tvbWVkYV9kZXYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlz cGxheS9rb21lZGEva29tZWRhX2Rldi5oCj4gQEAgLTIyNCw0ICsyMjQsNyBAQCB2b2lkIGtvbWVk YV9wcmludF9ldmVudHMoc3RydWN0IGtvbWVkYV9ldmVudHMgKmV2dHMpOwo+ICBzdGF0aWMgaW5s aW5lIHZvaWQga29tZWRhX3ByaW50X2V2ZW50cyhzdHJ1Y3Qga29tZWRhX2V2ZW50cyAqZXZ0cykg e30KPiAgI2VuZGlmCj4gIAo+ICtpbnQga29tZWRhX2Rldl9yZXN1bWUoc3RydWN0IGtvbWVkYV9k ZXYgKm1kZXYpOwo+ICtpbnQga29tZWRhX2Rldl9zdXNwZW5kKHN0cnVjdCBrb21lZGFfZGV2ICpt ZGV2KTsKPiArCj4gICNlbmRpZiAvKl9LT01FREFfREVWX0hfKi8KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9kcnYuYwo+IGluZGV4IDY5YWNlNmY5MDU1 ZC4uZDZjMjIyMmM1ZDMzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxh eS9rb21lZGEva29tZWRhX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5 L2tvbWVkYS9rb21lZGFfZHJ2LmMKPiBAQCAtOCw2ICs4LDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4 L2tlcm5lbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gICNpbmNs dWRlIDxsaW51eC9jb21wb25lbnQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3BtX3J1bnRpbWUuaD4K PiAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPiAgI2luY2x1ZGUgImtvbWVkYV9kZXYuaCIKPiAg I2luY2x1ZGUgImtvbWVkYV9rbXMuaCIKPiBAQCAtMTM2LDEzICsxMzcsNDAgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQga29tZWRhX29mX21hdGNoW10gPSB7Cj4gIAo+ICBNT0RV TEVfREVWSUNFX1RBQkxFKG9mLCBrb21lZGFfb2ZfbWF0Y2gpOwo+ICAKPiArc3RhdGljIGludCBf X21heWJlX3VudXNlZCBrb21lZGFfcG1fc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sK PiArCXN0cnVjdCBrb21lZGFfZHJ2ICptZHJ2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwlz dHJ1Y3QgZHJtX2RldmljZSAqZHJtID0gJm1kcnYtPmttcy0+YmFzZTsKPiArCWludCByZXM7Cj4g Kwo+ICsJcmVzID0gZHJtX21vZGVfY29uZmlnX2hlbHBlcl9zdXNwZW5kKGRybSk7Cj4gKwo+ICsJ a29tZWRhX2Rldl9zdXNwZW5kKG1kcnYtPm1kZXYpOwo+ICsKPiArCXJldHVybiByZXM7Cj4gK30K PiArCj4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQga29tZWRhX3BtX3Jlc3VtZShzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCBrb21lZGFfZHJ2ICptZHJ2ID0gZGV2X2dldF9k cnZkYXRhKGRldik7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtID0gJm1kcnYtPmttcy0+YmFz ZTsKPiArCj4gKwlrb21lZGFfZGV2X3Jlc3VtZShtZHJ2LT5tZGV2KTsKPiArCj4gKwlyZXR1cm4g ZHJtX21vZGVfY29uZmlnX2hlbHBlcl9yZXN1bWUoZHJtKTsKPiArfQo+ICsKPiArc3RhdGljIGNv bnN0IHN0cnVjdCBkZXZfcG1fb3BzIGtvbWVkYV9wbV9vcHMgPSB7Cj4gKwlTRVRfU1lTVEVNX1NM RUVQX1BNX09QUyhrb21lZGFfcG1fc3VzcGVuZCwga29tZWRhX3BtX3Jlc3VtZSkKPiArfTsKPiAr Cj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGtvbWVkYV9wbGF0Zm9ybV9kcml2ZXIg PSB7Cj4gIAkucHJvYmUJPSBrb21lZGFfcGxhdGZvcm1fcHJvYmUsCj4gIAkucmVtb3ZlCT0ga29t ZWRhX3BsYXRmb3JtX3JlbW92ZSwKPiAgCS5kcml2ZXIJPSB7Cj4gIAkJLm5hbWUgPSAia29tZWRh IiwKPiAgCQkub2ZfbWF0Y2hfdGFibGUJPSBrb21lZGFfb2ZfbWF0Y2gsCj4gLQkJLnBtID0gTlVM TCwKPiArCQkucG0gPSAma29tZWRhX3BtX29wcywKPiAgCX0sCj4gIH07Cj4gIApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=