From: Steven Price Subject: [PATCH v2] drm: Don't free jobs in wait_event_interruptible() Date: Thu, 26 Sep 2019 10:54:58 +0100 Message-ID: <20190926095458.50020-1-steven.price@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id CE7926ECED for ; Thu, 26 Sep 2019 09:55:11 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , David Airlie , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: Sharat Masetty , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Steven Price , Nayan Deshmukh , Alex Deucher List-Id: dri-devel@lists.freedesktop.org ZHJtX3NjaGVkX2NsZWFudXBfam9icygpIGF0dGVtcHRzIHRvIGZyZWUgZmluaXNoZWQgam9icywg aG93ZXZlciBiZWNhdXNlCml0IGlzIGNhbGxlZCBhcyB0aGUgY29uZGl0aW9uIG9mIHdhaXRfZXZl bnRfaW50ZXJydXB0aWJsZSgpIGl0IG11c3Qgbm90CnNsZWVwLiBVbmZvcnR1YW50bHkgc29tZSBm cmVlIGNhbGxiYWNrcyAobm90aWJseSBmb3IgUGFuZnJvc3QpIGRvIHNsZWVwLgoKSW5zdGVhZCBs ZXQncyByZW5hbWUgZHJtX3NjaGVkX2NsZWFudXBfam9icygpIHRvCmRybV9zY2hlZF9nZXRfY2xl YW51cF9qb2IoKSBhbmQgc2ltcGx5IHJldHVybiBhIGpvYiBmb3IgcHJvY2Vzc2luZyBpZgp0aGVy ZSBpcyBvbmUuIFRoZSBjYWxsZXIgY2FuIHRoZW4gY2FsbCB0aGUgZnJlZV9qb2IoKSBjYWxsYmFj ayBvdXRzaWRlCnRoZSB3YWl0X2V2ZW50X2ludGVycnVwdGlibGUoKSB3aGVyZSBzbGVlcGluZyBp cyBwb3NzaWJsZSBiZWZvcmUKcmUtY2hlY2tpbmcgYW5kIHJldHVybmluZyB0byBzbGVlcCBpZiBu ZWNlc3NhcnkuCgpTaWduZWQtb2ZmLWJ5OiBTdGV2ZW4gUHJpY2UgPHN0ZXZlbi5wcmljZUBhcm0u Y29tPgotLS0KCkNoYW5nZXMgZnJvbSB2MToKICogTW92ZSBsaXN0X2ZpcnN0X2VudHJ5X29yX251 bGwoKSB3aXRoaW4gdGhlIGxvY2sKCiBkcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21h aW4uYyB8IDQ0ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjQg aW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3Nj aGVkX21haW4uYwppbmRleCA5YTBlZTc0ZDgyZGMuLjBlZDRhYWE0ZTZkMSAxMDA2NDQKLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKKysrIGIvZHJpdmVycy9ncHUv ZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKQEAgLTYyMiw0MyArNjIyLDQxIEBAIHN0YXRpYyB2 b2lkIGRybV9zY2hlZF9wcm9jZXNzX2pvYihzdHJ1Y3QgZG1hX2ZlbmNlICpmLCBzdHJ1Y3QgZG1h X2ZlbmNlX2NiICpjYikKIH0KIAogLyoqCi0gKiBkcm1fc2NoZWRfY2xlYW51cF9qb2JzIC0gZGVz dHJveSBmaW5pc2hlZCBqb2JzCisgKiBkcm1fc2NoZWRfZ2V0X2NsZWFudXBfam9iIC0gZmV0Y2gg dGhlIG5leHQgZmluaXNoZWQgam9iIHRvIGJlIGRlc3Ryb3llZAogICoKICAqIEBzY2hlZDogc2No ZWR1bGVyIGluc3RhbmNlCiAgKgotICogUmVtb3ZlIGFsbCBmaW5pc2hlZCBqb2JzIGZyb20gdGhl IG1pcnJvciBsaXN0IGFuZCBkZXN0cm95IHRoZW0uCisgKiBSZXR1cm5zIHRoZSBuZXh0IGZpbmlz aGVkIGpvYiBmcm9tIHRoZSBtaXJyb3IgbGlzdCAoaWYgdGhlcmUgaXMgb25lKQorICogcmVhZHkg Zm9yIGl0IHRvIGJlIGRlc3Ryb3llZC4KICAqLwotc3RhdGljIHZvaWQgZHJtX3NjaGVkX2NsZWFu dXBfam9icyhzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQorc3RhdGljIHN0cnVjdCBk cm1fc2NoZWRfam9iICoKK2RybV9zY2hlZF9nZXRfY2xlYW51cF9qb2Ioc3RydWN0IGRybV9ncHVf c2NoZWR1bGVyICpzY2hlZCkKIHsKKwlzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqam9iID0gTlVMTDsK IAl1bnNpZ25lZCBsb25nIGZsYWdzOwogCiAJLyogRG9uJ3QgZGVzdHJveSBqb2JzIHdoaWxlIHRo ZSB0aW1lb3V0IHdvcmtlciBpcyBydW5uaW5nICovCiAJaWYgKHNjaGVkLT50aW1lb3V0ICE9IE1B WF9TQ0hFRFVMRV9USU1FT1VUICYmCiAJICAgICFjYW5jZWxfZGVsYXllZF93b3JrKCZzY2hlZC0+ d29ya190ZHIpKQotCQlyZXR1cm47Ci0KLQotCXdoaWxlICghbGlzdF9lbXB0eSgmc2NoZWQtPnJp bmdfbWlycm9yX2xpc3QpKSB7Ci0JCXN0cnVjdCBkcm1fc2NoZWRfam9iICpqb2I7CisJCXJldHVy biBOVUxMOwogCi0JCWpvYiA9IGxpc3RfZmlyc3RfZW50cnkoJnNjaGVkLT5yaW5nX21pcnJvcl9s aXN0LAorCWpvYiA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmc2NoZWQtPnJpbmdfbWlycm9y X2xpc3QsCiAJCQkJICAgICAgIHN0cnVjdCBkcm1fc2NoZWRfam9iLCBub2RlKTsKLQkJaWYgKCFk bWFfZmVuY2VfaXNfc2lnbmFsZWQoJmpvYi0+c19mZW5jZS0+ZmluaXNoZWQpKQotCQkJYnJlYWs7 CiAKLQkJc3Bpbl9sb2NrX2lycXNhdmUoJnNjaGVkLT5qb2JfbGlzdF9sb2NrLCBmbGFncyk7CisJ c3Bpbl9sb2NrX2lycXNhdmUoJnNjaGVkLT5qb2JfbGlzdF9sb2NrLCBmbGFncyk7CisKKwlpZiAo am9iICYmIGRtYV9mZW5jZV9pc19zaWduYWxlZCgmam9iLT5zX2ZlbmNlLT5maW5pc2hlZCkpIHsK IAkJLyogcmVtb3ZlIGpvYiBmcm9tIHJpbmdfbWlycm9yX2xpc3QgKi8KIAkJbGlzdF9kZWxfaW5p dCgmam9iLT5ub2RlKTsKLQkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmc2NoZWQtPmpvYl9saXN0 X2xvY2ssIGZsYWdzKTsKLQotCQlzY2hlZC0+b3BzLT5mcmVlX2pvYihqb2IpOworCX0gZWxzZSB7 CisJCWpvYiA9IE5VTEw7CisJCS8qIHF1ZXVlIHRpbWVvdXQgZm9yIG5leHQgam9iICovCisJCWRy bV9zY2hlZF9zdGFydF90aW1lb3V0KHNjaGVkKTsKIAl9CiAKLQkvKiBxdWV1ZSB0aW1lb3V0IGZv ciBuZXh0IGpvYiAqLwotCXNwaW5fbG9ja19pcnFzYXZlKCZzY2hlZC0+am9iX2xpc3RfbG9jaywg ZmxhZ3MpOwotCWRybV9zY2hlZF9zdGFydF90aW1lb3V0KHNjaGVkKTsKIAlzcGluX3VubG9ja19p cnFyZXN0b3JlKCZzY2hlZC0+am9iX2xpc3RfbG9jaywgZmxhZ3MpOwogCisJcmV0dXJuIGpvYjsK IH0KIAogLyoqCkBAIC02OTgsMTIgKzY5NiwxOCBAQCBzdGF0aWMgaW50IGRybV9zY2hlZF9tYWlu KHZvaWQgKnBhcmFtKQogCQlzdHJ1Y3QgZHJtX3NjaGVkX2ZlbmNlICpzX2ZlbmNlOwogCQlzdHJ1 Y3QgZHJtX3NjaGVkX2pvYiAqc2NoZWRfam9iOwogCQlzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZTsK KwkJc3RydWN0IGRybV9zY2hlZF9qb2IgKmNsZWFudXBfam9iID0gTlVMTDsKIAogCQl3YWl0X2V2 ZW50X2ludGVycnVwdGlibGUoc2NoZWQtPndha2VfdXBfd29ya2VyLAotCQkJCQkgKGRybV9zY2hl ZF9jbGVhbnVwX2pvYnMoc2NoZWQpLAorCQkJCQkgKGNsZWFudXBfam9iID0gZHJtX3NjaGVkX2dl dF9jbGVhbnVwX2pvYihzY2hlZCkpIHx8CiAJCQkJCSAoIWRybV9zY2hlZF9ibG9ja2VkKHNjaGVk KSAmJgogCQkJCQkgIChlbnRpdHkgPSBkcm1fc2NoZWRfc2VsZWN0X2VudGl0eShzY2hlZCkpKSB8 fAotCQkJCQkga3RocmVhZF9zaG91bGRfc3RvcCgpKSk7CisJCQkJCSBrdGhyZWFkX3Nob3VsZF9z dG9wKCkpOworCisJCXdoaWxlIChjbGVhbnVwX2pvYikgeworCQkJc2NoZWQtPm9wcy0+ZnJlZV9q b2IoY2xlYW51cF9qb2IpOworCQkJY2xlYW51cF9qb2IgPSBkcm1fc2NoZWRfZ2V0X2NsZWFudXBf am9iKHNjaGVkKTsKKwkJfQogCiAJCWlmICghZW50aXR5KQogCQkJY29udGludWU7Ci0tIAoyLjIw LjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==