From: Steven Price Subject: [PATCH v3] drm: Don't free jobs in wait_event_interruptible() Date: Thu, 26 Sep 2019 13:31:34 +0100 Message-ID: <20190926123134.4947-1-steven.price@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id E23C36ED04 for ; Thu, 26 Sep 2019 12:31:41 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , David Airlie , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: Sharat Masetty , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Steven Price , Nayan Deshmukh , Alex Deucher List-Id: dri-devel@lists.freedesktop.org ZHJtX3NjaGVkX2NsZWFudXBfam9icygpIGF0dGVtcHRzIHRvIGZyZWUgZmluaXNoZWQgam9icywg aG93ZXZlciBiZWNhdXNlCml0IGlzIGNhbGxlZCBhcyB0aGUgY29uZGl0aW9uIG9mIHdhaXRfZXZl bnRfaW50ZXJydXB0aWJsZSgpIGl0IG11c3Qgbm90CnNsZWVwLiBVbmZvcnR1YW50bHkgc29tZSBm cmVlIGNhbGxiYWNrcyAobm90aWJseSBmb3IgUGFuZnJvc3QpIGRvIHNsZWVwLgoKSW5zdGVhZCBs ZXQncyByZW5hbWUgZHJtX3NjaGVkX2NsZWFudXBfam9icygpIHRvCmRybV9zY2hlZF9nZXRfY2xl YW51cF9qb2IoKSBhbmQgc2ltcGx5IHJldHVybiBhIGpvYiBmb3IgcHJvY2Vzc2luZyBpZgp0aGVy ZSBpcyBvbmUuIFRoZSBjYWxsZXIgY2FuIHRoZW4gY2FsbCB0aGUgZnJlZV9qb2IoKSBjYWxsYmFj ayBvdXRzaWRlCnRoZSB3YWl0X2V2ZW50X2ludGVycnVwdGlibGUoKSB3aGVyZSBzbGVlcGluZyBp cyBwb3NzaWJsZSBiZWZvcmUKcmUtY2hlY2tpbmcgYW5kIHJldHVybmluZyB0byBzbGVlcCBpZiBu ZWNlc3NhcnkuCgpTaWduZWQtb2ZmLWJ5OiBTdGV2ZW4gUHJpY2UgPHN0ZXZlbi5wcmljZUBhcm0u Y29tPgotLS0KCkNoYW5nZXMgZnJvbSB2MjoKICogQWN0dWFsbHkgbW92ZSBsaXN0X2ZpcnN0X2Vu dHJ5X29yX251bGwoKSB3aXRoaW4gdGhlIGxvY2sKCiBkcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVy L3NjaGVkX21haW4uYyB8IDQyICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hh bmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMgYi9kcml2ZXJzL2dwdS9kcm0vc2No ZWR1bGVyL3NjaGVkX21haW4uYwppbmRleCA5YTBlZTc0ZDgyZGMuLmU0YmQ3OTJmMmIyOSAxMDA2 NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKKysrIGIvZHJp dmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKQEAgLTYyMiw0MyArNjIyLDQxIEBA IHN0YXRpYyB2b2lkIGRybV9zY2hlZF9wcm9jZXNzX2pvYihzdHJ1Y3QgZG1hX2ZlbmNlICpmLCBz dHJ1Y3QgZG1hX2ZlbmNlX2NiICpjYikKIH0KIAogLyoqCi0gKiBkcm1fc2NoZWRfY2xlYW51cF9q b2JzIC0gZGVzdHJveSBmaW5pc2hlZCBqb2JzCisgKiBkcm1fc2NoZWRfZ2V0X2NsZWFudXBfam9i IC0gZmV0Y2ggdGhlIG5leHQgZmluaXNoZWQgam9iIHRvIGJlIGRlc3Ryb3llZAogICoKICAqIEBz Y2hlZDogc2NoZWR1bGVyIGluc3RhbmNlCiAgKgotICogUmVtb3ZlIGFsbCBmaW5pc2hlZCBqb2Jz IGZyb20gdGhlIG1pcnJvciBsaXN0IGFuZCBkZXN0cm95IHRoZW0uCisgKiBSZXR1cm5zIHRoZSBu ZXh0IGZpbmlzaGVkIGpvYiBmcm9tIHRoZSBtaXJyb3IgbGlzdCAoaWYgdGhlcmUgaXMgb25lKQor ICogcmVhZHkgZm9yIGl0IHRvIGJlIGRlc3Ryb3llZC4KICAqLwotc3RhdGljIHZvaWQgZHJtX3Nj aGVkX2NsZWFudXBfam9icyhzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQorc3RhdGlj IHN0cnVjdCBkcm1fc2NoZWRfam9iICoKK2RybV9zY2hlZF9nZXRfY2xlYW51cF9qb2Ioc3RydWN0 IGRybV9ncHVfc2NoZWR1bGVyICpzY2hlZCkKIHsKKwlzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqam9i ID0gTlVMTDsKIAl1bnNpZ25lZCBsb25nIGZsYWdzOwogCiAJLyogRG9uJ3QgZGVzdHJveSBqb2Jz IHdoaWxlIHRoZSB0aW1lb3V0IHdvcmtlciBpcyBydW5uaW5nICovCiAJaWYgKHNjaGVkLT50aW1l b3V0ICE9IE1BWF9TQ0hFRFVMRV9USU1FT1VUICYmCiAJICAgICFjYW5jZWxfZGVsYXllZF93b3Jr KCZzY2hlZC0+d29ya190ZHIpKQotCQlyZXR1cm47Ci0KKwkJcmV0dXJuIE5VTEw7CiAKLQl3aGls ZSAoIWxpc3RfZW1wdHkoJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0KSkgewotCQlzdHJ1Y3QgZHJt X3NjaGVkX2pvYiAqam9iOworCXNwaW5fbG9ja19pcnFzYXZlKCZzY2hlZC0+am9iX2xpc3RfbG9j aywgZmxhZ3MpOwogCi0JCWpvYiA9IGxpc3RfZmlyc3RfZW50cnkoJnNjaGVkLT5yaW5nX21pcnJv cl9saXN0LAorCWpvYiA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmc2NoZWQtPnJpbmdfbWly cm9yX2xpc3QsCiAJCQkJICAgICAgIHN0cnVjdCBkcm1fc2NoZWRfam9iLCBub2RlKTsKLQkJaWYg KCFkbWFfZmVuY2VfaXNfc2lnbmFsZWQoJmpvYi0+c19mZW5jZS0+ZmluaXNoZWQpKQotCQkJYnJl YWs7CiAKLQkJc3Bpbl9sb2NrX2lycXNhdmUoJnNjaGVkLT5qb2JfbGlzdF9sb2NrLCBmbGFncyk7 CisJaWYgKGpvYiAmJiBkbWFfZmVuY2VfaXNfc2lnbmFsZWQoJmpvYi0+c19mZW5jZS0+ZmluaXNo ZWQpKSB7CiAJCS8qIHJlbW92ZSBqb2IgZnJvbSByaW5nX21pcnJvcl9saXN0ICovCiAJCWxpc3Rf ZGVsX2luaXQoJmpvYi0+bm9kZSk7Ci0JCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnNjaGVkLT5q b2JfbGlzdF9sb2NrLCBmbGFncyk7Ci0KLQkJc2NoZWQtPm9wcy0+ZnJlZV9qb2Ioam9iKTsKKwl9 IGVsc2UgeworCQlqb2IgPSBOVUxMOworCQkvKiBxdWV1ZSB0aW1lb3V0IGZvciBuZXh0IGpvYiAq LworCQlkcm1fc2NoZWRfc3RhcnRfdGltZW91dChzY2hlZCk7CiAJfQogCi0JLyogcXVldWUgdGlt ZW91dCBmb3IgbmV4dCBqb2IgKi8KLQlzcGluX2xvY2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0 X2xvY2ssIGZsYWdzKTsKLQlkcm1fc2NoZWRfc3RhcnRfdGltZW91dChzY2hlZCk7CiAJc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsKIAorCXJldHVy biBqb2I7CiB9CiAKIC8qKgpAQCAtNjk4LDEyICs2OTYsMTggQEAgc3RhdGljIGludCBkcm1fc2No ZWRfbWFpbih2b2lkICpwYXJhbSkKIAkJc3RydWN0IGRybV9zY2hlZF9mZW5jZSAqc19mZW5jZTsK IAkJc3RydWN0IGRybV9zY2hlZF9qb2IgKnNjaGVkX2pvYjsKIAkJc3RydWN0IGRtYV9mZW5jZSAq ZmVuY2U7CisJCXN0cnVjdCBkcm1fc2NoZWRfam9iICpjbGVhbnVwX2pvYiA9IE5VTEw7CiAKIAkJ d2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKHNjaGVkLT53YWtlX3VwX3dvcmtlciwKLQkJCQkJIChk cm1fc2NoZWRfY2xlYW51cF9qb2JzKHNjaGVkKSwKKwkJCQkJIChjbGVhbnVwX2pvYiA9IGRybV9z Y2hlZF9nZXRfY2xlYW51cF9qb2Ioc2NoZWQpKSB8fAogCQkJCQkgKCFkcm1fc2NoZWRfYmxvY2tl ZChzY2hlZCkgJiYKIAkJCQkJICAoZW50aXR5ID0gZHJtX3NjaGVkX3NlbGVjdF9lbnRpdHkoc2No ZWQpKSkgfHwKLQkJCQkJIGt0aHJlYWRfc2hvdWxkX3N0b3AoKSkpOworCQkJCQkga3RocmVhZF9z aG91bGRfc3RvcCgpKTsKKworCQl3aGlsZSAoY2xlYW51cF9qb2IpIHsKKwkJCXNjaGVkLT5vcHMt PmZyZWVfam9iKGNsZWFudXBfam9iKTsKKwkJCWNsZWFudXBfam9iID0gZHJtX3NjaGVkX2dldF9j bGVhbnVwX2pvYihzY2hlZCk7CisJCX0KIAogCQlpZiAoIWVudGl0eSkKIAkJCWNvbnRpbnVlOwot LSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=