Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E2CC4360C for ; Fri, 27 Sep 2019 09:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB354207E0 for ; Fri, 27 Sep 2019 09:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726116AbfI0JpB (ORCPT ); Fri, 27 Sep 2019 05:45:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:2803 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfI0JpB (ORCPT ); Fri, 27 Sep 2019 05:45:01 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 02:45:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="204129727" Received: from kuha.fi.intel.com ([10.237.72.53]) by fmsmga001.fm.intel.com with SMTP; 27 Sep 2019 02:44:59 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 27 Sep 2019 12:44:58 +0300 Date: Fri, 27 Sep 2019 12:44:58 +0300 From: Heikki Krogerus To: Ajay Gupta Cc: "linux-usb@vger.kernel.org" Subject: Re: [PATCH 00/14] usb: typec: UCSI driver overhaul Message-ID: <20190927094458.GA23773@kuha.fi.intel.com> References: <20190926100727.71117-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Sep 27, 2019 at 12:13:57AM +0000, Ajay Gupta wrote: > Hi Heikki, > > -----Original Message----- > > From: Heikki Krogerus > > Sent: Thursday, September 26, 2019 3:07 AM > > To: Ajay Gupta > > Cc: linux-usb@vger.kernel.org > > Subject: [PATCH 00/14] usb: typec: UCSI driver overhaul > > > > Hi Ajay, > > > > Here's the pretty much complete rewrite of the I/O handling that I was > > talking about. The first seven patches are not actually related to > > this stuff, but I'm including them here because the rest of the series > > is made on top of them. I'm including also that fix patch I send you > > earlier. > > > > After this it should be easier to handle quirks. My idea how to handle > > the multi-instance connector alt modes is that we "emulate" the PPM in > > ucsi_ccg.c in order to handle them, so ucsi.c is not touched at all. > > > > We can now get the connector alternate modes that the actual > > controller supplies during probe - before registering the ucsi > > interface - and squash all alt modes with the same SVID into one that > > we supply to the ucsi.c when ever it sends GET_ALTERNATE_MODES > > command. Also other alt mode commands like SET_NEW_CAM can have > > special processing in ucsi_ccg.c and ucsi_ccg.c alone. There should > > not be any problem with that anymore. > I took the changes and loaded on my GPU system and do not see > altmode devices under /sys/bus/typec/devices/*. Its empty. > > Below error is seen > "ucsi_ccg 4-0008: con1: failed to register alternate modes" > > ucsi_run_command() is returning -16. > > I will review the ccg changes and try to debug above issue. There is at least on obvious bug. The number of alternate modes field is wrong. The this: diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index accf54d987ad..506d963ecc6c 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -330,7 +330,7 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient) command |= UCSI_GET_ALTMODE_RECIPIENT(recipient); command |= UCSI_GET_ALTMODE_CONNECTOR_NUMBER(con->num); command |= UCSI_GET_ALTMODE_OFFSET(i); - command |= UCSI_GET_ALTMODE_NUM_ALTMODES(1); /* One at a time */ + command |= UCSI_GET_ALTMODE_NUM_ALTMODES(0); /* One at a time */ len = ucsi_run_command(con->ucsi, command, alt, sizeof(alt)); if (len <= 0) return len; Alternatively you can also just drop two last patches of the series. thanks, -- heikki