Content-Type: multipart/mixed; boundary="===============7210110473579866007==" MIME-Version: 1.0 From: Theodore Y. Ts'o To: kbuild-all@lists.01.org Subject: Re: [PATCH 17/19] jbd2: Rename h_buffer_credits to h_total_credits Date: Mon, 30 Sep 2019 11:05:53 -0400 Message-ID: <20190930150553.GB4001@mit.edu> In-Reply-To: <201909302058.uxNSY0q3%lkp@intel.com> List-Id: --===============7210110473579866007== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Sep 30, 2019 at 08:26:27PM +0800, kbuild test robot wrote: > Hi Jan, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on ext4/dev] > [cannot apply to v5.3 next-20190930] > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://stackoverflow.com/a/374= 06982] > = > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Fix-transa= ction-overflow-due-to-revoke-descriptors/20190930-184615 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: x86_64-randconfig-a004-201939 (attached as .config) > compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 > reproduce: > # save the attached .config to linux build tree > make ARCH=3Dx86_64 = > = > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > = > All errors (new ones prefixed by >>): > = > fs/jbd2/transaction.c: In function 'jbd2_journal_start_reserved': > >> fs/jbd2/transaction.c:596:20: error: 'handle_t {aka struct jbd2_journa= l_handle}' has no member named 'h_buffer_credits' > line_no, handle->h_buffer_credits); > ^ Yep, it looks like this instance of h_buffer_credits was missed in the patch, probably because Jan wasn't building with tracepoints enabled. I noticed this when I tried to do a test build. - Ted --===============7210110473579866007==--