Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AE2ECE587 for ; Tue, 1 Oct 2019 18:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61F63215EA for ; Tue, 1 Oct 2019 18:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYySNO60" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfJAS6b (ORCPT ); Tue, 1 Oct 2019 14:58:31 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51876 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbfJAS6a (ORCPT ); Tue, 1 Oct 2019 14:58:30 -0400 Received: by mail-wm1-f65.google.com with SMTP id 7so4555897wme.1 for ; Tue, 01 Oct 2019 11:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VLS+i0mrs9VIQRBQEqGjdj2aSknb/G3vCgi0P+lgKa0=; b=kYySNO60TOx+mefJh4mGLpW4ebOO2jGgVvIi6Fr6RH6j5Xg8MQXGrLASX93HIbxcvj tlZkBHDgeR3tlAkolbtJ94Te+UOAEpdk7gtmzygRSJ9r4vDw1aVt/WtiXhr1HzEvVmqt aHkKREw3gXR3ZzLQh8iYW8weZ1FUgK0+KvHbCl76oWqyJFWrNdqEiLOJk/qQOw3lYeFB Pmh6vEU2hE3XhUpqHNkI6CTe84wVpfFBy3W9wJHsnmkOVBYRss3ZUcpsLg+5fNs7WdOZ x/S/Z0EAfufRizTWg7Fq+E0HqA1r6XAKpQ1GQOPWEbHV7qvykkMJtYWMZUsvXIYlDwdl 7MdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VLS+i0mrs9VIQRBQEqGjdj2aSknb/G3vCgi0P+lgKa0=; b=DcIoyi4m8OzjAQGB/u1vHAEPW00ZbfyF242piEGa3RLc5MswP5hNm23E5JXGtwDi9J rjss8bVVXcPFRSB87xjcObnknBIqbLLFo7vXsXbYEbWgDmnmkWDp5BNjVn/KBx71tKWZ pAvzejqWOU6y2Bp+B03if/akEoJyBHqA7b1BYwcpVB0KrktBiIFvdQ70cN6hpE2KzLOZ JgvD9v6mGU9Njq/Ip/cy9VWu4PPxhOKklSRuGs0YymJsZk0pB3451dsbZKgcMNxscTuz qMhP9DGDGwo5ajp2K81zdQE11T9yvkFzpuLRvhR4fPDuw2ov3/TKbsVPtPuP1tzWsEQk GFgA== X-Gm-Message-State: APjAAAWi2DQifOQ7KbBNyZiJBQOzuWBbP8IEdxQjmKJiWe581B64BWCJ NuUHuwweEL1x7gFBgduS2KE= X-Google-Smtp-Source: APXvYqye2mPg2ZANJUehryB1e7VBRg9fuKWyzl0iT71qeom5h3J2YLpq7dRuKlX8aiTBKx3cMMaytA== X-Received: by 2002:a1c:7f86:: with SMTP id a128mr5177918wmd.104.1569956308642; Tue, 01 Oct 2019 11:58:28 -0700 (PDT) Received: from localhost.localdomain ([86.124.196.40]) by smtp.gmail.com with ESMTPSA id f143sm8066997wme.40.2019.10.01.11.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 11:58:28 -0700 (PDT) From: Vladimir Oltean To: richardcochran@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net Cc: netdev@vger.kernel.org, Vladimir Oltean Subject: [PATCH v2 net 1/2] net: dsa: sja1105: Initialize the meta_lock Date: Tue, 1 Oct 2019 21:58:18 +0300 Message-Id: <20191001185819.2539-2-olteanv@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191001185819.2539-1-olteanv@gmail.com> References: <20191001185819.2539-1-olteanv@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Otherwise, with CONFIG_DEBUG_SPINLOCK=y, this stack trace gets printed when enabling RX timestamping and receiving a PTP frame: [ 318.537078] INFO: trying to register non-static key. [ 318.542040] the code is fine but needs lockdep annotation. [ 318.547500] turning off the locking correctness validator. [ 318.552972] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.0-13257-g0825b0669811-dirty #1962 [ 318.561283] Hardware name: Freescale LS1021A [ 318.565566] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 318.573289] [] (show_stack) from [] (dump_stack+0xd4/0x100) [ 318.580579] [] (dump_stack) from [] (register_lock_class+0x728/0x734) [ 318.588731] [] (register_lock_class) from [] (__lock_acquire+0x78/0x25cc) [ 318.597227] [] (__lock_acquire) from [] (lock_acquire+0xd8/0x234) [ 318.605033] [] (lock_acquire) from [] (_raw_spin_lock+0x44/0x54) [ 318.612755] [] (_raw_spin_lock) from [] (sja1105_rcv+0x1f8/0x4e8) [ 318.620561] [] (sja1105_rcv) from [] (dsa_switch_rcv+0x80/0x204) [ 318.628283] [] (dsa_switch_rcv) from [] (__netif_receive_skb_one_core+0x50/0x6c) [ 318.637386] [] (__netif_receive_skb_one_core) from [] (netif_receive_skb_internal+0xac/0x264) [ 318.647611] [] (netif_receive_skb_internal) from [] (napi_gro_receive+0x1d8/0x338) [ 318.656887] [] (napi_gro_receive) from [] (gfar_clean_rx_ring+0x328/0x724) [ 318.665472] [] (gfar_clean_rx_ring) from [] (gfar_poll_rx_sq+0x34/0x94) [ 318.673795] [] (gfar_poll_rx_sq) from [] (net_rx_action+0x128/0x4f8) [ 318.681860] [] (net_rx_action) from [] (__do_softirq+0x148/0x5ac) [ 318.689666] [] (__do_softirq) from [] (irq_exit+0x160/0x170) [ 318.697040] [] (irq_exit) from [] (__handle_domain_irq+0x60/0xb4) [ 318.704847] [] (__handle_domain_irq) from [] (gic_handle_irq+0x58/0x9c) [ 318.713172] [] (gic_handle_irq) from [] (__irq_svc+0x70/0x98) [ 318.720622] Exception stack(0xc2001f18 to 0xc2001f60) [ 318.725656] 1f00: 00000001 00000006 [ 318.733805] 1f20: 00000000 c20165c0 ffffe000 c2010cac c2010cf4 00000001 00000000 c2010c88 [ 318.741955] 1f40: c1f7a5a8 00000000 00000000 c2001f68 c03ba140 c030a288 200e0013 ffffffff [ 318.750110] [] (__irq_svc) from [] (arch_cpu_idle+0x24/0x3c) [ 318.757486] [] (arch_cpu_idle) from [] (do_idle+0x1b8/0x2a4) [ 318.764859] [] (do_idle) from [] (cpu_startup_entry+0x18/0x1c) [ 318.772407] [] (cpu_startup_entry) from [] (start_kernel+0x4cc/0x4fc) Fixes: 844d7edc6a34 ("net: dsa: sja1105: Add a global sja1105_tagger_data structure") Signed-off-by: Vladimir Oltean --- drivers/net/dsa/sja1105/sja1105_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index f3d38ff144c4..ea2e7f4f96d0 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -2201,6 +2201,7 @@ static int sja1105_probe(struct spi_device *spi) tagger_data = &priv->tagger_data; skb_queue_head_init(&tagger_data->skb_rxtstamp_queue); INIT_WORK(&tagger_data->rxtstamp_work, sja1105_rxtstamp_work); + spin_lock_init(&tagger_data->meta_lock); /* Connections between dsa_port and sja1105_port */ for (i = 0; i < SJA1105_NUM_PORTS; i++) { -- 2.17.1