Content-Type: multipart/mixed; boundary="===============2187677353924557081==" MIME-Version: 1.0 From: Dmitry Torokhov To: kbuild-all@lists.01.org Subject: Re: [PATCH] lis3lv02d: switch to using input device polling mode Date: Wed, 02 Oct 2019 16:59:43 -0700 Message-ID: <20191002235943.GC20549@dtor-ws> In-Reply-To: <201910030738.k8Pojn6c%lkp@intel.com> List-Id: --===============2187677353924557081== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Oct 03, 2019 at 07:30:23AM +0800, kbuild test robot wrote: > Hi Dmitry, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on char-misc/char-misc-testing] > [cannot apply to v5.4-rc1 next-20191002] This is weird, I just tried applying it to both next-20191002 and Greg's char-misc/char-misc-testing and it applied cleanly and compiled (on x86). > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://stackoverflow.com/a/374= 06982] > = > url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/lis3lv02= d-switch-to-using-input-device-polling-mode/20191003-062746 > config: parisc-allyesconfig (attached as .config) > compiler: hppa-linux-gcc (GCC) 7.4.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=3D7.4.0 make.cross ARCH=3Dparisc = > = > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > = > All errors (new ones prefixed by >>): > = > drivers/misc/lis3lv02d/lis3lv02d.c: In function 'lis3lv02d_joystick_en= able': > drivers/misc/lis3lv02d/lis3lv02d.c:713:8: error: implicit declaration = of function 'input_setup_polling'; did you mean 'input_set_capability'? [-W= error=3Dimplicit-function-declaration] > err =3D input_setup_polling(input_dev, lis3lv02d_joystick_poll); > ^~~~~~~~~~~~~~~~~~~ > input_set_capability > >> drivers/misc/lis3lv02d/lis3lv02d.c:717:2: error: implicit declaration = of function 'input_set_poll_interval'; did you mean '__put_user_internal'? = [-Werror=3Dimplicit-function-declaration] > input_set_poll_interval(input_dev, MDPS_POLL_INTERVAL); > ^~~~~~~~~~~~~~~~~~~~~~~ > __put_user_internal > drivers/misc/lis3lv02d/lis3lv02d.c:718:2: error: implicit declaration = of function 'input_set_min_poll_interval' [-Werror=3Dimplicit-function-decl= aration] > input_set_min_poll_interval(input_dev, MDPS_POLL_MIN); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/misc/lis3lv02d/lis3lv02d.c:719:2: error: implicit declaration = of function 'input_set_max_poll_interval'; did you mean 'input_set_capabili= ty'? [-Werror=3Dimplicit-function-declaration] > input_set_max_poll_interval(input_dev, MDPS_POLL_MAX); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > input_set_capability > cc1: some warnings being treated as errors > = > vim +717 drivers/misc/lis3lv02d/lis3lv02d.c > = > 671 = > 672 int lis3lv02d_joystick_enable(struct lis3lv02d *lis3) > 673 { > 674 struct input_dev *input_dev; > 675 int err; > 676 int max_val, fuzz, flat; > 677 int btns[] =3D {BTN_X, BTN_Y, BTN_Z}; > 678 = > 679 if (lis3->idev) > 680 return -EINVAL; > 681 = > 682 input_dev =3D input_allocate_device(); > 683 if (!input_dev) > 684 return -ENOMEM; > 685 = > 686 input_dev->name =3D "ST LIS3LV02DL Accelerometer"; > 687 input_dev->phys =3D DRIVER_NAME "/input0"; > 688 input_dev->id.bustype =3D BUS_HOST; > 689 input_dev->id.vendor =3D 0; > 690 input_dev->dev.parent =3D &lis3->pdev->dev; > 691 = > 692 input_dev->open =3D lis3lv02d_joystick_open; > 693 input_dev->close =3D lis3lv02d_joystick_close; > 694 = > 695 max_val =3D (lis3->mdps_max_val * lis3->scale) / LIS3_ACCURACY; > 696 if (lis3->whoami =3D=3D WAI_12B) { > 697 fuzz =3D LIS3_DEFAULT_FUZZ_12B; > 698 flat =3D LIS3_DEFAULT_FLAT_12B; > 699 } else { > 700 fuzz =3D LIS3_DEFAULT_FUZZ_8B; > 701 flat =3D LIS3_DEFAULT_FLAT_8B; > 702 } > 703 fuzz =3D (fuzz * lis3->scale) / LIS3_ACCURACY; > 704 flat =3D (flat * lis3->scale) / LIS3_ACCURACY; > 705 = > 706 input_set_abs_params(input_dev, ABS_X, -max_val, max_val, fuzz, f= lat); > 707 input_set_abs_params(input_dev, ABS_Y, -max_val, max_val, fuzz, f= lat); > 708 input_set_abs_params(input_dev, ABS_Z, -max_val, max_val, fuzz, f= lat); > 709 = > 710 input_set_drvdata(input_dev, lis3); > 711 lis3->idev =3D input_dev; > 712 = > > 713 err =3D input_setup_polling(input_dev, lis3lv02d_joystick_poll); > 714 if (err) > 715 goto err_free_input; > 716 = > > 717 input_set_poll_interval(input_dev, MDPS_POLL_INTERVAL); > 718 input_set_min_poll_interval(input_dev, MDPS_POLL_MIN); > 719 input_set_max_poll_interval(input_dev, MDPS_POLL_MAX); > 720 = > 721 lis3->mapped_btns[0] =3D lis3lv02d_get_axis(abs(lis3->ac.x), btns= ); > 722 lis3->mapped_btns[1] =3D lis3lv02d_get_axis(abs(lis3->ac.y), btns= ); > 723 lis3->mapped_btns[2] =3D lis3lv02d_get_axis(abs(lis3->ac.z), btns= ); > 724 = > 725 err =3D input_register_device(lis3->idev); > 726 if (err) > 727 goto err_free_input; > 728 = > 729 return 0; > 730 = > 731 err_free_input: > 732 input_free_device(input_dev); > 733 lis3->idev =3D NULL; > 734 return err; > 735 = > = > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion Thanks. -- = Dmitry --===============2187677353924557081==--