Content-Type: multipart/mixed; boundary="===============6058887340297125174==" MIME-Version: 1.0 From: Paul E. McKenney To: kbuild-all@lists.01.org Subject: Re: [PATCH tip/core/rcu 4/9] rcutorture: Emulate dyntick aspect of userspace nohz_full sojourn Date: Wed, 02 Oct 2019 20:05:53 -0700 Message-ID: <20191003030553.GL2689@paulmck-ThinkPad-P72> In-Reply-To: <201910031038.vZU8YbSP%lkp@intel.com> List-Id: --===============6058887340297125174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Oct 03, 2019 at 10:20:42AM +0800, kbuild test robot wrote: > Hi, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on tip/core/rcu] > = > url: https://github.com/0day-ci/linux/commits/paulmck-kernel-org/rcu-R= emove-unused-function-rcutorture_record_progress/20191003-095557 > config: sh-allmodconfig (attached as .config) > compiler: sh4-linux-gcc (GCC) 7.4.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=3D7.4.0 make.cross ARCH=3Dsh = > = > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot Good catch, I placed this commit in the wrong branch. I pushed the fix out, so it is hopefully better now. Thanx, Paul > All errors (new ones prefixed by >>): > = > kernel/rcu/rcutorture.c: In function 'rcu_torture_fwd_prog_cbfree': > >> kernel/rcu/rcutorture.c:1762:7: error: implicit declaration of functio= n 'tick_nohz_full_enabled'; did you mean 'trace_softirqs_enabled'? [-Werror= =3Dimplicit-function-declaration] > if (tick_nohz_full_enabled()) { > ^~~~~~~~~~~~~~~~~~~~~~ > trace_softirqs_enabled > cc1: some warnings being treated as errors > = > vim +1762 kernel/rcu/rcutorture.c > = > 1737 = > 1738 /* > 1739 * Free all callbacks on the rcu_fwd_cb_head list, either because = the > 1740 * test is over or because we hit an OOM event. > 1741 */ > 1742 static unsigned long rcu_torture_fwd_prog_cbfree(void) > 1743 { > 1744 unsigned long flags; > 1745 unsigned long freed =3D 0; > 1746 struct rcu_fwd_cb *rfcp; > 1747 = > 1748 for (;;) { > 1749 spin_lock_irqsave(&rcu_fwd_lock, flags); > 1750 rfcp =3D rcu_fwd_cb_head; > 1751 if (!rfcp) { > 1752 spin_unlock_irqrestore(&rcu_fwd_lock, flags); > 1753 break; > 1754 } > 1755 rcu_fwd_cb_head =3D rfcp->rfc_next; > 1756 if (!rcu_fwd_cb_head) > 1757 rcu_fwd_cb_tail =3D &rcu_fwd_cb_head; > 1758 spin_unlock_irqrestore(&rcu_fwd_lock, flags); > 1759 kfree(rfcp); > 1760 freed++; > 1761 rcu_torture_fwd_prog_cond_resched(freed); > > 1762 if (tick_nohz_full_enabled()) { > 1763 local_irq_save(flags); > 1764 rcu_momentary_dyntick_idle(); > 1765 local_irq_restore(flags); > 1766 } > 1767 } > 1768 return freed; > 1769 } > 1770 = > = > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion --===============6058887340297125174==--