Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EDEC32792 for ; Thu, 3 Oct 2019 09:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DE7921D81 for ; Thu, 3 Oct 2019 09:49:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="1INu+7+o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729185AbfJCJtp (ORCPT ); Thu, 3 Oct 2019 05:49:45 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40181 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728743AbfJCJtp (ORCPT ); Thu, 3 Oct 2019 05:49:45 -0400 Received: by mail-wm1-f65.google.com with SMTP id b24so1753972wmj.5 for ; Thu, 03 Oct 2019 02:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dy9SIDe28yBQoYzEKmQCMrtZZdcBsTu5Tl50XY7aAFY=; b=1INu+7+o1QvoSls8Zdi2MbRM+7QGC1bffGgfJTrsentDv251GywaVeXcmtNABNCSL/ t81UzOoJqfZDTxtdgJP0ueLT3SbHHVCsBGAfdSHMZ9InLBoY66biw940LBT+g0NyVXoF sw4Qs6xgi1sIEH+8fFp16ScmPCfwnrgAqIVNoBWNW5aaRoL8ytnumwaoNyHKZTFQQOYg 5AD9o4ADPI2euhqfWakboGo4p6GwBJylcflijUxSfwKn7rzCL0TmR2UUQuQLZM6tfHMU amNccQ4zedpCruto4Nv8GouQliFaff7on+LJvN6Ernt1OdLMuQNW5oWmZmcrxhyOeQnJ sQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dy9SIDe28yBQoYzEKmQCMrtZZdcBsTu5Tl50XY7aAFY=; b=Ff6YCkSu3tJKpKGgZe9FyJTtFa1na7JVGqAmNRsI1bgOkS1mGFOpU3uWX0tGBB0D19 W+nrJy4kgRRBUOrbDB5ldV+0Wf60M1EpXoUD3mYjStsUJYJzD1tNxd4+btR6YIZqKIgs PTEUmLm6PhurdiW/d07Wy1s7tBlGdZJoZemfVnL1Ir9J84ny4H+V3uByz6/zS0U0K258 sJawLrJylPK3QklVe/Plpp0vSDePlWSUeo4eUV4QS/g8H3jbpfIOeEdRE94wb34tCvdH FPrVhDM8wbfFjdub0N5/qY66qPrTsL6OFACFEoV53Th77p+1jNX0nKj2zEqAH1gQIXRm PtNg== X-Gm-Message-State: APjAAAXBqRvdLUKeuGY/LvPtPGhRRQ4NFjlWTcGFazVP01g5VQIWI47v oZ97pH2vlpq2YYDwOGshmJt1caR9BD4= X-Google-Smtp-Source: APXvYqxMW62qHNsPUb0yUkvFmiWk974STaKJ3W3uvx+Zp4HgRqs9dpoFgfPYwJgQaMrL0R3tsFqkSw== X-Received: by 2002:a7b:c156:: with SMTP id z22mr6591844wmi.142.1570096181630; Thu, 03 Oct 2019 02:49:41 -0700 (PDT) Received: from localhost ([85.163.43.78]) by smtp.gmail.com with ESMTPSA id a2sm2198522wrp.11.2019.10.03.02.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 02:49:40 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, dsahern@gmail.com, jakub.kicinski@netronome.com, tariqt@mellanox.com, saeedm@mellanox.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, shuah@kernel.org, mlxsw@mellanox.com Subject: [patch net-next v3 00/15] devlink: allow devlink instances to change network namespace Date: Thu, 3 Oct 2019 11:49:25 +0200 Message-Id: <20191003094940.9797-1-jiri@resnulli.us> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Devlink from the beginning counts with network namespaces, but the instances has been fixed to init_net. Implement change of network namespace as part of "devlink reload" procedure like this: $ ip netns add testns1 $ devlink/devlink dev reload netdevsim/netdevsim10 netns testns1 This command reloads device "netdevsim10" into network namespace "testns1". Note that "devlink reload" reinstantiates driver objects, effectively it reloads the driver instance, including possible hw reset etc. Newly created netdevices respect the network namespace of the parent devlink instance and according to that, they are created in target network namespace. Driver is able to refuse to be reloaded into different namespace. That is the case of mlx4 right now. FIB entries and rules are replayed during FIB notifier registration which is triggered during reload (driver instance init). FIB notifier is also registered to the target network namespace, that allows user to use netdevsim devlink resources to setup per-namespace limits of FIB entries and FIB rules. In fact, with multiple netdevsim instances in each network namespace, user might setup different limits. This maintains and extends current netdevsim resources behaviour. Patch 1 prepares netdevsim code for the follow-up changes in the patchset. It does not change the behaviour, only moves pet-init_netns accounting to netdevsim instance, which is also in init_netns. Patches 2-5 prepare the FIB notifier making it per-netns and to behave correctly upon error conditions. Patch 6 just exports a devlink_net helper so it can be used in drivers. Patches 7-9 do preparations in mlxsw driver. Patches 10-13 do preparations in netdevsim driver, namely patch 12 implements proper devlink reload where the driver instance objects are actually re-created as they should be. Patch 14 actually implements the possibility to reload into a different network namespace. Patch 15 adds needed selftests for devlink reload into namespace for netdevsim driver. Jiri Pirko (15): netdevsim: change fib accounting and limitations to be per-device net: fib_notifier: make FIB notifier per-netns net: fib_notifier: propagate possible error during fib notifier registration mlxsw: spectrum_router: Don't rely on missing extack to symbolize dump net: fib_notifier: propagate extack down to the notifier block callback net: devlink: export devlink net getter mlxsw: spectrum: Take devlink net instead of init_net mlxsw: Register port netdevices into net of core mlxsw: Propagate extack down to register_fib_notifier() netdevsim: add all ports in nsim_dev_create() and del them in destroy() netdevsim: implement proper devlink reload netdevsim: register port netdevices into net of device netdevsim: take devlink net instead of init_net net: devlink: allow to change namespaces during reload selftests: netdevsim: add tests for devlink reload with resources drivers/net/ethernet/mellanox/mlx4/main.c | 6 +- .../net/ethernet/mellanox/mlx5/core/lag_mp.c | 9 +- drivers/net/ethernet/mellanox/mlxsw/core.c | 14 +- drivers/net/ethernet/mellanox/mlxsw/core.h | 12 +- drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 4 +- drivers/net/ethernet/mellanox/mlxsw/pci.c | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 22 +- .../net/ethernet/mellanox/mlxsw/spectrum.h | 9 +- .../ethernet/mellanox/mlxsw/spectrum_nve.c | 2 +- .../ethernet/mellanox/mlxsw/spectrum_router.c | 59 ++- .../mellanox/mlxsw/spectrum_switchdev.c | 2 +- .../net/ethernet/mellanox/mlxsw/switchib.c | 3 +- .../net/ethernet/mellanox/mlxsw/switchx2.c | 4 +- drivers/net/ethernet/rocker/rocker_main.c | 9 +- drivers/net/netdevsim/dev.c | 339 +++++++++--------- drivers/net/netdevsim/fib.c | 175 +++++---- drivers/net/netdevsim/netdev.c | 10 +- drivers/net/netdevsim/netdevsim.h | 15 +- include/linux/mroute_base.h | 28 +- include/net/devlink.h | 3 +- include/net/fib_notifier.h | 13 +- include/net/fib_rules.h | 3 +- include/net/ip6_fib.h | 11 +- include/net/ip_fib.h | 11 +- include/uapi/linux/devlink.h | 4 + net/core/devlink.c | 157 +++++++- net/core/fib_notifier.c | 95 +++-- net/core/fib_rules.c | 23 +- net/ipv4/fib_notifier.c | 13 +- net/ipv4/fib_rules.c | 5 +- net/ipv4/fib_trie.c | 44 ++- net/ipv4/ipmr.c | 13 +- net/ipv4/ipmr_base.c | 30 +- net/ipv6/fib6_notifier.c | 11 +- net/ipv6/fib6_rules.c | 5 +- net/ipv6/ip6_fib.c | 50 ++- net/ipv6/ip6mr.c | 13 +- .../drivers/net/netdevsim/devlink.sh | 120 ++++++- 39 files changed, 864 insertions(+), 486 deletions(-) -- 2.21.0