From: Greg Kroah-Hartman Subject: Re: [RFC][PATCH 2/3] usb: roles: Add usb role switch notifier. Date: Thu, 3 Oct 2019 13:26:18 +0200 Message-ID: <20191003112618.GA2420393@kroah.com> References: <20191002231617.3670-1-john.stultz@linaro.org> <20191002231617.3670-3-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191002231617.3670-3-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: John Stultz Cc: lkml , Yu Chen , Rob Herring , Mark Rutland , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Felipe Balbi , Hans de Goede , Andy Shevchenko , Jun Li , Valentin Schneider , linux-usb@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Oct 02, 2019 at 11:16:16PM +0000, John Stultz wrote: > From: Yu Chen > > This patch adds notifier for drivers want to be informed of the usb role > switch. Ick, I hate notifiers, they always come back to cause problems. What's just wrong with a "real" call to who ever needs to know this? And who does need to know this anyway? Like Hans said, if we don't have a user for it, we should not add it. thanks, greg k-h