Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iGAA9-00016a-6A for mharc-qemu-trivial@gnu.org; Thu, 03 Oct 2019 19:05:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45806) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGA9v-0000yN-Sb for qemu-trivial@nongnu.org; Thu, 03 Oct 2019 19:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGA9t-00067p-8Y for qemu-trivial@nongnu.org; Thu, 03 Oct 2019 19:05:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26606) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGA94-0005oE-I9; Thu, 03 Oct 2019 19:04:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 625AF10C0928; Thu, 3 Oct 2019 23:04:24 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91D381001B20; Thu, 3 Oct 2019 23:04:07 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: David Gibson , Artyom Tarasenko , Aleksandar Rikalo , Marcel Apfelbaum , Alistair Francis , Joel Stanley , qemu-ppc@nongnu.org, Paolo Bonzini , Igor Mammedov , Mark Cave-Ayland , Aleksandar Markovic , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , qemu-trivial@nongnu.org, "Edgar E. Iglesias" , Thomas Huth , "Michael S. Tsirkin" , Andrew Jeffery , Helge Deller , Peter Maydell , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Richard Henderson , Laurent Vivier , Eduardo Habkost , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 00/14] hw: Split RTC devices from hw/timer/ to hw/rtc/ Date: Fri, 4 Oct 2019 01:03:50 +0200 Message-Id: <20191003230404.19384-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Thu, 03 Oct 2019 23:04:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Oct 2019 23:05:25 -0000 Since v1: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03334.= html - addressed review comments (described in patches 3 and 4) - added R-b/A-b tags Whole series now reviewed. v1 blurb: When working on timers, I found it confuse to have RTC devices mixed in the hw/timer/ directory. We can see the models use slighly different APIs: $ git grep '#include' hw/timer/|cut -d: -f3-|sort|uniq -c|egrep -v '^ = 1 '|sort -rn 33 #include "qemu/osdep.h" 29 #include "hw/irq.h" 28 #include "qemu/module.h" 23 #include "migration/vmstate.h" 21 #include "hw/sysbus.h" 20 #include "qemu/timer.h" 20 #include "qemu/main-loop.h" 17 #include "qemu/log.h" 14 #include "hw/qdev-properties.h" 14 #include "hw/ptimer.h" 9 #include "trace.h" 7 #include "qapi/error.h" 5 #include "hw/hw.h" 3 #include "sysemu/runstate.h" 3 #include "qemu/error-report.h" 3 #include "hw/timer/i8254.h" 2 #include "qemu/bitops.h" 2 #include "hw/timer/i8254_internal.h" 2 #include "hw/registerfields.h" 2 #include "hw/core/cpu.h" 2 #include "hw/arm/omap.h" 2 #include "hw/arm/exynos4210.h" $ git grep '#include' hw/rtc/|cut -d: -f3-|sort|uniq -c|egrep -v '^ = 1 '|sort -rn 11 #include "qemu/osdep.h" 10 #include "qemu/module.h" 9 #include "qemu-common.h" 8 #include "qemu/timer.h" 8 #include "migration/vmstate.h" 6 #include "qemu/bcd.h" 6 #include "hw/irq.h" 5 #include "sysemu/sysemu.h" 5 #include "qemu/log.h" 5 #include "hw/sysbus.h" 4 #include "trace.h" 4 #include "hw/qdev-properties.h" 3 #include "qemu/cutils.h" 3 #include "hw/i2c/i2c.h" 2 #include "sysemu/runstate.h" 2 #include "m48t59-internal.h" 2 #include "hw/rtc/m48t59.h" 2 #include "exec/address-spaces.h" Split the RTC-related files in the new hw/rtc/ directory. Philippe Mathieu-Daud=C3=A9 (14): hw/timer: Compile devices not target-dependent as common object hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include hw/rtc/aspeed_rtc: Remove unused includes MAINTAINERS | 20 +++---- Makefile.objs | 1 + hw/Kconfig | 1 + hw/Makefile.objs | 1 + hw/alpha/dp264.c | 2 +- hw/arm/musca.c | 2 +- hw/hppa/machine.c | 2 +- hw/i386/acpi-build.c | 2 +- hw/i386/pc.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c | 2 +- hw/mips/mips_malta.c | 2 +- hw/mips/mips_r4k.c | 2 +- hw/ppc/pnv.c | 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/ppc/prep.c | 4 +- hw/rtc/Kconfig | 23 ++++++++ hw/rtc/Makefile.objs | 13 +++++ hw/{timer =3D> rtc}/aspeed_rtc.c | 2 +- hw/{timer =3D> rtc}/ds1338.c | 0 hw/{timer =3D> rtc}/exynos4210_rtc.c | 0 hw/{timer =3D> rtc}/m41t80.c | 0 hw/{timer =3D> rtc}/m48t59-internal.h | 0 hw/{timer =3D> rtc}/m48t59-isa.c | 4 +- hw/{timer =3D> rtc}/m48t59.c | 2 +- hw/{timer =3D> rtc}/mc146818rtc.c | 3 +- hw/{timer =3D> rtc}/pl031.c | 2 +- hw/{timer =3D> rtc}/sun4v-rtc.c | 2 +- hw/rtc/trace-events | 19 +++++++ hw/{timer =3D> rtc}/twl92230.c | 0 hw/{timer =3D> rtc}/xlnx-zynqmp-rtc.c | 3 +- hw/sparc/sun4m.c | 2 +- hw/sparc64/niagara.c | 2 +- hw/sparc64/sun4u.c | 2 +- hw/timer/Kconfig | 24 --------- hw/timer/Makefile.objs | 35 ++++-------- hw/timer/hpet.c | 3 +- hw/timer/trace-events | 18 ------- include/hw/arm/aspeed_soc.h | 2 +- include/hw/arm/xlnx-zynqmp.h | 2 +- include/hw/{timer =3D> rtc}/aspeed_rtc.h | 9 ++-- include/hw/rtc/m48t59.h | 57 ++++++++++++++++++++ include/hw/{timer =3D> rtc}/mc146818rtc.h | 13 +++-- include/hw/{timer =3D> rtc}/mc146818rtc_regs.h | 5 +- include/hw/{timer =3D> rtc}/pl031.h | 5 +- include/hw/rtc/sun4v-rtc.h | 19 +++++++ include/hw/{timer =3D> rtc}/xlnx-zynqmp-rtc.h | 6 +-- include/hw/timer/m48t59.h | 32 ----------- include/hw/timer/sun4v-rtc.h | 1 - tests/rtc-test.c | 2 +- 51 files changed, 208 insertions(+), 155 deletions(-) create mode 100644 hw/rtc/Kconfig create mode 100644 hw/rtc/Makefile.objs rename hw/{timer =3D> rtc}/aspeed_rtc.c (99%) rename hw/{timer =3D> rtc}/ds1338.c (100%) rename hw/{timer =3D> rtc}/exynos4210_rtc.c (100%) rename hw/{timer =3D> rtc}/m41t80.c (100%) rename hw/{timer =3D> rtc}/m48t59-internal.h (100%) rename hw/{timer =3D> rtc}/m48t59-isa.c (98%) rename hw/{timer =3D> rtc}/m48t59.c (99%) rename hw/{timer =3D> rtc}/mc146818rtc.c (99%) rename hw/{timer =3D> rtc}/pl031.c (99%) rename hw/{timer =3D> rtc}/sun4v-rtc.c (98%) create mode 100644 hw/rtc/trace-events rename hw/{timer =3D> rtc}/twl92230.c (100%) rename hw/{timer =3D> rtc}/xlnx-zynqmp-rtc.c (99%) rename include/hw/{timer =3D> rtc}/aspeed_rtc.h (80%) create mode 100644 include/hw/rtc/m48t59.h rename include/hw/{timer =3D> rtc}/mc146818rtc.h (63%) rename include/hw/{timer =3D> rtc}/mc146818rtc_regs.h (96%) rename include/hw/{timer =3D> rtc}/pl031.h (93%) create mode 100644 include/hw/rtc/sun4v-rtc.h rename include/hw/{timer =3D> rtc}/xlnx-zynqmp-rtc.h (95%) delete mode 100644 include/hw/timer/m48t59.h delete mode 100644 include/hw/timer/sun4v-rtc.h --=20 2.20.1