Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976F8C4360C for ; Fri, 4 Oct 2019 15:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70EF920830 for ; Fri, 4 Oct 2019 15:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389869AbfJDPns (ORCPT ); Fri, 4 Oct 2019 11:43:48 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42542 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389131AbfJDPnr (ORCPT ); Fri, 4 Oct 2019 11:43:47 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1iGPj9-0001MW-HZ; Sat, 05 Oct 2019 01:42:44 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Oct 2019 01:42:42 +1000 Date: Sat, 5 Oct 2019 01:42:42 +1000 From: Herbert Xu To: "Alexander E. Patrakov" Cc: linux-crypto@vger.kernel.org, smueller@chronox.de, patrakov@gmail.com Subject: Re: [PATCH] jitterentropy: fix comments Message-ID: <20191004154242.GA7330@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918072849.6749-1-patrakov@gmail.com> X-Newsgroups: apana.lists.os.linux.cryptoapi User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Alexander E. Patrakov wrote: > One should not say "ec can be NULL" and then dereference it. > One cannot talk about the return value if the function returns void. > > Signed-off-by: Alexander E. Patrakov > --- > crypto/jitterentropy.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt