Content-Type: multipart/mixed; boundary="===============4543403453588264069==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 1/3] net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available Date: Mon, 07 Oct 2019 05:50:44 +0800 Message-ID: <201910070529.LpPdh7OD%lkp@intel.com> In-Reply-To: <3504067666a0cee6ecf636cf30081b09a6b79710.1570360411.git.Jose.Abreu@synopsys.com> List-Id: --===============4543403453588264069== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jose, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Impr= ovements-for-next/20191007-013324 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-42-g38eda53-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: spars= e: incorrect type in argument 1 (different address spaces) @@ expected v= oid [noderef] *ioaddr @@ got void [noderef] *ioaddr @@ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: ex= pected void [noderef] *ioaddr drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: go= t struct mac_device_info *hw >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: spars= e: incorrect type in assignment (different base types) @@ expected unsig= ned short [assigned] [usertype] vid @@ got short [assigned] [usertype] = vid @@ >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: ex= pected unsigned short [assigned] [usertype] vid >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: go= t restricted __le16 [usertype] vim +4224 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 4206 = 4207 static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_doub= le) 4208 { 4209 u32 crc, hash =3D 0; 4210 int count =3D 0; 4211 u16 vid =3D 0; 4212 = 4213 for_each_set_bit(vid, priv->active_vlans, VLAN_N_VID) { 4214 __le16 vid_le =3D cpu_to_le16(vid); 4215 crc =3D bitrev32(~stmmac_vid_crc32_le(vid_le)) >> 28; 4216 hash |=3D (1 << crc); 4217 count++; 4218 } 4219 = 4220 if (!priv->dma_cap.vlhash) { 4221 if (count > 2) /* VID =3D 0 always passes filter */ 4222 return -EOPNOTSUPP; 4223 = > 4224 vid =3D cpu_to_le16(vid); 4225 hash =3D 0; 4226 } 4227 = 4228 return stmmac_update_vlan_hash(priv, priv->hw, hash, vid, is_double= ); 4229 } 4230 = --- 0-DAY kernel test infrastructure Open Source Technology Cent= er https://lists.01.org/pipermail/kbuild-all Intel Corporati= on --===============4543403453588264069==--