From: Laurent Pinchart Subject: Re: [PATCH] drm: panels: fix spi aliases of former omap panels Date: Mon, 7 Oct 2019 20:16:35 +0300 Message-ID: <20191007171635.GC11781@pendragon.ideasonboard.com> References: <20191007164130.31534-1-andreas@kemnade.info> <20191007170446.yotb24s6jhe6nx3r@earth.universe> <20191007191428.016ddcd4@aktux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20191007191428.016ddcd4@aktux> Sender: linux-kernel-owner@vger.kernel.org To: Andreas Kemnade Cc: Sebastian Reichel , thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, omi Valkeinen , Discussions about the Letux Kernel , Tony Lindgren , Jyri Sarha , Linux-OMAP , linux-arm-kernel List-Id: dri-devel@lists.freedesktop.org Hi Andreas, On Mon, Oct 07, 2019 at 07:14:28PM +0200, Andreas Kemnade wrote: > On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel wrote: > > On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote: > > > When the panels were moved from omap/displays/ to panel/ > > > omapdss prefix was stripped, which cause spi modalias > > > to not contain the vendor-prefix anymore. > > > > > > so we had e.g. in former times: > > > compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1 > > > now: > > > compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1 > > > > > > This is consistent with other drivers. Tested the td028ttec.c > > > only, but the pattern looks the same for the other ones. > > > > > > Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers") > > > Signed-off-by: Andreas Kemnade > > > --- > > > > Patch looks good to me, but you have one false positive. > > > > > [...] > > > > > > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c > > > index 46cd9a2501298..838d39a263f53 100644 > > > --- a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c > > > +++ b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c > > > @@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev) > > > } > > > > > > static const struct of_device_id ls037v7dw01_of_match[] = { > > > - { .compatible = "sharp,ls037v7dw01", }, > > > + { .compatible = "ls037v7dw01", }, > > > { /* sentinel */ }, > > > }; > > > > The DT compatible should have a vendor prefix. > > oops, sorry, but I it seems that Laurent already has submitted a fix. Seems we've been racing each other :-S Feel free to submit a v2 of this patch if you think it's better than my series. As long as the problem gets fixed, I'll be happy :-) -- Regards, Laurent Pinchart