Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iHd9D-0002i5-QQ for mharc-qemu-riscv@gnu.org; Mon, 07 Oct 2019 20:14:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37210) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHd9A-0002dy-DS for qemu-riscv@nongnu.org; Mon, 07 Oct 2019 20:14:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHd99-0005P3-CW for qemu-riscv@nongnu.org; Mon, 07 Oct 2019 20:14:36 -0400 Received: from rs224.mailgun.us ([209.61.151.224]:15755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHd97-0005K8-OB for qemu-riscv@nongnu.org; Mon, 07 Oct 2019 20:14:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=fintelia.io; q=dns/txt; s=pic; t=1570493675; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From: Sender; bh=0AYrTLQGGVMjJAwteX2M1fMUA+ZMU7mBXK8haObkZGg=; b=snj6iTl+B4dKvvSbP/UA85EPWkyWf7Kbf+YzsMFm2I0rfimED2haKrDtU8LA/IXy0M/pMW1G 0dNMSl75/LVaFIKZLuwbKo8MKB9zSPRFgVV50OhshlJcygCQWfeVN7y6djjjeaYxhk8miJH6 7jRj8qrTxT+ulLbHh+u0DPjAuC2c3JrBahuWU8BzbrG0qgYmsBm6EhxpFQXw49FlZLtdwe7X VMnPRWLr/V/tHARRua+xSEFbv+pNH0bCiQcMAUMmRO7PxD+DPJ9l2cZgbLpkFuL7pGI4Rtlm WLdeDUHKnMSL3LbQ7gNlz/GjticPJq0qBWmlnUtZRfVHH9g2klHIzQ== X-Mailgun-Sending-Ip: 209.61.151.224 X-Mailgun-Sid: WyJkNjk0ZSIsICJxZW11LXJpc2N2QG5vbmdudS5vcmciLCAiOWI0ZTc2Il0= Sender: jonathan@fintelia.io Received: from jonathan-ThinkPad-X1-Carbon.pdos.lcs.mit.edu (26-5-211.dynamic.csail.mit.edu [18.26.5.211]) by mxa.mailgun.org with ESMTP id 5d9bd4e5.7f51c380ba28-smtp-out-n01; Tue, 08 Oct 2019 00:14:29 -0000 (UTC) From: Jonathan Behrens To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Jonathan Behrens , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann Subject: [PATCH v3 3/3] target/riscv: Make the priv register writable by GDB Date: Mon, 7 Oct 2019 20:13:18 -0400 Message-Id: <20191008001318.219367-4-jonathan@fintelia.io> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191008001318.219367-1-jonathan@fintelia.io> References: <20191008001318.219367-1-jonathan@fintelia.io> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.61.151.224 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2019 00:14:38 -0000 Currently only PRV_U, PRV_S and PRV_M are supported, so this patch ensures that the privilege mode is set to one of them. Once support for the H-extension is added, this code will also need to properly update the virtualization status when switching between VU/VS-modes and M-mode. Signed-off-by: Jonathan Behrens --- target/riscv/gdbstub.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index 33cf7c4c7d..bc84b599c2 100644 --- a/target/riscv/gdbstub.c +++ b/target/riscv/gdbstub.c @@ -387,6 +387,15 @@ static int riscv_gdb_get_virtual(CPURISCVState *cs, uint8_t *mem_buf, int n) static int riscv_gdb_set_virtual(CPURISCVState *cs, uint8_t *mem_buf, int n) { + if (n == 0) { +#ifndef CONFIG_USER_ONLY + cs->priv = ldtul_p(mem_buf) & 0x3; + if (cs->priv == PRV_H) { + cs->priv = PRV_S; + } +#endif + return sizeof(target_ulong); + } return 0; } -- 2.23.0