Content-Type: multipart/mixed; boundary="===============2180837293708706884==" MIME-Version: 1.0 From: Peter Zijlstra To: kbuild-all@lists.01.org Subject: Re: [trace:ftrace/text-poke 1/6] arch/x86/kernel/alternative.c:1098 text_poke_bp_batch() warn: impossible condition '(tp[i]->text[0] == 204) => ((-128)-127 == 204)' Date: Wed, 09 Oct 2019 13:40:01 +0200 Message-ID: <20191009114001.GD2359@hirez.programming.kicks-ass.net> In-Reply-To: <20191009095531.GB2359@hirez.programming.kicks-ass.net> List-Id: --===============2180837293708706884== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Oct 09, 2019 at 11:55:31AM +0200, Peter Zijlstra wrote: > On Wed, Oct 09, 2019 at 11:35:42AM +0200, Peter Zijlstra wrote: > > On Wed, Oct 09, 2019 at 12:09:56PM +0300, Dan Carpenter wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux= -trace.git ftrace/text-poke > > > head: 5225ef2a7a2d3da9e00d3f3439c768ac535f7595 > > > commit: fedc230ef3ea89ea0b308b667e72c3ed2c02dc72 [1/6] x86/alternativ= es: Teach text_poke_bp() to emulate instructions > > > = > > > If you fix the issue, kindly add following tag > > > Reported-by: kbuild test robot > > > Reported-by: Dan Carpenter > > > = > > > smatch warnings: > > > arch/x86/kernel/alternative.c:1098 text_poke_bp_batch() warn: impossi= ble condition '(tp[i]->text[0] =3D=3D 204) =3D> ((-128)-127 =3D=3D 204)' > > > = > > = > > > fedc230ef3ea89 Peter Zijlstra 2019-10-07 1097 for (do_= sync =3D 0, i =3D 0; i < nr_entries; i++) { > > > fedc230ef3ea89 Peter Zijlstra 2019-10-07 @1098 if (tp[= i].text[0] =3D=3D INT3_INSN_OPCODE) > > > = ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > Impossible condition. .text[] is signed char and INT3_INSN_OPCODE is > > > 0xCC. > > = > > Blergh.. Steve, please fold into: > > = > > Subject: x86/alternatives,jump_label: Provide better text_poke() batc= hing interface > = > Argh, that's too late of course, needs to go in the first patch and then > rebased fwd :/ Something like I did here: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/ftrace --===============2180837293708706884==--