Date: Wed, 9 Oct 2019 19:57:21 +0200 (CEST) Message-Id: <201910091757.x99HvLPi052361@...2054...> From: Gert Doering In-Reply-To: <20191009143422.9419-2-a@...2181...> References: <20191009143422.9419-2-a@...2181...> Subject: [Openvpn-devel] [PATCH applied] Re: maddr: create helper function to populate maddr object from eth_addr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering This is one of the easy ones, and very "obviously correct". Client side tested on Linux and FreeBSD with t_client / TAP tests (which do not really excercise this code, unfortunately, but my test server is still down). While I do prefer memcpy()'s using "sizeof(dest)" to "OPENVPN_ETH_ALEN", mroute.eth_addr is "uint8_t[OPENVPN_ETH_ALEN]" so this is safe enough. Your patch has been applied to the master branch. commit 5e27e47d631f61ee3f9234dd076389232495e714 Author: Antonio Quartulli Date: Wed Oct 9 16:34:14 2019 +0200 maddr: create helper function to populate maddr object from eth_addr Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20191009143422.9419-2-a@...2181...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18921.html Signed-off-by: Gert Doering -- kind regards, Gert Doering