Received: by 2002:adf:e804:0:0:0:0:0 with SMTP id o4csp2378573wrm; Thu, 10 Oct 2019 06:29:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqzw/7nSLH5Z/aPNMhOw5UMUt9lnN1VUDr88ilWqSxc+A6vkRaLqcp+IYyi23tA8bntCQnYD X-Received: by 2002:a05:6402:21eb:: with SMTP id ce11mr8001484edb.182.1570714190228; Thu, 10 Oct 2019 06:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570714190; cv=none; d=google.com; s=arc-20160816; b=Jh0QlxbK6zCmUPciE9Hx++Kl1xTHwBTYtSSH905K6mJZLqgHG+4sdrPrVSvbqrJ5S2 EMcDFeZgH/wSjHkbb2CT5I9crlmjeyflSuzNQ7jd8iJx9aG9b1ks/tjTX3zEYkLBAPZh GJZQGVAswQomIXX1wFwemAaSlIeGLh9FRQfK5uqIDwvGr6XUXnl4KckwBPlVOxZAiajI mrolIwQ/1KLZGLNBa54ljssQzWZQOR8+zlnEIVlEybK9/p6qpaycEykpLQ6lZAHQzHbj iaY55L0nk7eeLr0moxPA59o0Kx4YgBbzTRptL7UuHbNlbOjKLmDSxxy2dkHdqBKZcp0c H4tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=2ts7F2QF8kPMzpQEfnd1+3ebkf2x+anuumMELNS3ZZ8=; b=mcmwnZ025115KC4Xp3CoO7tv1PIxh/oCpp/w3XUpVFGs+isKIspdYgVI7g8C3Mp8+Z 6bgYPtSq+HcoNgMVh2dlb+pRJ/CqPiRW7mwgpkBmPCFOLtEs5C+UR5/Y+eGD0FAUqAeP bv88ix1hs1wUZIVGU6i7YANllstduKyZ5nZEbzzTB7cippNyZEX3hqacFtK+f0sA/VvK mZE+06gOr0n+h9kGOZWl6eTSBOgvPHNG4YL5VzNw/Y5p1jmqo5zozmTRIEkHtuGe7UiB sTQp/M5RFQ+atAZk3wgsrBkT3gkdr63P9Bd2ToDN6+WWUWbT9IP1DZResFa3//rw+jJY zRrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f15si3234760edm.414.2019.10.10.06.29.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Oct 2019 06:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:39536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIYVo-0000Ei-FF for alex.bennee@linaro.org; Thu, 10 Oct 2019 09:29:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIYJT-00018t-Sg for qemu-arm@nongnu.org; Thu, 10 Oct 2019 09:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIYJS-0002NO-Ns for qemu-arm@nongnu.org; Thu, 10 Oct 2019 09:17:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52190) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIYJS-0002ND-ID; Thu, 10 Oct 2019 09:17:02 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E4238D5D84; Thu, 10 Oct 2019 13:17:01 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87F6B600C4; Thu, 10 Oct 2019 13:16:43 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Eduardo Habkost , qemu-devel@nongnu.org Subject: [PATCH v3 5/8] hw/ide/via82c: Convert reset handler to DeviceReset Date: Thu, 10 Oct 2019 15:15:24 +0200 Message-Id: <20191010131527.32513-6-philmd@redhat.com> In-Reply-To: <20191010131527.32513-1-philmd@redhat.com> References: <20191010131527.32513-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Thu, 10 Oct 2019 13:17:01 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Markovic , qemu-block@nongnu.org, "Michael S. Tsirkin" , Aleksandar Rikalo , Andrzej Zaborowski , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , BALATON Zoltan , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , Igor Mammedov , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , John Snow Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: NFH8BlS4a6l1 The VIA82C686B IDE controller is a PCI device, it will be reset when the PCI bus it stands on is reset. Convert its reset handler into a proper Device reset method. Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ide/via.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 7087dc676e..053622bd82 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -29,7 +29,6 @@ #include "migration/vmstate.h" #include "qemu/module.h" #include "sysemu/dma.h" -#include "sysemu/reset.h" =20 #include "hw/ide/pci.h" #include "trace.h" @@ -120,10 +119,10 @@ static void via_ide_set_irq(void *opaque, int n, in= t level) } } =20 -static void via_ide_reset(void *opaque) +static void via_ide_reset(DeviceState *dev) { - PCIIDEState *d =3D opaque; - PCIDevice *pd =3D PCI_DEVICE(d); + PCIIDEState *d =3D PCI_IDE(dev); + PCIDevice *pd =3D PCI_DEVICE(dev); uint8_t *pci_conf =3D pd->config; int i; =20 @@ -172,8 +171,6 @@ static void via_ide_realize(PCIDevice *dev, Error **e= rrp) pci_set_long(pci_conf + PCI_CAPABILITY_LIST, 0x000000c0); dev->wmask[PCI_INTERRUPT_LINE] =3D 0xf; =20 - qemu_register_reset(via_ide_reset, d); - memory_region_init_io(&d->data_bar[0], OBJECT(d), &pci_ide_data_le_o= ps, &d->bus[0], "via-ide0-data", 8); pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &d->data_bar[0])= ; @@ -229,6 +226,7 @@ static void via_ide_class_init(ObjectClass *klass, vo= id *data) DeviceClass *dc =3D DEVICE_CLASS(klass); PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); =20 + dc->reset =3D via_ide_reset; k->realize =3D via_ide_realize; k->exit =3D via_ide_exitfn; k->vendor_id =3D PCI_VENDOR_ID_VIA; --=20 2.21.0