Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iIrLW-0002I8-4L for mharc-qemu-trivial@gnu.org; Fri, 11 Oct 2019 05:36:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54088) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIrLU-0002FO-2p for qemu-trivial@nongnu.org; Fri, 11 Oct 2019 05:36:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIrLT-0001NV-4d for qemu-trivial@nongnu.org; Fri, 11 Oct 2019 05:36:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48876) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIrLO-0001GY-8O; Fri, 11 Oct 2019 05:36:18 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF678C049E17; Fri, 11 Oct 2019 09:36:14 +0000 (UTC) Received: from localhost.localdomain (unknown [10.36.118.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DCDA3CC8; Fri, 11 Oct 2019 09:36:12 +0000 (UTC) Date: Fri, 11 Oct 2019 11:36:10 +0200 From: Kevin Wolf To: Cleber Rosa Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Eric Blake Subject: Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files Message-ID: <20191011093610.GD5158@localhost.localdomain> References: <20191009194740.8079-1-crosa@redhat.com> <20191009194740.8079-2-crosa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009194740.8079-2-crosa@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 11 Oct 2019 09:36:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Oct 2019 09:36:25 -0000 Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben: > Due to not being able to find a reason to have shebangs on files that > are not executable. > > While at it, add a mode hint to emacs, which would be clueless or > plain wrong about these containing shell code. vim still doesn't like the change. Of course, we could also add another line for vim and for every other editor in use, but actually, I think I'd prefer just dropping this patch. It even makes each file a few bytes larger instead of saving something. Shebang lines are a shorter and more portable format indicator than the alternatives. So I think in the end we have found a good reason to keep them. :-) Kevin