From: Kees Cook Date: Fri, 11 Oct 2019 22:07:58 +0000 Subject: Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Message-Id: <201910111506.45AE850D5@keescook> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Miguel Ojeda Cc: Linus Torvalds , Joe Perches , linux-sctp@vger.kernel.org, Borislav Petkov , "H . Peter Anvin" , Thomas Gleixner , Pavel Machek , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , the arch/x86 maintainers , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Andrew Morton , David Miller , clang-built-linux , Jonathan Corbet , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "open list:DOCUMENTATION" , Netdev On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > Hi Linus, > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > wrote: > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > > like '/* fallthrough */'. > > > > I applied patches 1-3 to my tree just to make it easier for people to > > start doing this. Maybe some people want to do the conversion on their > > own subsystem rather than with a global script, but even if not, this > > looks better as a "prepare for the future" series and I feel that if > > we're doing the "fallthrough" thing eventually, the sooner we do the > > prepwork the better. > > > > I'm a tiny bit worried that the actual conversion is just going to > > cause lots of pain for the stable people, but I'll not worry about it > > _too_ much. If the stable people decide that it's too painful for them > > to deal with the comment vs keyword model, they may want to backport > > these three patches too. > > I was waiting for a v2 series to pick it up given we had some pending changes... Hmpf, looks like it's in torvalds/master now. Miguel, most of the changes were related to the commit log, IIRC, so that ship has sailed. :( Can the stuff in Documentation/ be improved with a follow-up patch, perhaps? -- Kees Cook