Content-Type: multipart/mixed; boundary="===============7682498136918402867==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH nf-next] netfilter: ctnetlink: don't dump ct extensions of unconfirmed conntracks Date: Tue, 15 Oct 2019 10:58:28 +0800 Message-ID: <201910151009.uhMi8FzL%lkp@intel.com> In-Reply-To: <20191014194141.17626-1-fw@strlen.de> List-Id: --===============7682498136918402867== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter= -ctnetlink-don-t-dump-ct-extensions-of-unconfirmed-conntracks/20191015-0400= 05 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git m= aster reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-43-g0ccb3b4-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> net/netfilter/nf_conntrack_netlink.c:520:44: sparse: sparse: incorrect t= ype in argument 2 (different modifiers) @@ expected struct nf_conn *ct @= @ got structstruct nf_conn *ct @@ >> net/netfilter/nf_conntrack_netlink.c:520:44: sparse: expected struct = nf_conn *ct >> net/netfilter/nf_conntrack_netlink.c:520:44: sparse: got struct nf_co= nn const *ct net/netfilter/nf_conntrack_netlink.c:521:45: sparse: sparse: incorrect t= ype in argument 2 (different modifiers) @@ expected struct nf_conn *ct @= @ got structstruct nf_conn *ct @@ net/netfilter/nf_conntrack_netlink.c:521:45: sparse: expected struct = nf_conn *ct net/netfilter/nf_conntrack_netlink.c:521:45: sparse: got struct nf_co= nn const *ct net/netfilter/nf_conntrack_netlink.c:1694:34: sparse: sparse: incompatib= le types in comparison expression (different address spaces): net/netfilter/nf_conntrack_netlink.c:1694:34: sparse: struct nf_connt= rack_helper [noderef] * net/netfilter/nf_conntrack_netlink.c:1694:34: sparse: struct nf_connt= rack_helper * net/netfilter/nf_conntrack_netlink.c:3146:29: sparse: sparse: incorrect = type in argument 1 (different address spaces) @@ expected char const * @= @ got char [noderechar const * @@ net/netfilter/nf_conntrack_netlink.c:3146:29: sparse: expected char c= onst * net/netfilter/nf_conntrack_netlink.c:3146:29: sparse: got char [noder= ef] * net/netfilter/nf_conntrack_netlink.c:951:36: sparse: sparse: context imb= alance in 'ctnetlink_dump_table' - unexpected unlock include/linux/rcupdate.h:651:9: sparse: sparse: context imbalance in 'ct= netlink_parse_nat_setup' - unexpected unlock vim +520 net/netfilter/nf_conntrack_netlink.c 508 = 509 /* all these functions access ct->ext. Caller must either hold a ref= erence 510 * on ct or prevent its deletion by holding either the bucket spinlo= ck or 511 * pcpu dying list lock. 512 */ 513 static int ctnetlink_dump_extinfo(struct sk_buff *skb, 514 const struct nf_conn *ct, u32 type) 515 { 516 if (ctnetlink_dump_acct(skb, ct, type) < 0 || 517 ctnetlink_dump_timestamp(skb, ct) < 0 || 518 ctnetlink_dump_helpinfo(skb, ct) < 0 || 519 ctnetlink_dump_labels(skb, ct) < 0 || > 520 ctnetlink_dump_ct_seq_adj(skb, ct) < 0 || 521 ctnetlink_dump_ct_synproxy(skb, ct) < 0) 522 return -1; 523 = 524 return 0; 525 } 526 = --- 0-DAY kernel test infrastructure Open Source Technology Cent= er https://lists.01.org/pipermail/kbuild-all Intel Corporati= on --===============7682498136918402867==--