Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A206FA372A for ; Thu, 17 Oct 2019 11:45:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB8C121835 for ; Thu, 17 Oct 2019 11:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB8C121835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL4DY-0001sa-Ul for qemu-devel@archiver.kernel.org; Thu, 17 Oct 2019 07:45:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48854) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL4Cr-0001MO-Rw for qemu-devel@nongnu.org; Thu, 17 Oct 2019 07:44:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL4Cp-0003XN-GB for qemu-devel@nongnu.org; Thu, 17 Oct 2019 07:44:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46060) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iL4Cp-0003Wk-AV; Thu, 17 Oct 2019 07:44:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 885DE10CC1FF; Thu, 17 Oct 2019 11:44:33 +0000 (UTC) Received: from gondolin (dhcp-192-202.str.redhat.com [10.33.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1339E60852; Thu, 17 Oct 2019 11:44:29 +0000 (UTC) Date: Thu, 17 Oct 2019 13:44:28 +0200 From: Cornelia Huck To: Andrew Jones Subject: Re: [PATCH] s390x/cpumodel: Add missing visit_free Message-ID: <20191017134428.441745e6.cohuck@redhat.com> In-Reply-To: <20191016145434.7007-1-drjones@redhat.com> References: <20191016145434.7007-1-drjones@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Thu, 17 Oct 2019 11:44:33 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 16 Oct 2019 16:54:34 +0200 Andrew Jones wrote: > Beata Michalska noticed this missing visit_free() while reviewing > arm's implementation of qmp_query_cpu_model_expansion(), which is > modeled off this s390x implementation. > > Signed-off-by: Andrew Jones > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 009afc38b92d..7e92fb2e156d 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, > visitor = qobject_input_visitor_new(info->props); > visit_start_struct(visitor, NULL, NULL, 0, errp); > if (*errp) { > + visit_free(visitor); > object_unref(obj); > return; > } Thanks, applied.