Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3616CA9EAF for ; Mon, 21 Oct 2019 15:47:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3C0920B7C for ; Mon, 21 Oct 2019 15:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729796AbfJUPrQ (ORCPT ); Mon, 21 Oct 2019 11:47:16 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:51610 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727607AbfJUPrP (ORCPT ); Mon, 21 Oct 2019 11:47:15 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1iMZtq-0007O4-06; Mon, 21 Oct 2019 17:47:14 +0200 Date: Mon, 21 Oct 2019 17:47:13 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] main: misleading error reporting in chain definitions Message-ID: <20191021154713.GC17858@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20191021153835.30123-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021153835.30123-1-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Pablo, On Mon, Oct 21, 2019 at 05:38:35PM +0200, Pablo Neira Ayuso wrote: > # nft add chain x y { type filter hook input priority -30\; } > nft: invalid option -- '3' > > Fix this by restricting getopt_long() to the first curly brace. Wouldn't it suffice to set the first char of OPTSTRING to '+'? Exporting POSIXLY_CORRECT=1 prior to calling the above command works at least. Cheers, Phil