From: Stephan Gerhold Subject: Re: [PATCH] drm/msm/dsi: Implement qcom,dsi-phy-regulator-ldo-mode for 28nm PHY Date: Mon, 21 Oct 2019 19:58:18 +0200 Message-ID: <20191021175727.GA86689@gerhold.net> References: <20191021163425.83697-1-stephan@gerhold.net> <20191021174719.GC85762@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191021174719.GC85762@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nikita Travkin , Hai Li List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjEsIDIwMTkgYXQgMDE6NDc6MTlQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIE1vbiwgT2N0IDIxLCAyMDE5IGF0IDA2OjM0OjI1UE0gKzAyMDAsIFN0ZXBoYW4gR2Vy aG9sZCB3cm90ZToKPiA+IFRoZSBEU0kgUEhZIHJlZ3VsYXRvciBzdXBwb3J0cyB0d28gcmVndWxh dG9yIG1vZGVzOiBMRE8gYW5kIERDREMuCj4gPiBUaGlzIG1vZGUgY2FuIGJlIHNlbGVjdGVkIHVz aW5nIHRoZSAicWNvbSxkc2ktcGh5LXJlZ3VsYXRvci1sZG8tbW9kZSIKPiA+IGRldmljZSB0cmVl IHByb3BlcnR5Lgo+ID4gCj4gPiBIb3dldmVyLCBhdCB0aGUgbW9tZW50IG9ubHkgdGhlIDIwbm0g UEhZIGRyaXZlciBhY3R1YWxseSBpbXBsZW1lbnRzCj4gPiB0aGF0IG9wdGlvbi4gQWRkIGEgY2hl Y2sgaW4gdGhlIDI4bm0gUEhZIGRyaXZlciB0byBwcm9ncmFtIHRoZQo+ID4gcmVnaXN0ZXJzIGNv cnJlY3RseSBmb3IgTERPIG1vZGUuCj4gPiAKPiA+IFRlc3RlZC1ieTogTmlraXRhIFRyYXZraW4g PG5pa2l0b3MudHJAZ21haWwuY29tPiAjIGw4MTUwCj4gPiBTaWduZWQtb2ZmLWJ5OiBTdGVwaGFu IEdlcmhvbGQgPHN0ZXBoYW5AZ2VyaG9sZC5uZXQ+Cj4gPiAtLS0KPiA+IFRoaXMgaXMgbmVlZGVk IHRvIG1ha2UgdGhlIGRpc3BsYXkgd29yayBvbiBMb25nY2hlZXIgTDgxNTAsCj4gPiB3aGljaCBo YXMgcmVjZW50bHkgZ2FpbmVkIG1haW5saW5lIHN1cHBvcnQgaW46Cj4gPiBodHRwczovL2dpdC5r ZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9xY29tL2xpbnV4LmdpdC9jb21taXQv P2lkPTE2ZThlODA3MjEwODQyNjAyOWYwYzE2ZGZmN2ZiZTc3ZmFlM2RmOGYKPiA+IAo+ID4gVGhp cyBwYXRjaCBpcyBiYXNlZCBvbiBjb2RlIGZyb20gdGhlIGRvd25zdHJlYW0ga2VybmVsOgo+ID4g aHR0cHM6Ly9zb3VyY2UuY29kZWF1cm9yYS5vcmcvcXVpYy9sYS9rZXJuZWwvbXNtLTMuMTAvdHJl ZS9kcml2ZXJzL3ZpZGVvL21zbS9tZHNzL21zbV9tZHNzX2lvXzg5NzQuYz9oPUxBLkJSLjEuMi45 LjEtMDIzMTAtOHgxNi4wI24xNTIKPiA+IAo+ID4gVGhlIExETyByZWd1bGF0b3IgY29uZmlndXJh dGlvbiBpcyB0YWtlbiBmcm9tIG1zbTg5MTYtcXJkLmR0c2k6Cj4gPiBodHRwczovL3NvdXJjZS5j b2RlYXVyb3JhLm9yZy9xdWljL2xhL2tlcm5lbC9tc20tMy4xMC90cmVlL2FyY2gvYXJtL2Jvb3Qv ZHRzL3Fjb20vbXNtODkxNi1xcmQuZHRzaT9oPUxBLkJSLjEuMi45LjEtMDIzMTAtOHgxNi4wI241 Ngo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHlfMjhubS5j IHwgMjIgKysrKysrKysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHlfMjhubS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9k c2kvcGh5L2RzaV9waHlfMjhubS5jCj4gPiBpbmRleCBiM2Y2NzhmNmMyYWEuLjQ1NzllNmRlNDUz MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL3BoeS9kc2lfcGh5XzI4 bm0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHlfMjhubS5j Cj4gPiBAQCAtNDgsNiArNDgsMjUgQEAgc3RhdGljIHZvaWQgZHNpXzI4bm1fcGh5X3JlZ3VsYXRv cl9jdHJsKHN0cnVjdCBtc21fZHNpX3BoeSAqcGh5LCBib29sIGVuYWJsZSkKPiA+ICAJCXJldHVy bjsKPiA+ICAJfQo+ID4gIAo+ID4gKwlpZiAocGh5LT5yZWd1bGF0b3JfbGRvX21vZGUpIHsKPiA+ ICsJCXUzMiBsZG9fY3RybDsKPiA+ICsKPiA+ICsJCWlmIChwaHktPmNmZy0+dHlwZSA9PSBNU01f RFNJX1BIWV8yOE5NX0xQKQo+ID4gKwkJCWxkb19jdHJsID0gMHgwNTsKPiA+ICsJCWVsc2UKPiA+ ICsJCQlsZG9fY3RybCA9IDB4MGQ7Cj4gPiArCj4gPiArCQlkc2lfcGh5X3dyaXRlKGJhc2UgKyBS RUdfRFNJXzI4bm1fUEhZX1JFR1VMQVRPUl9DVFJMXzAsIDB4MCk7Cj4gPiArCQlkc2lfcGh5X3dy aXRlKGJhc2UgKyBSRUdfRFNJXzI4bm1fUEhZX1JFR1VMQVRPUl9DQUxfUFdSX0NGRywgMCk7Cj4g PiArCQlkc2lfcGh5X3dyaXRlKGJhc2UgKyBSRUdfRFNJXzI4bm1fUEhZX1JFR1VMQVRPUl9DVFJM XzUsIDB4Nyk7Cj4gPiArCQlkc2lfcGh5X3dyaXRlKGJhc2UgKyBSRUdfRFNJXzI4bm1fUEhZX1JF R1VMQVRPUl9DVFJMXzMsIDApOwo+ID4gKwkJZHNpX3BoeV93cml0ZShiYXNlICsgUkVHX0RTSV8y OG5tX1BIWV9SRUdVTEFUT1JfQ1RSTF8yLCAweDEpOwo+ID4gKwkJZHNpX3BoeV93cml0ZShiYXNl ICsgUkVHX0RTSV8yOG5tX1BIWV9SRUdVTEFUT1JfQ1RSTF8xLCAweDEpOwo+ID4gKwkJZHNpX3Bo eV93cml0ZShiYXNlICsgUkVHX0RTSV8yOG5tX1BIWV9SRUdVTEFUT1JfQ1RSTF80LCAweDIwKTsK PiA+ICsJCWRzaV9waHlfd3JpdGUocGh5LT5iYXNlICsgUkVHX0RTSV8yOG5tX1BIWV9MRE9fQ05U UkwsIGxkb19jdHJsKTsKPiA+ICsJCXJldHVybjsKPiA+ICsJfQo+IAo+IG5pdDogU2luY2UgdGhp cyBoYXMgbWluaW1hbCBvdmVybGFwIHdpdGggRENEQyBtb2RlLCBJIHRoaW5rIGl0IHdvdWxkIHJl YWQgYmV0dGVyCj4gaWYgeW91IHNwbGl0IHRoaXMgaW50byAyIGZ1bmN0aW9uczoKPiBkc2lfMjhu bV9waHlfcmVndWxhdG9yX2VuYWJsZV9kY2RjKCkgYW5kIGRzaV8yOG5tX3BoeV9yZWd1bGF0b3Jf ZW5hYmxlX2xkbygpCj4gCj4gU28gcmVndWxhdG9yX2N0cmwgd291bGQgbG9vayBsaWtlOgo+IAo+ IHN0YXRpYyB2b2lkIGRzaV8yOG5tX3BoeV9yZWd1bGF0b3JfY3RybChzdHJ1Y3QgbXNtX2RzaV9w aHkgKnBoeSwgYm9vbCBlbmFibGUpCj4gewo+IAl2b2lkIF9faW9tZW0gKmJhc2UgPSBwaHktPnJl Z19iYXNlOwo+IAo+IAlpZiAoIWVuYWJsZSkgewo+IAkJZHNpX3BoeV93cml0ZShiYXNlICsgUkVH X0RTSV8yOG5tX1BIWV9SRUdVTEFUT1JfQ0FMX1BXUl9DRkcsIDApOwo+IAkJcmV0dXJuOwo+IAl9 Cj4gCj4gCWlmIChwaHktPnJlZ3VsYXRvcl9sZG9fbW9kZSkKPiAgICAgICAgICAgICAgICAgZHNp XzI4bm1fcGh5X3JlZ3VsYXRvcl9lbmFibGVfbGRvKCkKPiAgICAgICAgIGVsc2UKPiAgICAgICAg ICAgICAgICAgZHNpXzI4bm1fcGh5X3JlZ3VsYXRvcl9lbmFibGVfZGNkYygpCj4gfQo+IAoKSSBp bXBsZW1lbnRlZCBpdCBzaW1pbGFyIHRvIGRzaV9waHlfMjBubS5jIFsxXSwgd2hpY2ggbG9va3Mg bGlrZToKCnN0YXRpYyB2b2lkIGRzaV8yMG5tX3BoeV9yZWd1bGF0b3JfY3RybChzdHJ1Y3QgbXNt X2RzaV9waHkgKnBoeSwgYm9vbCBlbmFibGUpCnsKCXZvaWQgX19pb21lbSAqYmFzZSA9IHBoeS0+ cmVnX2Jhc2U7CgoJaWYgKCFlbmFibGUpIHsKCQlkc2lfcGh5X3dyaXRlKGJhc2UgKyBSRUdfRFNJ XzIwbm1fUEhZX1JFR1VMQVRPUl9DQUxfUFdSX0NGRywgMCk7CgkJcmV0dXJuOwoJfQoKCWlmIChw aHktPnJlZ3VsYXRvcl9sZG9fbW9kZSkgewoJCWRzaV9waHlfd3JpdGUocGh5LT5iYXNlICsgUkVH X0RTSV8yMG5tX1BIWV9MRE9fQ05UUkwsIDB4MWQpOwoJCXJldHVybjsKCX0KCgkvKiBub24gTERP IG1vZGUgKi8KCWRzaV9waHlfd3JpdGUoYmFzZSArIFJFR19EU0lfMjBubV9QSFlfUkVHVUxBVE9S X0NUUkxfMSwgMHgwMyk7Cglkc2lfcGh5X3dyaXRlKGJhc2UgKyBSRUdfRFNJXzIwbm1fUEhZX1JF R1VMQVRPUl9DVFJMXzIsIDB4MDMpOwoJZHNpX3BoeV93cml0ZShiYXNlICsgUkVHX0RTSV8yMG5t X1BIWV9SRUdVTEFUT1JfQ1RSTF8zLCAweDAwKTsKCWRzaV9waHlfd3JpdGUoYmFzZSArIFJFR19E U0lfMjBubV9QSFlfUkVHVUxBVE9SX0NUUkxfNCwgMHgyMCk7Cglkc2lfcGh5X3dyaXRlKGJhc2Ug KyBSRUdfRFNJXzIwbm1fUEhZX1JFR1VMQVRPUl9DQUxfUFdSX0NGRywgMHgwMSk7Cglkc2lfcGh5 X3dyaXRlKHBoeS0+YmFzZSArIFJFR19EU0lfMjBubV9QSFlfTERPX0NOVFJMLCAweDAwKTsKCWRz aV9waHlfd3JpdGUoYmFzZSArIFJFR19EU0lfMjBubV9QSFlfUkVHVUxBVE9SX0NUUkxfMCwgMHgw Myk7Cn0KCkkgZ3Vlc3MgaXQgbG9va3MgYmV0dGVyIGZvciB0aGUgMjBubSBQSFkgZHJpdmVyIHNp bmNlIGl0IHdyaXRlcyBvbmx5IGEKc2luZ2xlIHJlZ2lzdGVyIGluIExETyBtb2RlIHJhdGhlciB0 aGFuIHRoZSBmdWxsIHJlZ3VsYXRvcgpjb25maWd1cmF0aW9uLgoKSSdsbCB1cGRhdGUgbXkgcGF0 Y2ggYW5kIHNlbmQgYSB2Mi4gVGhhbmtzIGZvciB0aGUgc3VnZ2VzdGlvbiEKClsxXTogaHR0cHM6 Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXgu Z2l0L3RyZWUvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHlfMjBubS5jI240Mgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=