From: Daniel Vetter Subject: Re: [PATCH v2] drm: atomic helper: fix W=1 warnings Date: Tue, 22 Oct 2019 10:37:25 +0200 Message-ID: <20191022083725.GW11828@phenom.ffwll.local> References: <20191008124254.2144-1-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 286E16E454 for ; Tue, 22 Oct 2019 08:37:29 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id n15so6210345wrw.13 for ; Tue, 22 Oct 2019 01:37:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191008124254.2144-1-benjamin.gaignard@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMDgsIDIwMTkgYXQgMDI6NDI6NTRQTSArMDIwMCwgQmVuamFtaW4gR2FpZ25h cmQgd3JvdGU6Cj4gRmV3IGZvcl9lYWNoIG1hY3JvIHNldCB2YXJpYWJsZXMgdGhhdCBhcmUgbmV2 ZXIgdXNlZCBsYXRlciB3aGljaCBsZWQKPiB0byBnZW5lcmF0ZSB1bnVzZWQtYnV0LXNldC12YXJp YWJsZSB3YXJuaW5ncy4KPiBBZGQgKHZvaWQpKGZvbykgaW5zaWRlIHRoZSBtYWNyb3MgdG8gcmVt b3ZlIHRoZXNlIHdhcm5pbmdzCj4gCj4gU2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQg PGJlbmphbWluLmdhaWduYXJkQHN0LmNvbT4KCk9DRCBpbiBtZSB3b3VsZCBsZWFuIHRvd2FyZHMg YW5ub3RhdGluZyBhbGwgb2YgdGhlbSwgdW5jb25kaXRpb25hbGx5LCBhbmQKYmUgZG9uZS4gQnV0 IEkgZ3Vlc3MgdGhpcyB3b3JrcyB0b28uIEVpdGhlciB3YXk6CgpSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0KPiAgaW5jbHVkZS9kcm0vZHJt X2F0b21pYy5oIHwgMTcgKysrKysrKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9hdG9taWMuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IGluZGV4IDkyN2UxMjA1 ZDdhYS4uYjZjNzNmZDlmNTVhIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMu aAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IEBAIC02OTMsNiArNjkzLDcgQEAg dm9pZCBkcm1fc3RhdGVfZHVtcChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX3By aW50ZXIgKnApOwo+ICAJICAgICAoX19pKSsrKQkJCQkJCQkJXAo+ICAJCWZvcl9lYWNoX2lmICgo X19zdGF0ZSktPmNvbm5lY3RvcnNbX19pXS5wdHIgJiYJCQlcCj4gIAkJCSAgICAgKChjb25uZWN0 b3IpID0gKF9fc3RhdGUpLT5jb25uZWN0b3JzW19faV0ucHRyLAlcCj4gKwkJCSAgICAgKHZvaWQp KGNvbm5lY3RvcikgLyogT25seSB0byBhdm9pZCB1bnVzZWQtYnV0LXNldC12YXJpYWJsZSB3YXJu aW5nICovLCBcCj4gIAkJCSAgICAgKG9sZF9jb25uZWN0b3Jfc3RhdGUpID0gKF9fc3RhdGUpLT5j b25uZWN0b3JzW19faV0ub2xkX3N0YXRlLAlcCj4gIAkJCSAgICAgKG5ld19jb25uZWN0b3Jfc3Rh dGUpID0gKF9fc3RhdGUpLT5jb25uZWN0b3JzW19faV0ubmV3X3N0YXRlLCAxKSkKPiAgCj4gQEAg LTcxNCw2ICs3MTUsNyBAQCB2b2lkIGRybV9zdGF0ZV9kdW1wKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHN0cnVjdCBkcm1fcHJpbnRlciAqcCk7Cj4gIAkgICAgIChfX2kpKyspCQkJCQkJCQlcCj4g IAkJZm9yX2VhY2hfaWYgKChfX3N0YXRlKS0+Y29ubmVjdG9yc1tfX2ldLnB0ciAmJgkJCVwKPiAg CQkJICAgICAoKGNvbm5lY3RvcikgPSAoX19zdGF0ZSktPmNvbm5lY3RvcnNbX19pXS5wdHIsCVwK PiArCQkJICAgICAodm9pZCkoY29ubmVjdG9yKSAvKiBPbmx5IHRvIGF2b2lkIHVudXNlZC1idXQt c2V0LXZhcmlhYmxlIHdhcm5pbmcgKi8sIFwKPiAgCQkJICAgICAob2xkX2Nvbm5lY3Rvcl9zdGF0 ZSkgPSAoX19zdGF0ZSktPmNvbm5lY3RvcnNbX19pXS5vbGRfc3RhdGUsIDEpKQo+ICAKPiAgLyoq Cj4gQEAgLTczNCw3ICs3MzYsOSBAQCB2b2lkIGRybV9zdGF0ZV9kdW1wKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHN0cnVjdCBkcm1fcHJpbnRlciAqcCk7Cj4gIAkgICAgIChfX2kpKyspCQkJCQkJ CQlcCj4gIAkJZm9yX2VhY2hfaWYgKChfX3N0YXRlKS0+Y29ubmVjdG9yc1tfX2ldLnB0ciAmJgkJ CVwKPiAgCQkJICAgICAoKGNvbm5lY3RvcikgPSAoX19zdGF0ZSktPmNvbm5lY3RvcnNbX19pXS5w dHIsCVwKPiAtCQkJICAgICAobmV3X2Nvbm5lY3Rvcl9zdGF0ZSkgPSAoX19zdGF0ZSktPmNvbm5l Y3RvcnNbX19pXS5uZXdfc3RhdGUsIDEpKQo+ICsJCQkgICAgICh2b2lkKShjb25uZWN0b3IpIC8q IE9ubHkgdG8gYXZvaWQgdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgd2FybmluZyAqLywgXAo+ICsJ CQkgICAgIChuZXdfY29ubmVjdG9yX3N0YXRlKSA9IChfX3N0YXRlKS0+Y29ubmVjdG9yc1tfX2ld Lm5ld19zdGF0ZSwgXAo+ICsJCQkgICAgICh2b2lkKShuZXdfY29ubmVjdG9yX3N0YXRlKSAvKiBP bmx5IHRvIGF2b2lkIHVudXNlZC1idXQtc2V0LXZhcmlhYmxlIHdhcm5pbmcgKi8sIDEpKQo+ICAK PiAgLyoqCj4gICAqIGZvcl9lYWNoX29sZG5ld19jcnRjX2luX3N0YXRlIC0gaXRlcmF0ZSBvdmVy IGFsbCBDUlRDcyBpbiBhbiBhdG9taWMgdXBkYXRlCj4gQEAgLTc1NCw3ICs3NTgsOSBAQCB2b2lk IGRybV9zdGF0ZV9kdW1wKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fcHJpbnRl ciAqcCk7Cj4gIAkgICAgIChfX2kpKyspCQkJCQkJCVwKPiAgCQlmb3JfZWFjaF9pZiAoKF9fc3Rh dGUpLT5jcnRjc1tfX2ldLnB0ciAmJgkJXAo+ICAJCQkgICAgICgoY3J0YykgPSAoX19zdGF0ZSkt PmNydGNzW19faV0ucHRyLAlcCj4gKwkJCSAgICAgICh2b2lkKShjcnRjKSAvKiBPbmx5IHRvIGF2 b2lkIHVudXNlZC1idXQtc2V0LXZhcmlhYmxlIHdhcm5pbmcgKi8sIFwKPiAgCQkJICAgICAob2xk X2NydGNfc3RhdGUpID0gKF9fc3RhdGUpLT5jcnRjc1tfX2ldLm9sZF9zdGF0ZSwgXAo+ICsJCQkg ICAgICh2b2lkKShvbGRfY3J0Y19zdGF0ZSkgLyogT25seSB0byBhdm9pZCB1bnVzZWQtYnV0LXNl dC12YXJpYWJsZSB3YXJuaW5nICovLCBcCj4gIAkJCSAgICAgKG5ld19jcnRjX3N0YXRlKSA9IChf X3N0YXRlKS0+Y3J0Y3NbX19pXS5uZXdfc3RhdGUsIDEpKQo+ICAKPiAgLyoqCj4gQEAgLTc5Myw3 ICs3OTksOSBAQCB2b2lkIGRybV9zdGF0ZV9kdW1wKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0 cnVjdCBkcm1fcHJpbnRlciAqcCk7Cj4gIAkgICAgIChfX2kpKyspCQkJCQkJCVwKPiAgCQlmb3Jf ZWFjaF9pZiAoKF9fc3RhdGUpLT5jcnRjc1tfX2ldLnB0ciAmJgkJXAo+ICAJCQkgICAgICgoY3J0 YykgPSAoX19zdGF0ZSktPmNydGNzW19faV0ucHRyLAlcCj4gLQkJCSAgICAgKG5ld19jcnRjX3N0 YXRlKSA9IChfX3N0YXRlKS0+Y3J0Y3NbX19pXS5uZXdfc3RhdGUsIDEpKQo+ICsJCQkgICAgICh2 b2lkKShjcnRjKSAvKiBPbmx5IHRvIGF2b2lkIHVudXNlZC1idXQtc2V0LXZhcmlhYmxlIHdhcm5p bmcgKi8sIFwKPiArCQkJICAgICAobmV3X2NydGNfc3RhdGUpID0gKF9fc3RhdGUpLT5jcnRjc1tf X2ldLm5ld19zdGF0ZSwgXAo+ICsJCQkgICAgICh2b2lkKShuZXdfY3J0Y19zdGF0ZSkgLyogT25s eSB0byBhdm9pZCB1bnVzZWQtYnV0LXNldC12YXJpYWJsZSB3YXJuaW5nICovLCAxKSkKPiAgCj4g IC8qKgo+ICAgKiBmb3JfZWFjaF9vbGRuZXdfcGxhbmVfaW5fc3RhdGUgLSBpdGVyYXRlIG92ZXIg YWxsIHBsYW5lcyBpbiBhbiBhdG9taWMgdXBkYXRlCj4gQEAgLTgxMyw2ICs4MjEsNyBAQCB2b2lk IGRybV9zdGF0ZV9kdW1wKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fcHJpbnRl ciAqcCk7Cj4gIAkgICAgIChfX2kpKyspCQkJCQkJCVwKPiAgCQlmb3JfZWFjaF9pZiAoKF9fc3Rh dGUpLT5wbGFuZXNbX19pXS5wdHIgJiYJCVwKPiAgCQkJICAgICAoKHBsYW5lKSA9IChfX3N0YXRl KS0+cGxhbmVzW19faV0ucHRyLAlcCj4gKwkJCSAgICAgICh2b2lkKShwbGFuZSkgLyogT25seSB0 byBhdm9pZCB1bnVzZWQtYnV0LXNldC12YXJpYWJsZSB3YXJuaW5nICovLCBcCj4gIAkJCSAgICAg IChvbGRfcGxhbmVfc3RhdGUpID0gKF9fc3RhdGUpLT5wbGFuZXNbX19pXS5vbGRfc3RhdGUsXAo+ ICAJCQkgICAgICAobmV3X3BsYW5lX3N0YXRlKSA9IChfX3N0YXRlKS0+cGxhbmVzW19faV0ubmV3 X3N0YXRlLCAxKSkKPiAgCj4gQEAgLTg3Myw3ICs4ODIsOSBAQCB2b2lkIGRybV9zdGF0ZV9kdW1w KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fcHJpbnRlciAqcCk7Cj4gIAkgICAg IChfX2kpKyspCQkJCQkJCVwKPiAgCQlmb3JfZWFjaF9pZiAoKF9fc3RhdGUpLT5wbGFuZXNbX19p XS5wdHIgJiYJCVwKPiAgCQkJICAgICAoKHBsYW5lKSA9IChfX3N0YXRlKS0+cGxhbmVzW19faV0u cHRyLAlcCj4gLQkJCSAgICAgIChuZXdfcGxhbmVfc3RhdGUpID0gKF9fc3RhdGUpLT5wbGFuZXNb X19pXS5uZXdfc3RhdGUsIDEpKQo+ICsJCQkgICAgICAodm9pZCkocGxhbmUpIC8qIE9ubHkgdG8g YXZvaWQgdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgd2FybmluZyAqLywgXAo+ICsJCQkgICAgICAo bmV3X3BsYW5lX3N0YXRlKSA9IChfX3N0YXRlKS0+cGxhbmVzW19faV0ubmV3X3N0YXRlLCBcCj4g KwkJCSAgICAgICh2b2lkKShuZXdfcGxhbmVfc3RhdGUpIC8qIE9ubHkgdG8gYXZvaWQgdW51c2Vk LWJ1dC1zZXQtdmFyaWFibGUgd2FybmluZyAqLywgMSkpCj4gIAo+ICAvKioKPiAgICogZm9yX2Vh Y2hfb2xkbmV3X3ByaXZhdGVfb2JqX2luX3N0YXRlIC0gaXRlcmF0ZSBvdmVyIGFsbCBwcml2YXRl IG9iamVjdHMgaW4gYW4gYXRvbWljIHVwZGF0ZQo+IC0tIAo+IDIuMTUuMAo+IAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==