From: Daniel Vetter Subject: Re: [PATCH] drm/virtio: move byteorder handling into virtio_gpu_cmd_transfer_to_host_2d function Date: Tue, 22 Oct 2019 11:06:21 +0200 Message-ID: <20191022090621.GC11828@phenom.ffwll.local> References: <20191018122352.17019-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C28C6E4A6 for ; Tue, 22 Oct 2019 09:06:26 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id l10so16689329wrb.2 for ; Tue, 22 Oct 2019 02:06:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191018122352.17019-1-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMTgsIDIwMTkgYXQgMDI6MjM6NTJQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBCZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YgdGhlIGNvZGUgYmFzZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KCkFzc3Vt aW5nIHNwYXJzZSBpcyBhbGwgc3RpbGwgcGxlYXNlZDoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Zp cnRpby92aXJ0Z3B1X2Rydi5oICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS92aXJ0aW8v dmlydGdwdV9wbGFuZS5jIHwgMTIgKysrKysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92aXJ0 aW8vdmlydGdwdV92cS5jICAgIHwgMTIgKysrKysrLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8v dmlydGdwdV9kcnYuaAo+IGluZGV4IDMxNGUwMmY5NGQ5Yy4uMGI1NmJhMDA1ZTI1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9kcnYuaAo+IEBAIC0yNjcsOCArMjY3LDggQEAgdm9p ZCB2aXJ0aW9fZ3B1X2NtZF91bnJlZl9yZXNvdXJjZShzdHJ1Y3QgdmlydGlvX2dwdV9kZXZpY2Ug KnZnZGV2LAo+ICAJCQkJICAgdWludDMyX3QgcmVzb3VyY2VfaWQpOwo+ICB2b2lkIHZpcnRpb19n cHVfY21kX3RyYW5zZmVyX3RvX2hvc3RfMmQoc3RydWN0IHZpcnRpb19ncHVfZGV2aWNlICp2Z2Rl diwKPiAgCQkJCQl1aW50NjRfdCBvZmZzZXQsCj4gLQkJCQkJX19sZTMyIHdpZHRoLCBfX2xlMzIg aGVpZ2h0LAo+IC0JCQkJCV9fbGUzMiB4LCBfX2xlMzIgeSwKPiArCQkJCQl1aW50MzJfdCB3aWR0 aCwgdWludDMyX3QgaGVpZ2h0LAo+ICsJCQkJCXVpbnQzMl90IHgsIHVpbnQzMl90IHksCj4gIAkJ CQkJc3RydWN0IHZpcnRpb19ncHVfb2JqZWN0X2FycmF5ICpvYmpzLAo+ICAJCQkJCXN0cnVjdCB2 aXJ0aW9fZ3B1X2ZlbmNlICpmZW5jZSk7Cj4gIHZvaWQgdmlydGlvX2dwdV9jbWRfcmVzb3VyY2Vf Zmx1c2goc3RydWN0IHZpcnRpb19ncHVfZGV2aWNlICp2Z2RldiwKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmly dGlvL3ZpcnRncHVfcGxhbmUuYwo+IGluZGV4IGY0YjczNjAyODJjZS4uMzkwNTI0MTQzMTM5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9wbGFuZS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X3BsYW5lLmMKPiBAQCAtMTMyLDEwICsx MzIsMTAgQEAgc3RhdGljIHZvaWQgdmlydGlvX2dwdV9wcmltYXJ5X3BsYW5lX3VwZGF0ZShzdHJ1 Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQkJdmlydGlvX2dwdV9hcnJheV9hZGRfb2JqKG9ianMs IHZnZmItPmJhc2Uub2JqWzBdKTsKPiAgCQkJdmlydGlvX2dwdV9jbWRfdHJhbnNmZXJfdG9faG9z dF8yZAo+ICAJCQkJKHZnZGV2LCAwLAo+IC0JCQkJIGNwdV90b19sZTMyKHBsYW5lLT5zdGF0ZS0+ c3JjX3cgPj4gMTYpLAo+IC0JCQkJIGNwdV90b19sZTMyKHBsYW5lLT5zdGF0ZS0+c3JjX2ggPj4g MTYpLAo+IC0JCQkJIGNwdV90b19sZTMyKHBsYW5lLT5zdGF0ZS0+c3JjX3ggPj4gMTYpLAo+IC0J CQkJIGNwdV90b19sZTMyKHBsYW5lLT5zdGF0ZS0+c3JjX3kgPj4gMTYpLAo+ICsJCQkJIHBsYW5l LT5zdGF0ZS0+c3JjX3cgPj4gMTYsCj4gKwkJCQkgcGxhbmUtPnN0YXRlLT5zcmNfaCA+PiAxNiwK PiArCQkJCSBwbGFuZS0+c3RhdGUtPnNyY194ID4+IDE2LAo+ICsJCQkJIHBsYW5lLT5zdGF0ZS0+ c3JjX3kgPj4gMTYsCj4gIAkJCQkgb2JqcywgTlVMTCk7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiBA QCAtMjM0LDggKzIzNCw4IEBAIHN0YXRpYyB2b2lkIHZpcnRpb19ncHVfY3Vyc29yX3BsYW5lX3Vw ZGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQl2aXJ0aW9fZ3B1X2FycmF5X2FkZF9v Ymoob2JqcywgdmdmYi0+YmFzZS5vYmpbMF0pOwo+ICAJCXZpcnRpb19ncHVfY21kX3RyYW5zZmVy X3RvX2hvc3RfMmQKPiAgCQkJKHZnZGV2LCAwLAo+IC0JCQkgY3B1X3RvX2xlMzIocGxhbmUtPnN0 YXRlLT5jcnRjX3cpLAo+IC0JCQkgY3B1X3RvX2xlMzIocGxhbmUtPnN0YXRlLT5jcnRjX2gpLAo+ ICsJCQkgcGxhbmUtPnN0YXRlLT5jcnRjX3csCj4gKwkJCSBwbGFuZS0+c3RhdGUtPmNydGNfaCwK PiAgCQkJIDAsIDAsIG9ianMsIHZnZmItPmZlbmNlKTsKPiAgCQlkbWFfZmVuY2Vfd2FpdCgmdmdm Yi0+ZmVuY2UtPmYsIHRydWUpOwo+ICAJCWRtYV9mZW5jZV9wdXQoJnZnZmItPmZlbmNlLT5mKTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X3ZxLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfdnEuYwo+IGluZGV4IDgwMTc2ZjM3OWFkNS4uNzRh ZDNiYzNlYmU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV92 cS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X3ZxLmMKPiBAQCAtNTQ5 LDggKzU0OSw4IEBAIHZvaWQgdmlydGlvX2dwdV9jbWRfcmVzb3VyY2VfZmx1c2goc3RydWN0IHZp cnRpb19ncHVfZGV2aWNlICp2Z2RldiwKPiAgCj4gIHZvaWQgdmlydGlvX2dwdV9jbWRfdHJhbnNm ZXJfdG9faG9zdF8yZChzdHJ1Y3QgdmlydGlvX2dwdV9kZXZpY2UgKnZnZGV2LAo+ICAJCQkJCXVp bnQ2NF90IG9mZnNldCwKPiAtCQkJCQlfX2xlMzIgd2lkdGgsIF9fbGUzMiBoZWlnaHQsCj4gLQkJ CQkJX19sZTMyIHgsIF9fbGUzMiB5LAo+ICsJCQkJCXVpbnQzMl90IHdpZHRoLCB1aW50MzJfdCBo ZWlnaHQsCj4gKwkJCQkJdWludDMyX3QgeCwgdWludDMyX3QgeSwKPiAgCQkJCQlzdHJ1Y3Qgdmly dGlvX2dwdV9vYmplY3RfYXJyYXkgKm9ianMsCj4gIAkJCQkJc3RydWN0IHZpcnRpb19ncHVfZmVu Y2UgKmZlbmNlKQo+ICB7Cj4gQEAgLTU3MSwxMCArNTcxLDEwIEBAIHZvaWQgdmlydGlvX2dwdV9j bWRfdHJhbnNmZXJfdG9faG9zdF8yZChzdHJ1Y3QgdmlydGlvX2dwdV9kZXZpY2UgKnZnZGV2LAo+ ICAJY21kX3AtPmhkci50eXBlID0gY3B1X3RvX2xlMzIoVklSVElPX0dQVV9DTURfVFJBTlNGRVJf VE9fSE9TVF8yRCk7Cj4gIAljbWRfcC0+cmVzb3VyY2VfaWQgPSBjcHVfdG9fbGUzMihiby0+aHdf cmVzX2hhbmRsZSk7Cj4gIAljbWRfcC0+b2Zmc2V0ID0gY3B1X3RvX2xlNjQob2Zmc2V0KTsKPiAt CWNtZF9wLT5yLndpZHRoID0gd2lkdGg7Cj4gLQljbWRfcC0+ci5oZWlnaHQgPSBoZWlnaHQ7Cj4g LQljbWRfcC0+ci54ID0geDsKPiAtCWNtZF9wLT5yLnkgPSB5Owo+ICsJY21kX3AtPnIud2lkdGgg PSBjcHVfdG9fbGUzMih3aWR0aCk7Cj4gKwljbWRfcC0+ci5oZWlnaHQgPSBjcHVfdG9fbGUzMiho ZWlnaHQpOwo+ICsJY21kX3AtPnIueCA9IGNwdV90b19sZTMyKHgpOwo+ICsJY21kX3AtPnIueSA9 IGNwdV90b19sZTMyKHkpOwo+ICAKPiAgCXZpcnRpb19ncHVfcXVldWVfZmVuY2VkX2N0cmxfYnVm ZmVyKHZnZGV2LCB2YnVmLCAmY21kX3AtPmhkciwgZmVuY2UpOwo+ICB9Cj4gLS0gCj4gMi4xOC4x Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs