From: Daniel Vetter Subject: Re: [PATCH] drm/v3d: Fix memory leak in v3d_submit_cl_ioctl Date: Wed, 23 Oct 2019 11:16:01 +0200 Message-ID: <20191023091601.GX11828@phenom.ffwll.local> References: <20191021185250.26130-1-navid.emamdoost@gmail.com> <20191022093654.GF11828@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id D97FA6E12B for ; Wed, 23 Oct 2019 09:16:05 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id a11so5119001wra.6 for ; Wed, 23 Oct 2019 02:16:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Navid Emamdoost Cc: David Airlie , Kangjie Lu , LKML , dri-devel@lists.freedesktop.org, Navid Emamdoost , Stephen McCamant List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMjIsIDIwMTkgYXQgMTA6NTM6NTdQTSAtMDUwMCwgTmF2aWQgRW1hbWRvb3N0 IHdyb3RlOgo+IE9uIFR1ZSwgT2N0IDIyLCAyMDE5IGF0IDQ6MzYgQU0gRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+Cj4gPiBPbiBNb24sIE9jdCAyMSwgMjAxOSBhdCAw MTo1Mjo0OVBNIC0wNTAwLCBOYXZpZCBFbWFtZG9vc3Qgd3JvdGU6Cj4gPiA+IEluIHRoZSBpbXBl bGVtZW50YXRpb24gb2YgdjNkX3N1Ym1pdF9jbF9pb2N0bCgpIHRoZXJlIGFyZSB0d28gbWVtb3J5 Cj4gPiA+IGxlYWtzLiBPbmUgaXMgd2hlbiBhbGxvY2F0aW9uIGZvciBiaW4gZmFpbHMsIGFuZCB0 aGUgb3RoZXIgaXMgd2hlbiBiaW4KPiA+ID4gaW5pdGlhbGl6YXRpb24gZmFpbHMuIElmIGtjYWxs b2MgZmFpbHMgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciBiaW4gdGhlbgo+ID4gPiByZW5kZXItPmJh c2Ugc2hvdWxkIGJlIHB1dC4gQWxzbywgaWYgdjNkX2pvYl9pbml0KCkgZmFpbHMgdG8gaW5pdGlh bGl6ZQo+ID4gPiBiaW4tPmJhc2UgdGhlbiBhbGxvY2F0ZWQgbWVtb3J5IGZvciBiaW4gc2hvdWxk IGJlIHJlbGVhc2VkLgo+ID4gPgo+ID4gPiBGaXhlczogYTc4M2EwOWVlNzZkICgiZHJtL3YzZDog UmVmYWN0b3Igam9iIG1hbmFnZW1lbnQuIikKPiA+ID4gU2lnbmVkLW9mZi1ieTogTmF2aWQgRW1h bWRvb3N0IDxuYXZpZC5lbWFtZG9vc3RAZ21haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS92M2QvdjNkX2dlbS5jIHwgNSArKysrLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9n ZW0uYwo+ID4gPiBpbmRleCA1ZDgwNTA3YjUzOWIuLjE5YzA5MmQ3NTI2NiAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZ2VtLmMKPiA+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3YzZC92M2RfZ2VtLmMKPiA+ID4gQEAgLTU1NywxMyArNTU3LDE2IEBAIHYzZF9zdWJt aXRfY2xfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiA+ID4KPiA+ ID4gICAgICAgaWYgKGFyZ3MtPmJjbF9zdGFydCAhPSBhcmdzLT5iY2xfZW5kKSB7Cj4gPiA+ICAg ICAgICAgICAgICAgYmluID0ga2NhbGxvYygxLCBzaXplb2YoKmJpbiksIEdGUF9LRVJORUwpOwo+ ID4gPiAtICAgICAgICAgICAgIGlmICghYmluKQo+ID4gPiArICAgICAgICAgICAgIGlmICghYmlu KSB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICB2M2Rfam9iX3B1dCgmcmVuZGVyLT5iYXNl KTsKPiA+Cj4gPiBUaGUgam9iIGlzbid0IGluaXRpYWxpemVkIHlldCwgdGhpcyBkb2Vzbid0IHdv cmsuCj4gRG8geW91IG1lYW4gd2UgaGF2ZSB0byByZWxlYXNlIHJlbmRlciB2aWEga2ZyZWUoKSBo ZXJlPwo+IAo+ID4KPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ ID4gPiArICAgICAgICAgICAgIH0KPiA+ID4KPiA+ID4gICAgICAgICAgICAgICByZXQgPSB2M2Rf am9iX2luaXQodjNkLCBmaWxlX3ByaXYsICZiaW4tPmJhc2UsCj4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHYzZF9qb2JfZnJlZSwgYXJncy0+aW5fc3luY19iY2wpOwo+ID4g PiAgICAgICAgICAgICAgIGlmIChyZXQpIHsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHYz ZF9qb2JfcHV0KCZyZW5kZXItPmJhc2UpOwo+ID4KPiA+IHYzZF9qb2JfcHV0IHdpbGwgY2FsbCBr ZnJlZSwgaWYgeW91IGNoYXNlIHRoZSBjYWxsY2hhaW4gbG9uZyBlbm91Z2ggKGluCj4gPiB2M2Rf am9iX2ZyZWUpLiBTbyBubyBidWcgaGVyZSwgdGhpcyB3b3VsZCBsZWFkIHRvIGEgZG91YmxlIGtm cmVlIGFuZAo+ID4gY3Jhc2guCj4gWWVzLCB2M2Rfam9iX3B1dCgpIHRha2VzIGNhcmUgb2YgcmVu ZGVyLAo+IAo+ID4gLURhbmllbAo+ID4KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGtmcmVl KGJpbik7Cj4gYnV0IGhvdyBhYm91dCBsZWFraW5nIGJpbj8KClNvcnJ5LCBJIHRvdGFsbHkgbWlz c2VkIHRoYXQgdGhpcyBpcyBiaW4sIG5vIHJlbmRlci4gUGF0Y2ggbG9va3MgY29ycmVjdAp0byBt ZS4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoK PiAKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ICAgICAgICAg ICAgICAgfQo+ID4gPgo+ID4gPiAtLQo+ID4gPiAyLjE3LjEKPiA+ID4KPiA+Cj4gPiAtLQo+ID4g RGFuaWVsIFZldHRlcgo+ID4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4g PiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IAo+IAo+IAo+IC0tIAo+IE5hdmlkLgoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==