Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A55D2CA9EB9 for ; Wed, 23 Oct 2019 19:06:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C8972086D for ; Wed, 23 Oct 2019 19:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="iIw8w8tE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C8972086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iNLx1-0005D5-As; Wed, 23 Oct 2019 19:05:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iNLwz-0005D0-Om for xen-devel@lists.xenproject.org; Wed, 23 Oct 2019 19:05:41 +0000 X-Inumbo-ID: 1af4bc62-f5c8-11e9-beca-bc764e2007e4 Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1af4bc62-f5c8-11e9-beca-bc764e2007e4; Wed, 23 Oct 2019 19:05:41 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id A050B490; Wed, 23 Oct 2019 15:05:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 23 Oct 2019 15:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wOZWZ1 IBttvHIJhNpapewyQlbXCt0E2Foe4sljHjBQQ=; b=iIw8w8tEGX63qsLuDM+bSc uMsruWu5A9k25H9usTviNzXCbqevo8i2QoD0ThFAPwH5m793nuvfJ+S4rHXgFX7L 7Ik5J6LDH/wkTvJKE2YcP/tr/ONimp6J/kxJ1hIkNOOiR2w4NS9qj5COAhUx77Mq cLW0JXF6PHtR362FkREgerWucdABxquIi/C/HGWwYdXmGcsQFbTUOBXEpUaEIr2u Uefk2o1sPWfNwqB1FSNZXwwuKZYLKCYjyhgCKtwzp+U0wl0ljcsap+8bj3WkdPiN 6pHh0P1FE1aOtD5i+F+ggk+cRKFw0P/G/32y8kYQ6N158DRrx8XNBTGIy3nK3i0Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrkeelgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucffohhmrghinhepgigvnhdrohhr ghenucfkphepledurdeihedrfeegrdeffeenucfrrghrrghmpehmrghilhhfrhhomhepmh grrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomhenucevlhhu shhtvghrufhiiigvpedt X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EEC6D6005F; Wed, 23 Oct 2019 15:05:37 -0400 (EDT) Date: Wed, 23 Oct 2019 21:05:33 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: "K. Kahurani" Message-ID: <20191023190533.GA4109@mail-itl> References: <20191023084841.30903-1-k.kahurani@gmail.com> <20191023084841.30903-2-k.kahurani@gmail.com> MIME-Version: 1.0 In-Reply-To: <20191023084841.30903-2-k.kahurani@gmail.com> Subject: Re: [Xen-devel] [PATCH 1/1] tools/configure: remove redundancy X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: admin@rapidseedbox.com, jbeulic@suse.com, ian.jackson@eu.citrix.com, jfehlig@suse.com, xen-devel@lists.xenproject.org, eblake@redhat.com Content-Type: multipart/mixed; boundary="===============1520102963260763897==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============1520102963260763897== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Xen-devel] [PATCH 1/1] tools/configure: remove redundancy On Wed, Oct 23, 2019 at 11:48:41AM +0300, K. Kahurani wrote: > This piece of code is redundant and results in a garbage error > message on systems that do not have a default python executable. >=20 > Signed-off-by: K. Kahurani > --- > tools/configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/tools/configure b/tools/configure > index 82947ad..a1f36d1 100755 > --- a/tools/configure > +++ b/tools/configure configure script is a generated file, you should edit tools/configure.ac instead (and then generate tools/configure out of it). You may also want to look at this commit for reasoning of the current code shape: https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommitdiff;h=3D9caed751db91= 10c785fd6b1def89d808baa1d907;hp=3D88339ae94f4309888eae81a6cceac9577a319d7e --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl2wpH4ACgkQ24/THMrX 1yyh0wf/U2BjxKlpU1QOTzeiTznSJejaYIPKURfJj09NNSuOrHpOczM0YyMT/Jhy 4xghkuCoMPCxMv8+U+GCTO7Nb1BYZz6wEiwCONS3YcGk3H67YsngnhilFHlhkO/M QnxPKLAr5D5yU3PZG0hHNq+A6t7TW8Tp1MS5RiihkvCBTmtBEMmm0ehLUtp+JeG6 84EGjSoLTeT+PYsdNCaYOs8ybyQyEXoptILDPUNoPmb1y5QjJeyA7aZo71h3ZmCe atyRYcBveZ4chesfbCsVZ3rTqMYc8yfF1C/yoZ/lwr5XkagvzpudizDuHd79yHGb iu85jE9aFQbsFNaU/83c1LnU+BVGSg== =fbyk -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz-- --===============1520102963260763897== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============1520102963260763897==--