Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B0ECA9EB9 for ; Thu, 24 Oct 2019 00:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 307D321906 for ; Thu, 24 Oct 2019 00:42:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WV85ovrp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408087AbfJXAmM (ORCPT ); Wed, 23 Oct 2019 20:42:12 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:52444 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392855AbfJXAmL (ORCPT ); Wed, 23 Oct 2019 20:42:11 -0400 Received: from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net [93.2.121.143]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D6DA912E5; Thu, 24 Oct 2019 02:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571877727; bh=4X0GdekeQgNBZL3HjPkbE1SHO17kf5LmTO+VSCJy/uA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WV85ovrpOGpYuDe/sw+ii/m+gusPXbhFan4pu6an6QlZMFajimU4NKWkY9Ui7encY vw/nPBkrQVms82L8MlZa0eSqAxku/CVJHTGw4IaH8H3/bGLj67IRG1ZB41pJt1UvAY 6iF+SifwsH2TRcy4wBx5BPXw89Je5oTKznQEbTpg= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Steve Longerbeam , Philipp Zabel , Rui Miguel Silva Subject: [PATCH 6/7] media: imx: imx7-media-csi: Remove unneeded register read Date: Thu, 24 Oct 2019 03:41:54 +0300 Message-Id: <20191024004155.32068-7-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191024004155.32068-1-laurent.pinchart@ideasonboard.com> References: <20191024004155.32068-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The imx7_csi_dma_reflash() function starts by reading the unrelated register CSI_CSICR18 to then overwrite the read value with a read from register CSI_CSICR3. This is likely due to a bad copy&paste, and is not needed. Remove the extraneous read from register CSI_CSICR18. Signed-off-by: Laurent Pinchart --- drivers/staging/media/imx/imx7-media-csi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index e4c9bcc045f7..ac07f55a63e3 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -292,7 +292,7 @@ static void imx7_csi_hw_disable(struct imx7_csi *csi) static void imx7_csi_dma_reflash(struct imx7_csi *csi) { - u32 cr3 = imx7_csi_reg_read(csi, CSI_CSICR18); + u32 cr3; cr3 = imx7_csi_reg_read(csi, CSI_CSICR3); cr3 |= BIT_DMA_REFLASH_RFF; -- Regards, Laurent Pinchart