From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/14] drm/i915: Rework watermark readout to use plane api Date: Thu, 24 Oct 2019 17:33:28 +0300 Message-ID: <20191024143328.GC1208@intel.com> References: <20191024124805.26840-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6495F6E41B for ; Thu, 24 Oct 2019 14:33:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191024124805.26840-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjQsIDIwMTkgYXQgMDI6NDc6NTJQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSW5zdGVhZCBvZiB1bmNvbmRpdGlvbmFsbHkgdmVyaWZ5aW5nIHRoZSBjdXJz b3IgcGxhbmUsIGhhbmRsZSBpdCBpbiB0aGUKPiBzYW1lIHdheSBhcyBhbnkgb3RoZXIgcGxhbmUs IGFuZCB1c2Ugb3VyIGV4aXN0aW5nIGFwaSB0byB2ZXJpZnkuCj4gCj4gV2hpbGUgYXQgaXQsIGVu c3VyZSB0aGF0IG9uIGdlbjkrIHdlIHZlcmlmeSBhY3RpdmVfcGxhbmVzIG1hc2sgYXMgd2VsbC4K PiBUaGlzIHNob3VsZCBnaXZlIHRoZSBjb3JyZWN0IHJlc3VsdHMgZm9yIHBsYW5hciBZVVYgcGxh bmVzIHRvbywgYXMgd2UKPiB1cGRhdGUgYWN0aXZlX3BsYW5lcyBmb3IgdGhlbS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3Bs YXkuYyB8IDgzICsrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNl cnRpb25zKCspLCA2MCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9k aXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDU3OTY1NTY3NWIwOC4uNGU0MjczYzRhZTU3 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxh eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMK PiBAQCAtMTMxODMsNyArMTMxODMsOCBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlfd21fc3RhdGUoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAlzdHJ1Y3Qgc2tsX3BpcGVfd20gKnN3X3dtOwo+ICAJ c3RydWN0IHNrbF9kZGJfZW50cnkgKmh3X2RkYl9lbnRyeSwgKnN3X2RkYl9lbnRyeTsKPiAgCWNv bnN0IGVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiAtCWludCBwbGFuZSwgbGV2ZWwsIG1h eF9sZXZlbCA9IGlsa193bV9tYXhfbGV2ZWwoZGV2X3ByaXYpOwo+ICsJaW50IGxldmVsLCBtYXhf bGV2ZWwgPSBpbGtfd21fbWF4X2xldmVsKGRldl9wcml2KTsKPiArCXN0cnVjdCBpbnRlbF9wbGFu ZSAqcGxhbmU7Cj4gIAo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5IHx8ICFuZXdfY3J0 Y19zdGF0ZS0+YmFzZS5hY3RpdmUpCj4gIAkJcmV0dXJuOwo+IEBAIC0xMzIwNyw2MyArMTMyMDgs MjUgQEAgc3RhdGljIHZvaWQgdmVyaWZ5X3dtX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj LAo+ICAJCQkgIGh3LT5kZGIuZW5hYmxlZF9zbGljZXMpOwo+ICAKPiAgCS8qIHBsYW5lcyAqLwo+ IC0JZm9yX2VhY2hfdW5pdmVyc2FsX3BsYW5lKGRldl9wcml2LCBwaXBlLCBwbGFuZSkgewo+ICsJ Zm9yX2VhY2hfaW50ZWxfcGxhbmVfb25fY3J0YygmZGV2X3ByaXYtPmRybSwgY3J0YywgcGxhbmUp IHsKPiAgCQlzdHJ1Y3Qgc2tsX3BsYW5lX3dtICpod19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ ICsJCWVudW0gcGlwZSBwbGFuZV9waXBlID0gcGlwZTsKPiAgCj4gLQkJaHdfcGxhbmVfd20gPSAm aHctPndtLnBsYW5lc1twbGFuZV07Cj4gLQkJc3dfcGxhbmVfd20gPSAmc3dfd20tPnBsYW5lc1tw bGFuZV07Cj4gLQo+IC0JCS8qIFdhdGVybWFya3MgKi8KPiAtCQlmb3IgKGxldmVsID0gMDsgbGV2 ZWwgPD0gbWF4X2xldmVsOyBsZXZlbCsrKSB7Cj4gLQkJCWlmIChza2xfd21fbGV2ZWxfZXF1YWxz KCZod19wbGFuZV93bS0+d21bbGV2ZWxdLAo+IC0JCQkJCQkmc3dfcGxhbmVfd20tPndtW2xldmVs XSkpCj4gLQkJCQljb250aW51ZTsKPiAtCj4gLQkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gV00g cGlwZSAlYyBwbGFuZSAlZCBsZXZlbCAlZCAoZXhwZWN0ZWQgZT0lZCBiPSV1IGw9JXUsIGdvdCBl PSVkIGI9JXUgbD0ldSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShwaXBlKSwgcGxhbmUgKyAxLCBs ZXZlbCwKPiAtCQkJCSAgc3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9lbiwKPiAtCQkJCSAg c3dfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfYiwKPiAtCQkJCSAgc3dfcGxhbmVfd20t PndtW2xldmVsXS5wbGFuZV9yZXNfbCwKPiAtCQkJCSAgaHdfcGxhbmVfd20tPndtW2xldmVsXS5w bGFuZV9lbiwKPiAtCQkJCSAgaHdfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfYiwKPiAt CQkJCSAgaHdfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9yZXNfbCk7Cj4gLQkJfQo+ICsJCWh3 X3BsYW5lX3dtID0gJmh3LT53bS5wbGFuZXNbcGxhbmUtPmlkXTsKPiArCQlzd19wbGFuZV93bSA9 ICZzd193bS0+cGxhbmVzW3BsYW5lLT5pZF07Cj4gIAo+IC0JCWlmICghc2tsX3dtX2xldmVsX2Vx dWFscygmaHdfcGxhbmVfd20tPnRyYW5zX3dtLAo+IC0JCQkJCSAmc3dfcGxhbmVfd20tPnRyYW5z X3dtKSkgewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIHRyYW5zIFdNIHBpcGUgJWMgcGxh bmUgJWQgKGV4cGVjdGVkIGU9JWQgYj0ldSBsPSV1LCBnb3QgZT0lZCBiPSV1IGw9JXUpXG4iLAo+ IC0JCQkJICBwaXBlX25hbWUocGlwZSksIHBsYW5lICsgMSwKPiAtCQkJCSAgc3dfcGxhbmVfd20t PnRyYW5zX3dtLnBsYW5lX2VuLAo+IC0JCQkJICBzd19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVf cmVzX2IsCj4gLQkJCQkgIHN3X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9yZXNfbCwKPiAtCQkJ CSAgaHdfcGxhbmVfd20tPnRyYW5zX3dtLnBsYW5lX2VuLAo+IC0JCQkJICBod19wbGFuZV93bS0+ dHJhbnNfd20ucGxhbmVfcmVzX2IsCj4gLQkJCQkgIGh3X3BsYW5lX3dtLT50cmFuc193bS5wbGFu ZV9yZXNfbCk7Cj4gLQkJfQo+IC0KPiAtCQkvKiBEREIgKi8KPiAtCQlod19kZGJfZW50cnkgPSAm aHctPmRkYl95W3BsYW5lXTsKPiAtCQlzd19kZGJfZW50cnkgPSAmbmV3X2NydGNfc3RhdGUtPndt LnNrbC5wbGFuZV9kZGJfeVtwbGFuZV07Cj4gLQo+IC0JCWlmICghc2tsX2RkYl9lbnRyeV9lcXVh bChod19kZGJfZW50cnksIHN3X2RkYl9lbnRyeSkpIHsKPiAtCQkJRFJNX0VSUk9SKCJtaXNtYXRj aCBpbiBEREIgc3RhdGUgcGlwZSAlYyBwbGFuZSAlZCAoZXhwZWN0ZWQgKCV1LCV1KSwgZm91bmQg KCV1LCV1KSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShwaXBlKSwgcGxhbmUgKyAxLAo+IC0JCQkJ ICBzd19kZGJfZW50cnktPnN0YXJ0LCBzd19kZGJfZW50cnktPmVuZCwKPiAtCQkJCSAgaHdfZGRi X2VudHJ5LT5zdGFydCwgaHdfZGRiX2VudHJ5LT5lbmQpOwo+ICsJCWlmICghcGxhbmUtPmdldF9o d19zdGF0ZShwbGFuZSwgJnBsYW5lX3BpcGUpKSB7Cj4gKwkJCVdBUk4obmV3X2NydGNfc3RhdGUt PmFjdGl2ZV9wbGFuZXMgJiBCSVQocGxhbmUtPmlkKSwKPiArCQkJICAgICAicGlwZSAlYyAlcyBz aG91bGQgYmUgdmlzaWJsZSwgYnV0IGlzbid0XG4iLAo+ICsJCQkgICAgIHBpcGVfbmFtZShwaXBl KSwgcGxhbmUtPmJhc2UubmFtZSk7Cj4gKwkJCWNvbnRpbnVlOwo+ICAJCX0KCkFzIG1lbnRpb25l ZCB0aGUgaWRlYSB3YXMgdG8gbWFrZSBzdXJlIHdlIHZhbGlkYXRlIHRoaXMgc3R1ZmYgZXZlbiBm b3IKZGlzYWJsZWQgcGxhbmVzLiBBIGJpdCBvZiBwYXJhbm9pYSBpcyBnb29kIHNpbmNlIGRkYiBv dmVybGFwcyBjYW4gYmUKc28gZGFuZ2Vyb3VzLiBTbyBJIGRvbid0IHdhbnQgc3VjaCBhIGNoZWNr IGluIHRoaXMgZnVuY3Rpb24uCgo+IC0JfQo+ICAKPiAtCS8qCj4gLQkgKiBjdXJzb3IKPiAtCSAq IElmIHRoZSBjdXJzb3IgcGxhbmUgaXNuJ3QgYWN0aXZlLCB3ZSBtYXkgbm90IGhhdmUgdXBkYXRl ZCBpdCdzIGRkYgo+IC0JICogYWxsb2NhdGlvbi4gSW4gdGhhdCBjYXNlIHNpbmNlIHRoZSBkZGIg YWxsb2NhdGlvbiB3aWxsIGJlIHVwZGF0ZWQKPiAtCSAqIG9uY2UgdGhlIHBsYW5lIGJlY29tZXMg dmlzaWJsZSwgd2UgY2FuIHNraXAgdGhpcyBjaGVjawo+IC0JICovCj4gLQlpZiAoMSkgewo+IC0J CXN0cnVjdCBza2xfcGxhbmVfd20gKmh3X3BsYW5lX3dtLCAqc3dfcGxhbmVfd207Cj4gKwkJV0FS Tl9PTihwbGFuZV9waXBlICE9IHBpcGUpOwo+ICAKPiAtCQlod19wbGFuZV93bSA9ICZody0+d20u cGxhbmVzW1BMQU5FX0NVUlNPUl07Cj4gLQkJc3dfcGxhbmVfd20gPSAmc3dfd20tPnBsYW5lc1tQ TEFORV9DVVJTT1JdOwo+ICsJCVdBUk4oIShuZXdfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyAm IEJJVChwbGFuZS0+aWQpKSwKPiArCQkgICAgICJwaXBlICVjICVzIHNob3VsZCBiZSBpbnZpc2li bGUsIGJ1dCB2aXNpYmxlLlxuIiwKPiArCQkgICAgIHBpcGVfbmFtZShwaXBlKSwgcGxhbmUtPmJh c2UubmFtZSk7CgpTdGlsbCB0aGUgd3JvbmcgcGxhY2UgZm9yIGl0LgoKPiAgCj4gIAkJLyogV2F0 ZXJtYXJrcyAqLwo+ICAJCWZvciAobGV2ZWwgPSAwOyBsZXZlbCA8PSBtYXhfbGV2ZWw7IGxldmVs KyspIHsKPiBAQCAtMTMyNzEsOCArMTMyMzQsOCBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlfd21fc3Rh dGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCQkJCSZzd19wbGFuZV93bS0+d21bbGV2 ZWxdKSkKPiAgCQkJCWNvbnRpbnVlOwo+ICAKPiAtCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiBX TSBwaXBlICVjIGN1cnNvciBsZXZlbCAlZCAoZXhwZWN0ZWQgZT0lZCBiPSV1IGw9JXUsIGdvdCBl PSVkIGI9JXUgbD0ldSlcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShwaXBlKSwgbGV2ZWwsCj4gKwkJ CURSTV9FUlJPUigibWlzbWF0Y2ggaW4gV00gcGlwZSAlYyAlcyBsZXZlbCAlZCAoZXhwZWN0ZWQg ZT0lZCBiPSV1IGw9JXUsIGdvdCBlPSVkIGI9JXUgbD0ldSlcbiIsCj4gKwkJCQkgIHBpcGVfbmFt ZShwaXBlKSwgcGxhbmUtPmJhc2UubmFtZSwgbGV2ZWwsCj4gIAkJCQkgIHN3X3BsYW5lX3dtLT53 bVtsZXZlbF0ucGxhbmVfZW4sCj4gIAkJCQkgIHN3X3BsYW5lX3dtLT53bVtsZXZlbF0ucGxhbmVf cmVzX2IsCj4gIAkJCQkgIHN3X3BsYW5lX3dtLT53bVtsZXZlbF0ucGxhbmVfcmVzX2wsCj4gQEAg LTEzMjgzLDggKzEzMjQ2LDggQEAgc3RhdGljIHZvaWQgdmVyaWZ5X3dtX3N0YXRlKHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjLAo+ICAKPiAgCQlpZiAoIXNrbF93bV9sZXZlbF9lcXVhbHMoJmh3X3Bs YW5lX3dtLT50cmFuc193bSwKPiAgCQkJCQkgJnN3X3BsYW5lX3dtLT50cmFuc193bSkpIHsKPiAt CQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiB0cmFucyBXTSBwaXBlICVjIGN1cnNvciAoZXhwZWN0 ZWQgZT0lZCBiPSV1IGw9JXUsIGdvdCBlPSVkIGI9JXUgbD0ldSlcbiIsCj4gLQkJCQkgIHBpcGVf bmFtZShwaXBlKSwKPiArCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiB0cmFucyBXTSBwaXBlICVj ICVzIChleHBlY3RlZCBlPSVkIGI9JXUgbD0ldSwgZ290IGU9JWQgYj0ldSBsPSV1KVxuIiwKPiAr CQkJCSAgcGlwZV9uYW1lKHBpcGUpLCBwbGFuZS0+YmFzZS5uYW1lLAo+ICAJCQkJICBzd19wbGFu ZV93bS0+dHJhbnNfd20ucGxhbmVfZW4sCj4gIAkJCQkgIHN3X3BsYW5lX3dtLT50cmFuc193bS5w bGFuZV9yZXNfYiwKPiAgCQkJCSAgc3dfcGxhbmVfd20tPnRyYW5zX3dtLnBsYW5lX3Jlc19sLAo+ IEBAIC0xMzI5NCwxMiArMTMyNTcsMTIgQEAgc3RhdGljIHZvaWQgdmVyaWZ5X3dtX3N0YXRlKHN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCX0KPiAgCj4gIAkJLyogRERCICovCj4gLQkJaHdf ZGRiX2VudHJ5ID0gJmh3LT5kZGJfeVtQTEFORV9DVVJTT1JdOwo+IC0JCXN3X2RkYl9lbnRyeSA9 ICZuZXdfY3J0Y19zdGF0ZS0+d20uc2tsLnBsYW5lX2RkYl95W1BMQU5FX0NVUlNPUl07Cj4gKwkJ aHdfZGRiX2VudHJ5ID0gJmh3LT5kZGJfeVtwbGFuZS0+aWRdOwo+ICsJCXN3X2RkYl9lbnRyeSA9 ICZuZXdfY3J0Y19zdGF0ZS0+d20uc2tsLnBsYW5lX2RkYl95W3BsYW5lLT5pZF07Cj4gIAo+ICAJ CWlmICghc2tsX2RkYl9lbnRyeV9lcXVhbChod19kZGJfZW50cnksIHN3X2RkYl9lbnRyeSkpIHsK PiAtCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiBEREIgc3RhdGUgcGlwZSAlYyBjdXJzb3IgKGV4 cGVjdGVkICgldSwldSksIGZvdW5kICgldSwldSkpXG4iLAo+IC0JCQkJICBwaXBlX25hbWUocGlw ZSksCj4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gRERCIHN0YXRlIHBpcGUgJWMgJXMgKGV4 cGVjdGVkICgldSwldSksIGZvdW5kICgldSwldSkpXG4iLAo+ICsJCQkJICBwaXBlX25hbWUocGlw ZSksIHBsYW5lLT5iYXNlLm5hbWUsCj4gIAkJCQkgIHN3X2RkYl9lbnRyeS0+c3RhcnQsIHN3X2Rk Yl9lbnRyeS0+ZW5kLAo+ICAJCQkJICBod19kZGJfZW50cnktPnN0YXJ0LCBod19kZGJfZW50cnkt PmVuZCk7Cj4gIAkJfQo+IC0tIAo+IDIuMjMuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=