From: Andy Shevchenko Date: Fri, 25 Oct 2019 08:08:43 +0000 Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script Message-Id: <20191025080843.GG32742@smile.fi.intel.com> List-Id: References: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> <868spgzcti.wl-maz@kernel.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Masahiro Yamada Cc: Alexandre Belloni , Michal Marek , YueHaibing , Arnd Bergmann , Bartosz Golaszewski , Marc Zyngier , Linus Walleij , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , Linus Torvalds , Markus Elfring , Greg Kroah-Hartman , Joe Perches , Thomas Gleixner , Nicolas Palix , Coccinelle On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > Alexandre Belloni used > https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/ > as a reference, but this is not the output from coccicheck. > The patch author just created a wrong patch by hand. Exactly. Removal of the script is a mistake. Like I said before is a healing (incorrect by the way!) by symptoms. > The deleted semantic patch supports MODE=patch, > which creates a correct patch, and is useful. Right! -- With Best Regards, Andy Shevchenko