From: Daniel Vetter Subject: Re: [Outreachy kernel] [Outreachy][PATCH] drm: use DIV_ROUND_UP helper macro for calculations Date: Fri, 25 Oct 2019 21:40:29 +0200 Message-ID: <20191025194029.GU11828@phenom.ffwll.local> References: <20191025094907.3582-1-wambui.karugax@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: Wambui Karuga , dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com List-Id: dri-devel@lists.freedesktop.org On Fri, Oct 25, 2019 at 12:12:23PM +0200, Julia Lawall wrote: > > > On Fri, 25 Oct 2019, Wambui Karuga wrote: > > > Replace open coded divisor calculations with the DIV_ROUND_UP kernel > > macro for better readability. > > Issue found using coccinelle: > > @@ > > expression n,d; > > @@ > > ( > > - ((n + d - 1) / d) > > + DIV_ROUND_UP(n,d) > > | > > - ((n + (d - 1)) / d) > > + DIV_ROUND_UP(n,d) > > ) > > > > Signed-off-by: Wambui Karuga > > Acked-by: Julia Lawall Applied to drm-misc-next, thanks for your patch. -Daniel > > > > --- > > drivers/gpu/drm/drm_agpsupport.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c > > index 6e09f27fd9d6..4c7ad46fdd21 100644 > > --- a/drivers/gpu/drm/drm_agpsupport.c > > +++ b/drivers/gpu/drm/drm_agpsupport.c > > @@ -212,7 +212,7 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request) > > if (!entry) > > return -ENOMEM; > > > > - pages = (request->size + PAGE_SIZE - 1) / PAGE_SIZE; > > + pages = DIV_ROUND_UP(request->size, PAGE_SIZE); > > type = (u32) request->type; > > memory = agp_allocate_memory(dev->agp->bridge, pages, type); > > if (!memory) { > > @@ -325,7 +325,7 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request) > > entry = drm_agp_lookup_entry(dev, request->handle); > > if (!entry || entry->bound) > > return -EINVAL; > > - page = (request->offset + PAGE_SIZE - 1) / PAGE_SIZE; > > + page = DIV_ROUND_UP(request->offset, PAGE_SIZE); > > retcode = drm_bind_agp(entry->memory, page); > > if (retcode) > > return retcode; > > -- > > 2.23.0 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025094907.3582-1-wambui.karugax%40gmail.com. > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch