Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60839CA9EAF for ; Sun, 27 Oct 2019 15:06:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A58A20873 for ; Sun, 27 Oct 2019 15:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tX0WrZHI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A58A20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p4q6oj7DpmfAuFurOONvN5zZepgjy+fllWSB2XlcMnY=; b=tX0WrZHIKO++7f /8+yi/cNo5BG80w7WqQL7nlTjQECA4h2w5VCeMAJOyUhirS5ynChyd0XRzsyWFwc+AiIVLVFVf39b r4p53TLYzykO4EwbQ9FjAWkc0u/32A5Z2aqd8AVlwhNKyaf58iPFsgxPAhnCiWcLIcCh42A84yEqT /+CLIIa+C+J0JKbE05F69J+rfCsiDGAjGyry727+9PdrqCG1KZvTZqtV/COLq2k6CUF1M2mhOM7p4 VV6QoX7daiGXDVcGZC7+/qsfsiKwar8gLN5Zse5QdQDyVyCU5X97COyUyapkN7nrBuueztFuLJgfk mJys8vF9PkyGtXqZPKcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOk6x-0000B1-Ei; Sun, 27 Oct 2019 15:05:43 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOk6v-0000Ai-B5 for linux-nvme@lists.infradead.org; Sun, 27 Oct 2019 15:05:42 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id DEBE768B05; Sun, 27 Oct 2019 16:05:38 +0100 (CET) Date: Sun, 27 Oct 2019 16:05:38 +0100 From: Christoph Hellwig To: Logan Gunthorpe Subject: Re: [RFC PATCH 2/3] nvme: Create helper function to obtain command effects Message-ID: <20191027150538.GB5843@lst.de> References: <20191025202535.12036-1-logang@deltatee.com> <20191025202535.12036-3-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025202535.12036-3-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191027_080541_529656_D4A02DE2 X-CRM114-Status: UNSURE ( 5.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , Keith Busch , Max Gurtovoy , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The change in this and patch 1 look fine. But wouldn't the changes be a little simpler to understand if you moved this patch before the other one instead of touching the same code multiple times? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme