From: Christoph Hellwig Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module Date: Mon, 28 Oct 2019 00:46:42 -0700 Message-ID: <20191028074642.GB31867@infradead.org> References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191025234834.28214-2-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: John Stultz Cc: lkml , Sandeep Patil , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Andrew Morton , Yue Hu , Mike Rapoport , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area); Please CC the dma maintainer. And no, you have no business using this. Even if you did, internals like this should always be EXPORT_SYMBOL_GPL.