From: sspatil@google.com Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module Date: Mon, 28 Oct 2019 12:12:31 -0700 Message-ID: <20191028191231.GJ125958@google.com> References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191025234834.28214-2-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: john.stultz@linaro.org Cc: lkml , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Andrew Morton , Yue Hu , Mike Rapoport , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > From: Sandeep Patil > > Export cma_get_name, cma_alloc, cma_release, cma_for_each_area > and dma_contiguous_default_area so that we can use these from > the dmabuf cma heap when it is built as module. > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Brian Starkey > Cc: Andrew F. Davis > Cc: Andrew Morton > Cc: Yue Hu > Cc: Mike Rapoport > Cc: Chenbo Feng > Cc: Alistair Strachan > Cc: Sandeep Patil > Cc: Hridya Valsaraju > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Sandeep Patil > [jstultz: Rewrote commit message, added > dma_contiguous_default_area to the set of exported symbols] > Signed-off-by: John Stultz > --- > kernel/dma/contiguous.c | 1 + > mm/cma.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index 69cfb4345388..ff6cba63ea6f 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -31,6 +31,7 @@ > #endif > > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area); I didn't need to do this for the (out-of-tree) ion cma heap [1]. Any reason why you had to? Other than that, thanks for doing this John. Acked-by: Sandeep Patil - ssp 1] https://android-review.googlesource.com/c/kernel/common/+/1121591