From: Thierry Reding Subject: Re: [PATCH] drm/dp: Increase link status size Date: Tue, 29 Oct 2019 15:07:25 +0100 Message-ID: <20191029140725.GK508460@ulmo> References: <20191029111006.358963-1-thierry.reding@gmail.com> <875zk7ad8m.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1331985174==" Return-path: In-Reply-To: <875zk7ad8m.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, coverity-bot , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1331985174== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LHvWgpbS7VDUdu2f" Content-Disposition: inline --LHvWgpbS7VDUdu2f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 29, 2019 at 03:32:41PM +0200, Jani Nikula wrote: > On Tue, 29 Oct 2019, Thierry Reding wrote: > > From: Thierry Reding > > > > The current link status contains bytes 0x202 through 0x207, but we also > > want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) > > so that the post-cursor adjustment can be queried during link training. >=20 > We don't currently use this in i915 (we probably should), so the impact > here is that we'll just read more DPCD than before. I quickly perused > i915, and this does not appear to directly break anything. I think the > change is probably fine, but at the same time it freaks me out a bit... >=20 > If you don't mind, please resend this with Cc: > intel-gfx@lists.freedesktop.org to have our CI crunch through it across > a number of platforms. Would give me a warm fuzzy feeling. :) >=20 > With the caveat that I didn't look at any other drivers besides i915, >=20 > Reviewed-by: Jani Nikula Done, thanks. Thierry --LHvWgpbS7VDUdu2f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl24R5cACgkQ3SOs138+ s6FsUQ//WJ3B8xJ9F/Lvivai6kCMzgL6wCp4TE6h/XtRLLM9mSa0vm0a9RMNaV97 jkIfAMyKtOsCC21MYPrGrVBrBxM6Qab4cuZ0n9wmckEznMV/CsXZzonXk/NR4ikB 9CKrs3FcVCRfzH3o0ji1skL09X4+OfHl5/ZCch/q0YEtiztASluKo6RS4+0QfKCD hKYzHXqy3d1CVX2NE4Oncg/G6nQLXEHpoJDs9FYZx+PGY1S6YpvBC4+BrkZ+3eQ5 rwws2hPZnrX548yZkpXW7CnN/unQyYsygBOJvt0eZgOlHwPaW3F8xUN0tiNQko0p Qvx80IIUTtudrSdJbmOnWNCeQWi7cSVbyDa3ZaPd0wjDgyuFGU1x/0y2jLZV2XYW EV8O63VrkHw+XXzZYLuOu4IEuHpsx5t87G8p4TgBfM6C3G/ttqKgXooBV2gYBAWl fiMSBptBzeth/aqC6V9SrLLQ6+kKxMUUIdxaTqlf3kuJIyq+G+QcoAPtWBpIT03o n9bjBO9Lwd6ELSvWmkp2sRqteg8qf+kYG5dLbvA0/BI2+k1l4FIdx2KSzt6Ys+AL InHlhNgeteRNMC+8R+MRvrV4YPx5JzTXoNvbZqybVZufKj07Ox24tcHtJHUR9gMq 8gv+1JFXUsk/yVFFRb8SmhMVoUU3weLbqna/Dh5HKuhLRygEumQ= =HLxj -----END PGP SIGNATURE----- --LHvWgpbS7VDUdu2f-- --===============1331985174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1331985174==--