Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iPSIV-0008C0-4J for mharc-grub-devel@gnu.org; Tue, 29 Oct 2019 10:16:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60441) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPSIP-00085D-Rr for grub-devel@gnu.org; Tue, 29 Oct 2019 10:16:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPSIO-000192-2e for grub-devel@gnu.org; Tue, 29 Oct 2019 10:16:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPSIN-000189-Q7 for grub-devel@gnu.org; Tue, 29 Oct 2019 10:16:28 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C122E85545 for ; Tue, 29 Oct 2019 14:16:26 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id e25so8482616wra.9 for ; Tue, 29 Oct 2019 07:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AKcq8wWoX2wwvkqOfMmLWbY6rR16vuSYVm1cuKEzlJo=; b=CGb+MNvZ5xQ4QycyOZPN2yw6MRvcp6FnbBVnusdU0gnHEVKtG7dZxSpIAUk3tofwy0 1WWSihJ6c5IWa4QjRONOEH3w4exBSvj4/FR7CCV+xA8epCeDARltatxYybGxGS3V+YT+ +EgrC5B1KY2T9zhYzVza51Jxg8E+l9Hc57SPXzf16PqfdgVNfEx9GfwJYUIkI2oxxEoH fJo/B0HcuHzbHBFT6fcDF4PMeWPoGZniWdK6PfnvkaRz/aqQprtPUE8D6grQ6w5yOvKV 1bfTMNmVOLucvxuq2sQ+VloWQBEgowQGRyLP4+gQ700YZf1VwKBOFe/e0+dN24OgD8wO 5nQg== X-Gm-Message-State: APjAAAUTJYqD18q/6h/BnLzYSVdNvPVthkVWojCtougjST5GTe71WilV nfuGiCcMrDM0OQbqh8H8t6fcbIQjtaXi4urYGcehLiFqWNsYZPfjoDJw3ptzmUf6xR/B+L/4r+Z /zB9nIvyjyOo= X-Received: by 2002:a05:600c:2487:: with SMTP id 7mr4508882wms.164.1572358584965; Tue, 29 Oct 2019 07:16:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwW3RYpj3zRlWkpHrvil/n5qdaZlNri+jNoYYzhhHhgEnNB7f80iz50TFG8+3JF29PlBOOWYQ== X-Received: by 2002:a05:600c:2487:: with SMTP id 7mr4508854wms.164.1572358584673; Tue, 29 Oct 2019 07:16:24 -0700 (PDT) Received: from minerva.redhat.com ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id s17sm2965808wmh.3.2019.10.29.07.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 07:16:23 -0700 (PDT) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Vladimir Serbinenko , Daniel Kiper , Paulo Flabiano Smorigo , Javier Martinez Canillas Subject: [PATCH v5 4/5] normal/main: Search for specific config files for netboot Date: Tue, 29 Oct 2019 15:16:11 +0100 Message-Id: <20191029141612.29488-5-javierm@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191029141612.29488-1-javierm@redhat.com> References: <20191029141612.29488-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2019 14:16:33 -0000 From: Paulo Flabiano Smorigo This patch implements a search for a specific configuration when the conf= ig file is on a remoteserver. It uses the following order: 1) DHCP client UUID option. 2) MAC address (in lower case hexadecimal with dash separators); 3) IP (in upper case hexadecimal) or IPv6; 4) The original grub.cfg file. This procedure is similar to what is used by pxelinux and yaboot: http://www.syslinux.org/wiki/index.php/PXELINUX#config Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D873406 Signed-off-by: Paulo Flabiano Smorigo Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- Changes in v5: - Don't mix varible declarations and code. - Don't use variable length arrays. - Fix coding style issues. - Fix function prototype. - Include missing header. Changes in v4: None Changes in v3: - Add Reviewed-by tag from Daniel Kiper. Changes in v2: None grub-core/net/net.c | 131 ++++++++++++++++++++++++++++++++++++++++ grub-core/normal/main.c | 19 ++++-- include/grub/net.h | 2 + 3 files changed, 148 insertions(+), 4 deletions(-) diff --git grub-core/net/net.c grub-core/net/net.c index d5d726a315e..f82ac15b4ec 100644 --- grub-core/net/net.c +++ grub-core/net/net.c @@ -1735,6 +1735,137 @@ grub_net_restore_hw (void) return GRUB_ERR_NONE; } =20 +grub_err_t +grub_net_search_config_file (char *config) +{ + grub_size_t config_len; + char *suffix; + + auto int search_through (grub_size_t num_tries, grub_size_t slice_size= ); + int search_through (grub_size_t num_tries, grub_size_t slice_size) + { + while (num_tries-- > 0) + { + grub_file_t file; + + grub_dprintf ("net", "attempt to fetch config %s\n", config); + + file =3D grub_file_open (config, GRUB_FILE_TYPE_CONFIG); + + if (file) + { + grub_file_close (file); + return 0; + } + else + { + if (grub_errno =3D=3D GRUB_ERR_IO) + grub_errno =3D GRUB_ERR_NONE; + } + + if (grub_strlen (suffix) < slice_size) + break; + + config[grub_strlen (config) - slice_size] =3D '\0'; + } + + return 1; + } + + config_len =3D grub_strlen (config); + config[config_len] =3D '-'; + suffix =3D config + config_len + 1; + + struct grub_net_network_level_interface *inf; + FOR_NET_NETWORK_LEVEL_INTERFACES (inf) + { + /* By the Client UUID. */ + char *ptr; + int client_uuid_len; + char *client_uuid_var; + const char *client_uuid; + + client_uuid_len =3D sizeof ("net_") + grub_strlen (inf->name) + + sizeof ("_clientuuid") + 1; + + client_uuid_var =3D grub_zalloc (client_uuid_len); + if (!client_uuid_var) + return grub_errno; + + grub_snprintf (client_uuid_var, client_uuid_len, + "net_%s_clientuuid", inf->name); + + client_uuid =3D grub_env_get (client_uuid_var); + grub_free (client_uuid_var); + + if (client_uuid) + { + grub_strcpy (suffix, client_uuid); + if (search_through (1, 0) =3D=3D 0) + return GRUB_ERR_NONE; + } + + /* By the MAC address. */ + + /* Add ethernet type */ + grub_strcpy (suffix, "01-"); + + grub_net_hwaddr_to_str (&inf->hwaddress, suffix + 3); + + for (ptr =3D suffix; *ptr; ptr++) + if (*ptr =3D=3D ':') + *ptr =3D '-'; + + if (search_through (1, 0) =3D=3D 0) + return GRUB_ERR_NONE; + + /* By IP address */ + + switch ((&inf->address)->type) + { + case GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4: + { + grub_uint32_t n =3D grub_be_to_cpu32 ((&inf->address)->ipv4)= ; + + grub_snprintf (suffix, GRUB_NET_MAX_STR_ADDR_LEN, "%02X%02X%= 02X%02X", \ + ((n >> 24) & 0xff), ((n >> 16) & 0xff), = \ + ((n >> 8) & 0xff), ((n >> 0) & 0xff)); + + if (search_through (8, 1) =3D=3D 0) + return GRUB_ERR_NONE; + break; + } + case GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6: + { + char buf[GRUB_NET_MAX_STR_ADDR_LEN]; + struct grub_net_network_level_address base; + base.type =3D GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6; + grub_memcpy (&base.ipv6, ((&inf->address)->ipv6), 16); + grub_net_addr_to_str (&base, buf); + + for (ptr =3D buf; *ptr; ptr++) + if (*ptr =3D=3D ':') + *ptr =3D '-'; + + grub_snprintf (suffix, GRUB_NET_MAX_STR_ADDR_LEN, "%s", buf)= ; + if (search_through (1, 0) =3D=3D 0) + return GRUB_ERR_NONE; + break; + } + case GRUB_NET_NETWORK_LEVEL_PROTOCOL_DHCP_RECV: + return grub_error (GRUB_ERR_BUG, "shouldn't reach here"); + default: + return grub_error (GRUB_ERR_BUG, + "unsupported address type %d", (&inf->addre= ss)->type); + } + } + + /* Remove the remaining minus sign at the end. */ + config[config_len] =3D '\0'; + + return GRUB_ERR_NONE; +} + static struct grub_preboot *fini_hnd; =20 static grub_command_t cmd_addaddr, cmd_deladdr, cmd_addroute, cmd_delrou= te; diff --git grub-core/normal/main.c grub-core/normal/main.c index 1b03dfd57b9..ba579e75072 100644 --- grub-core/normal/main.c +++ grub-core/normal/main.c @@ -18,6 +18,7 @@ */ =20 #include +#include #include #include #include @@ -323,10 +324,20 @@ grub_cmd_normal (struct grub_command *cmd __attribu= te__ ((unused)), =20 prefix =3D grub_env_get ("prefix"); if (prefix) - { - config =3D grub_xasprintf ("%s/grub.cfg", prefix); - if (! config) - goto quit; + { + grub_size_t config_len; + + config_len =3D grub_strlen (prefix) + + sizeof ("/grub.cfg-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXX= XXXXXX"); + config =3D grub_malloc (config_len); + + if (!config) + goto quit; + + grub_snprintf (config, config_len, "%s/grub.cfg", prefix); + + if (grub_strncmp (prefix + 1, "tftp", sizeof ("tftp") - 1) =3D= =3D 0) + grub_net_search_config_file (config); =20 grub_enter_normal_mode (config); grub_free (config); diff --git include/grub/net.h include/grub/net.h index c00b0ab117c..7ae4b6bd805 100644 --- include/grub/net.h +++ include/grub/net.h @@ -569,6 +569,8 @@ grub_net_add_dns_server (const struct grub_net_networ= k_level_address *s); void grub_net_remove_dns_server (const struct grub_net_network_level_address = *s); =20 +grub_err_t +grub_net_search_config_file (char *config); =20 extern char *grub_net_default_server; =20 --=20 2.21.0