From: Jason Gunthorpe Subject: Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror Date: Fri, 1 Nov 2019 15:12:27 +0000 Message-ID: <20191101151222.GN22766@mellanox.com> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-15-jgg@ziepe.ca> <20191029192544.GU22766@mellanox.com> <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> Content-Language: en-US Content-ID: <57BD06A1E1219245833195A807EB8970@eurprd05.prod.outlook.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Yang, Philip" Cc: "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "Zhou, David(ChunMing)" , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Ben Skeggs , "xen-devel@lists.xenproject.org" , Ralph Campbell , John Hubbard , Jerome Glisse , Dennis Dalessandro , Boris Ostrovsky , Petr Cvek , Juergen Gross , Mike List-Id: amd-gfx.lists.freedesktop.org T24gRnJpLCBOb3YgMDEsIDIwMTkgYXQgMDI6NDQ6NTFQTSArMDAwMCwgWWFuZywgUGhpbGlwIHdy b3RlOgo+IAo+IAo+IE9uIDIwMTktMTAtMjkgMzoyNSBwLm0uLCBKYXNvbiBHdW50aG9ycGUgd3Jv dGU6Cj4gPiBPbiBUdWUsIE9jdCAyOSwgMjAxOSBhdCAwNzoyMjozN1BNICswMDAwLCBZYW5nLCBQ aGlsaXAgd3JvdGU6Cj4gPj4gSGkgSmFzb24sCj4gPj4KPiA+PiBJIGRpZCBxdWljayB0ZXN0IGFm dGVyIG1lcmdpbmcgYW1kLXN0YWdpbmctZHJtLW5leHQgd2l0aCB0aGUKPiA+PiBtbXVfbm90aWZp ZXIgYnJhbmNoLCB3aGljaCBpbmNsdWRlcyB0aGlzIHNldCBjaGFuZ2VzLiBUaGUgdGVzdCByZXN1 bHQKPiA+PiBoYXMgZGlmZmVyZW50IGZhaWx1cmVzLCBhcHAgc3R1Y2sgaW50ZXJtaXR0ZW50bHks IEdVSSBubyBkaXNwbGF5IGV0Yy4gSQo+ID4+IGFtIHVuZGVyc3RhbmRpbmcgdGhlIGNoYW5nZXMg YW5kIHdpbGwgdHJ5IHRvIGZpZ3VyZSBvdXQgdGhlIGNhdXNlLgo+ID4gCj4gPiBUaGFua3MhIEkn bSBub3Qgc3VycHJpc2VkIGJ5IHRoaXMgZ2l2ZW4gaG93IGRpZmZpY3VsdCB0aGlzIHBhdGNoIHdh cwo+ID4gdG8gbWFrZS4gTGV0IG1lIGtub3cgaWYgSSBjYW4gYXNzaXN0IGluIGFueSB3YXkKPiA+ IAo+ID4gUGxlYXNlIGVuc3VyZSB0byBydW4gd2l0aCBsb2NrZGVwIGVuYWJsZWQuLiBZb3VyIHN5 bXB0b3BzIHNvdW5kcyBzb3J0Cj4gPiBvZiBsaWtlIGRlYWRsb2NraW5nPwo+ID4gCj4gSGkgSmFz b24sCj4gCj4gQXR0YWNoZWQgcGF0Y2ggZml4IHNldmVyYWwgaXNzdWVzIGluIGFtZGdwdSBkcml2 ZXIsIG1heWJlIHlvdSBjYW4gc3F1YXNoIAo+IHRoaXMgaW50byBwYXRjaCAxNC4gV2l0aCB0aGlz IGlzIGRvbmUsIHBhdGNoIDEyLCAxMywgMTQgaXMgUmV2aWV3ZWQtYnkgCj4gYW5kIFRlc3RlZC1i eSBQaGlsaXAgWWFuZyA8cGhpbGlwLnlhbmdAYW1kLmNvbT4KCldvdywgdGhpcyBpcyBncmVhdCB0 aGFua3MhIENhbiB5b3UgY2xhcmlmeSB3aGF0IHRoZSBwcm9ibGVtcyB5b3UgZm91bmQKd2VyZT8g V2FzIHRoZSBidWcgdGhlICdyZXR1cm4gIXInIGJlbG93PwoKSSdsbCBhbHNvIGFkZCB5b3VyIHNp Z25lZCBvZmYgYnkKCkhlcmUgYXJlIHNvbWUgcmVtYXJrczoKCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9tbi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X21uLmMKPiBpbmRleCBjYjcxOGEwNjRlYjQuLmM4YmJkMDZmMTAwOSAxMDA2 NDQKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfbW4uYwo+IEBAIC02 NywyMSArNjcsMTUgQEAgc3RhdGljIGJvb2wgYW1kZ3B1X21uX2ludmFsaWRhdGVfZ2Z4KHN0cnVj dCBtbXVfcmFuZ2Vfbm90aWZpZXIgKm1ybiwKPiAgCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 ID0gYW1kZ3B1X3R0bV9hZGV2KGJvLT50Ym8uYmRldik7Cj4gIAlsb25nIHI7Cj4gIAo+IC0JLyoK PiAtCSAqIEZJWE1FOiBNdXN0IGhvbGQgc29tZSBsb2NrIHNoYXJlZCB3aXRoCj4gLQkgKiBhbWRn cHVfdHRtX3R0X2dldF91c2VyX3BhZ2VzX2RvbmUoKQo+IC0JICovCj4gLQltbXVfcmFuZ2Vfc2V0 X3NlcShtcm4sIGN1cl9zZXEpOwo+ICsJbXV0ZXhfbG9jaygmYWRldi0+bm90aWZpZXJfbG9jayk7 Cj4gIAo+IC0JLyogRklYTUU6IElzIHRoaXMgbmVjZXNzYXJ5PyAqLwo+IC0JaWYgKCFhbWRncHVf dHRtX3R0X2FmZmVjdF91c2VycHRyKGJvLT50Ym8udHRtLCByYW5nZS0+c3RhcnQsCj4gLQkJCQkJ ICByYW5nZS0+ZW5kKSkKPiAtCQlyZXR1cm4gdHJ1ZTsKPiArCW1tdV9yYW5nZV9zZXRfc2VxKG1y biwgY3VyX3NlcSk7Cj4gIAo+IC0JaWYgKCFtbXVfbm90aWZpZXJfcmFuZ2VfYmxvY2thYmxlKHJh bmdlKSkKPiArCWlmICghbW11X25vdGlmaWVyX3JhbmdlX2Jsb2NrYWJsZShyYW5nZSkpIHsKPiAr CQltdXRleF91bmxvY2soJmFkZXYtPm5vdGlmaWVyX2xvY2spOwo+ICAJCXJldHVybiBmYWxzZTsK ClRoaXMgdGVzdCBmb3IgcmFuZ2VfYmxvY2thYmxlIHNob3VsZCBiZSBiZWZvcmUgbXV0ZXhfbG9j aywgSSBjYW4gbW92ZQppdCB1cAoKQWxzbywgZG8geW91IGtub3cgaWYgbm90aWZpZXJfbG9jayBp cyBoZWxkIHdoaWxlIGNhbGxpbmcKYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlc19kb25lKCk/ IENhbiB3ZSBhZGQgYSAnbG9jayBhc3NlcnQgaGVsZCcKdG8gYW1kZ3B1X3R0bV90dF9nZXRfdXNl cl9wYWdlc19kb25lKCk/Cgo+IEBAIC04NTQsMTIgKzg1MywyMCBAQCBpbnQgYW1kZ3B1X3R0bV90 dF9nZXRfdXNlcl9wYWdlcyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdl cykKPiAgCQlyID0gLUVQRVJNOwo+ICAJCWdvdG8gb3V0X3VubG9jazsKPiAgCX0KPiArCXVwX3Jl YWQoJm1tLT5tbWFwX3NlbSk7Cj4gKwl0aW1lb3V0ID0gamlmZmllcyArIG1zZWNzX3RvX2ppZmZp ZXMoSE1NX1JBTkdFX0RFRkFVTFRfVElNRU9VVCk7Cj4gKwo+ICtyZXRyeToKPiArCXJhbmdlLT5u b3RpZmllcl9zZXEgPSBtbXVfcmFuZ2VfcmVhZF9iZWdpbigmYm8tPm5vdGlmaWVyKTsKPiAgCj4g Kwlkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gIAlyID0gaG1tX3JhbmdlX2ZhdWx0KHJhbmdl LCAwKTsKPiAgCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gLQo+IC0JaWYgKHVubGlrZWx5KHIg PCAwKSkKPiArCWlmICh1bmxpa2VseShyIDw9IDApKSB7Cj4gKwkJaWYgKChyID09IDAgfHwgciA9 PSAtRUJVU1kpICYmICF0aW1lX2FmdGVyKGppZmZpZXMsIHRpbWVvdXQpKQo+ICsJCQlnb3RvIHJl dHJ5Owo+ICAJCWdvdG8gb3V0X2ZyZWVfcGZuczsKPiArCX0KClRoaXMgaXNuJ3QgcmVhbGx5IHJp Z2h0LCBhIHJldHJ5IGxvb3AgbGlrZSB0aGlzIG5lZWRzIHRvIGdvIGFsbCB0aGUKd2F5IHRvIG1t dV9yYW5nZV9yZWFkX3JldHJ5KCkgYW5kIGRvbmUgdW5kZXIgdGhlIG5vdGlmaWVyX2xvY2suIGll Cm1tdV9yYW5nZV9yZWFkX3JldHJ5KCkgY2FuIGZhaWwganVzdCBhcyBsaWtlbHkgYXMgaG1tX3Jh bmdlX2ZhdWx0KCkKY2FuLCBhbmQgZHJpdmVycyBhcmUgc3VwcG9zZWQgdG8gcmV0cnkgaW4gYm90 aCBjYXNlcywgd2l0aCBhIHNpbmdsZQp0aW1lb3V0LgoKQUZBSUNUIGl0IGlzIGEgbWFqb3IgYnVn IHRoYXQgbWFueSBwbGFjZXMgaWdub3JlIHRoZSByZXR1cm4gY29kZSBvZgphbWRncHVfdHRtX3R0 X2dldF91c2VyX3BhZ2VzX2RvbmUoKSA/Pz8KCkhvd2V2ZXIsIHRoaXMgaXMgYWxsIHByZS1leGlz dGluZyBidWdzLCBzbyBJJ20gT0sgZ28gYWhlYWQgd2l0aCB0aGlzCnBhdGNoIGFzIG1vZGlmaWVk LiBJIGFkdmlzZSBBTUQgdG8gbWFrZSBhIGZvbGxvd3VwIHBhdGNoIC4uCgpJJ2xsIGFkZCBhIEZJ WE1FIG5vdGUgdG8gdGhpcyBlZmZlY3QuCgo+ICAJZm9yIChpID0gMDsgaSA8IHR0bS0+bnVtX3Bh Z2VzOyBpKyspIHsKPiAgCQlwYWdlc1tpXSA9IGhtbV9kZXZpY2VfZW50cnlfdG9fcGFnZShyYW5n ZSwgcmFuZ2UtPnBmbnNbaV0pOwo+IEBAIC05MTYsNyArOTIzLDcgQEAgYm9vbCBhbWRncHVfdHRt X3R0X2dldF91c2VyX3BhZ2VzX2RvbmUoc3RydWN0IHR0bV90dCAqdHRtKQo+ICAJCWd0dC0+cmFu Z2UgPSBOVUxMOwo+ICAJfQo+ICAKPiAtCXJldHVybiByOwo+ICsJcmV0dXJuICFyOwoKQWggaXMg dGhpcyB0aGUgbWFqb3IgZXJyb3I/IGhtbV9yYW5nZV92YWxpZCgpIGlzIGludmVydGVkIHZzCm1t dV9yYW5nZV9yZWFkX3JldHJ5KCk/Cgo+ICB9Cj4gICNlbmRpZgo+ICAKPiBAQCAtOTk3LDEwICsx MDA0LDE4IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV90dG1fdHRfdW5waW5fdXNlcnB0cihzdHJ1Y3Qg dHRtX3R0ICp0dG0pCj4gIAlzZ19mcmVlX3RhYmxlKHR0bS0+c2cpOwo+ICAKPiAgI2lmIElTX0VO QUJMRUQoQ09ORklHX0RSTV9BTURHUFVfVVNFUlBUUikKPiAtCWlmIChndHQtPnJhbmdlICYmCj4g LQkgICAgdHRtLT5wYWdlc1swXSA9PSBobW1fZGV2aWNlX2VudHJ5X3RvX3BhZ2UoZ3R0LT5yYW5n ZSwKPiAtCQkJCQkJICAgICAgZ3R0LT5yYW5nZS0+cGZuc1swXSkpCj4gLQkJV0FSTl9PTkNFKDEs ICJNaXNzaW5nIGdldF91c2VyX3BhZ2VfZG9uZVxuIik7Cj4gKwlpZiAoZ3R0LT5yYW5nZSkgewo+ ICsJCXVuc2lnbmVkIGxvbmcgaTsKPiArCj4gKwkJZm9yIChpID0gMDsgaSA8IHR0bS0+bnVtX3Bh Z2VzOyBpKyspIHsKPiArCQkJaWYgKHR0bS0+cGFnZXNbaV0gIT0KPiArCQkJCWhtbV9kZXZpY2Vf ZW50cnlfdG9fcGFnZShndHQtPnJhbmdlLAo+ICsJCQkJCSAgICAgIGd0dC0+cmFuZ2UtPnBmbnNb aV0pKQo+ICsJCQkJYnJlYWs7Cj4gKwkJfQo+ICsKPiArCQlXQVJOKChpID09IHR0bS0+bnVtX3Bh Z2VzKSwgIk1pc3NpbmcgZ2V0X3VzZXJfcGFnZV9kb25lXG4iKTsKPiArCX0KCklzIHRoaXMgcmVs YXRlZC9uZWNlc3Nhcnk/IEkgY2FuIHB1dCBpdCBpbiBhbm90aGVyIHBhdGNoIGlmIGl0IGlzIGp1 c3QKZGVidWdnaW5nIGltcHJvdmVtZW50PyBQbGVhc2UgYWR2aXNlCgpUaGFua3MgYSBsb3QsCkph c29uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs