From: Jason Gunthorpe Subject: Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror Date: Fri, 1 Nov 2019 17:42:32 +0000 Message-ID: <20191101174221.GO22766@mellanox.com> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-15-jgg@ziepe.ca> <20191029192544.GU22766@mellanox.com> <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> <20191101151222.GN22766@mellanox.com> <8280fb65-a897-3d71-79f9-9f80d9e474e9@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8280fb65-a897-3d71-79f9-9f80d9e474e9@amd.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Yang, Philip" Cc: "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "Zhou, David(ChunMing)" , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Ben Skeggs , "xen-devel@lists.xenproject.org" , Ralph Campbell , John Hubbard , Jerome Glisse , Dennis Dalessandro , Boris Ostrovsky , Petr Cvek , Juergen Gross , Mike List-Id: amd-gfx.lists.freedesktop.org T24gRnJpLCBOb3YgMDEsIDIwMTkgYXQgMDM6NTk6MjZQTSArMDAwMCwgWWFuZywgUGhpbGlwIHdy b3RlOgo+ID4gVGhpcyB0ZXN0IGZvciByYW5nZV9ibG9ja2FibGUgc2hvdWxkIGJlIGJlZm9yZSBt dXRleF9sb2NrLCBJIGNhbiBtb3ZlCj4gPiBpdCB1cAo+ID4gCj4geWVzLCB0aGFua3MuCgpPa2F5 LCBJIHdyb3RlIGl0IGxpa2UgdGhpczoKCglpZiAobW11X25vdGlmaWVyX3JhbmdlX2Jsb2NrYWJs ZShyYW5nZSkpCgkJbXV0ZXhfbG9jaygmYWRldi0+bm90aWZpZXJfbG9jayk7CgllbHNlIGlmICgh bXV0ZXhfdHJ5bG9jaygmYWRldi0+bm90aWZpZXJfbG9jaykpCgkJcmV0dXJuIGZhbHNlOwoKPiA+ IEFsc28sIGRvIHlvdSBrbm93IGlmIG5vdGlmaWVyX2xvY2sgaXMgaGVsZCB3aGlsZSBjYWxsaW5n Cj4gPiBhbWRncHVfdHRtX3R0X2dldF91c2VyX3BhZ2VzX2RvbmUoKT8gQ2FuIHdlIGFkZCBhICds b2NrIGFzc2VydCBoZWxkJwo+ID4gdG8gYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlc19kb25l KCk/Cj4gCj4gZ3B1IHNpZGUgaG9sZCBub3RpZmllcl9sb2NrIGJ1dCBrZmQgc2lkZSBkb2Vzbid0 LiBrZmQgc2lkZSBkb2Vzbid0IGNoZWNrIAo+IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXNf ZG9uZS9tbXVfcmFuZ2VfcmVhZF9yZXRyeSByZXR1cm4gdmFsdWUgYnV0IAo+IGNoZWNrIG1lbS0+ aW52YWxpZCBmbGFnIHdoaWNoIGlzIHVwZGF0ZWQgZnJvbSBpbnZhbGlkYXRlIGNhbGxiYWNrLiBJ dCAKPiB0YWtlcyBtb3JlIHRpbWUgdG8gY2hhbmdlLCBJIHdpbGwgY29tZSB0byBhbm90aGVyIHBh dGNoIHRvIGZpeCBpdCBsYXRlci4KCkFoLi4gY29uZnVzaW5nLCBPSywgSSdsbCBsZXQgeW91IHNv cnQgdGhhdAoKPiA+IEhvd2V2ZXIsIHRoaXMgaXMgYWxsIHByZS1leGlzdGluZyBidWdzLCBzbyBJ J20gT0sgZ28gYWhlYWQgd2l0aCB0aGlzCj4gPiBwYXRjaCBhcyBtb2RpZmllZC4gSSBhZHZpc2Ug QU1EIHRvIG1ha2UgYSBmb2xsb3d1cCBwYXRjaCAuLgo+ID4gCj4geWVzLCBJIHdpbGwuCgpXaGls ZSB5b3UgYXJlIGhlcmUsIHRoaXMgaXMgYWxzbyB3cm9uZzoKCmludCBhbWRncHVfdHRtX3R0X2dl dF91c2VyX3BhZ2VzKHN0cnVjdCBhbWRncHVfYm8gKmJvLCBzdHJ1Y3QgcGFnZSAqKnBhZ2VzKQp7 Cglkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7CglyID0gaG1tX3JhbmdlX2ZhdWx0KHJhbmdlLCAw KTsKCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7CglpZiAodW5saWtlbHkociA8PSAwKSkgewoJCWlm ICgociA9PSAwIHx8IHIgPT0gLUVCVVNZKSAmJiAhdGltZV9hZnRlcihqaWZmaWVzLCB0aW1lb3V0 KSkKCQkJZ290byByZXRyeTsKCQlnb3RvIG91dF9mcmVlX3BmbnM7Cgl9CgoJZm9yIChpID0gMDsg aSA8IHR0bS0+bnVtX3BhZ2VzOyBpKyspIHsKCQlwYWdlc1tpXSA9IGhtbV9kZXZpY2VfZW50cnlf dG9fcGFnZShyYW5nZSwgcmFuZ2UtPnBmbnNbaV0pOwoKSXQgaXMgbm90IGFsbG93ZWQgdG8gcmVh ZCB0aGUgcmVzdWx0cyBvZiBobW1fcmFuZ2VfZmF1bHQoKSBvdXRzaWRlCmxvY2tpbmcsIGFuZCBp biBwYXJ0aWN1bGFyLCB3ZSBjYW4ndCBjb252ZXJ0IHRvIGEgc3RydWN0IHBhZ2UuCgpUaGlzIG11 c3QgYmUgZG9uZSBpbnNpZGUgdGhlIG5vdGlmaWVyX2xvY2ssIGFmdGVyIGNoZWNraW5nCm1tdV9y YW5nZV9yZWFkX3JldHJ5KCksIGFsbCBoYW5kbGluZyBvZiB0aGUgc3RydWN0IHBhZ2UgbXVzdCBi ZQpzdHJ1Y3R1cmVkIGxpa2UgdGhhdC4KCj4gPj4gQEAgLTk5NywxMCArMTAwNCwxOCBAQCBzdGF0 aWMgdm9pZCBhbWRncHVfdHRtX3R0X3VucGluX3VzZXJwdHIoc3RydWN0IHR0bV90dCAqdHRtKQo+ ID4+ICAgCXNnX2ZyZWVfdGFibGUodHRtLT5zZyk7Cj4gPj4gICAKPiA+PiAgICNpZiBJU19FTkFC TEVEKENPTkZJR19EUk1fQU1ER1BVX1VTRVJQVFIpCj4gPj4gLQlpZiAoZ3R0LT5yYW5nZSAmJgo+ ID4+IC0JICAgIHR0bS0+cGFnZXNbMF0gPT0gaG1tX2RldmljZV9lbnRyeV90b19wYWdlKGd0dC0+ cmFuZ2UsCj4gPj4gLQkJCQkJCSAgICAgIGd0dC0+cmFuZ2UtPnBmbnNbMF0pKQo+ID4+IC0JCVdB Uk5fT05DRSgxLCAiTWlzc2luZyBnZXRfdXNlcl9wYWdlX2RvbmVcbiIpOwo+ID4+ICsJaWYgKGd0 dC0+cmFuZ2UpIHsKPiA+PiArCQl1bnNpZ25lZCBsb25nIGk7Cj4gPj4gKwo+ID4+ICsJCWZvciAo aSA9IDA7IGkgPCB0dG0tPm51bV9wYWdlczsgaSsrKSB7Cj4gPj4gKwkJCWlmICh0dG0tPnBhZ2Vz W2ldICE9Cj4gPj4gKwkJCQlobW1fZGV2aWNlX2VudHJ5X3RvX3BhZ2UoZ3R0LT5yYW5nZSwKPiA+ PiArCQkJCQkgICAgICBndHQtPnJhbmdlLT5wZm5zW2ldKSkKPiA+PiArCQkJCWJyZWFrOwo+ID4+ ICsJCX0KPiA+PiArCj4gPj4gKwkJV0FSTigoaSA9PSB0dG0tPm51bV9wYWdlcyksICJNaXNzaW5n IGdldF91c2VyX3BhZ2VfZG9uZVxuIik7Cj4gPj4gKwl9Cj4gPiAKPiA+IElzIHRoaXMgcmVsYXRl ZC9uZWNlc3Nhcnk/IEkgY2FuIHB1dCBpdCBpbiBhbm90aGVyIHBhdGNoIGlmIGl0IGlzIGp1c3QK PiA+IGRlYnVnZ2luZyBpbXByb3ZlbWVudD8gUGxlYXNlIGFkdmlzZQo+ID4gCj4gSSBzZWUgdGhp cyBXQVJOIGJhY2t0cmFjZSBub3csIGJ1dCBJIGRpZG4ndCBzZWUgaXQgYmVmb3JlLiBUaGlzIGlz IAo+IHNvbWVob3cgcmVsYXRlZC4KCkhtLCBtaWdodCBiZSBpbnN0cnVjdGl2ZSB0byBsZWFybiB3 aGF0IGlzIGdvaW5nIG9uLi4KClRoYW5rcywKSmFzb24KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=