From: Thierry Reding Subject: Re: [PATCH v2 3/5] drm/dsi: add missing DSI DCS commands Date: Mon, 4 Nov 2019 16:29:33 +0100 Message-ID: <20191104152933.GC1602887@ulmo> References: <20191028150047.22048-1-jani.nikula@intel.com> <20191028150047.22048-3-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2000811433==" Return-path: In-Reply-To: <20191028150047.22048-3-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2000811433== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fig2xvG2VGoz8o/s" Content-Disposition: inline --Fig2xvG2VGoz8o/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 28, 2019 at 05:00:45PM +0200, Jani Nikula wrote: > Update from the DCS specification. >=20 > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > include/video/mipi_display.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > index 6b6390dfa203..928f8c4b6658 100644 > --- a/include/video/mipi_display.h > +++ b/include/video/mipi_display.h > @@ -79,7 +79,9 @@ enum { > enum { > MIPI_DCS_NOP =3D 0x00, > MIPI_DCS_SOFT_RESET =3D 0x01, > + MIPI_DCS_GET_COMPRESSION_MODE =3D 0x03, > MIPI_DCS_GET_DISPLAY_ID =3D 0x04, > + MIPI_DCS_GET_ERROR_COUNT_ON_DSI =3D 0x05, > MIPI_DCS_GET_RED_CHANNEL =3D 0x06, > MIPI_DCS_GET_GREEN_CHANNEL =3D 0x07, > MIPI_DCS_GET_BLUE_CHANNEL =3D 0x08, > @@ -94,6 +96,8 @@ enum { > MIPI_DCS_EXIT_SLEEP_MODE =3D 0x11, > MIPI_DCS_ENTER_PARTIAL_MODE =3D 0x12, > MIPI_DCS_ENTER_NORMAL_MODE =3D 0x13, > + MIPI_DCS_GET_IMAGE_CHECKSUM_RGB =3D 0x14, > + MIPI_DCS_GET_IMAGE_CHECKSUM_CT =3D 0x15, > MIPI_DCS_EXIT_INVERT_MODE =3D 0x20, > MIPI_DCS_ENTER_INVERT_MODE =3D 0x21, > MIPI_DCS_SET_GAMMA_CURVE =3D 0x26, > @@ -105,6 +109,7 @@ enum { > MIPI_DCS_WRITE_LUT =3D 0x2D, > MIPI_DCS_READ_MEMORY_START =3D 0x2E, > MIPI_DCS_SET_PARTIAL_AREA =3D 0x30, > + MIPI_DCS_SET_PARTIAL_COLUMNS =3D 0x31, > MIPI_DCS_SET_SCROLL_AREA =3D 0x33, > MIPI_DCS_SET_TEAR_OFF =3D 0x34, > MIPI_DCS_SET_TEAR_ON =3D 0x35, > @@ -114,7 +119,10 @@ enum { > MIPI_DCS_ENTER_IDLE_MODE =3D 0x39, > MIPI_DCS_SET_PIXEL_FORMAT =3D 0x3A, > MIPI_DCS_WRITE_MEMORY_CONTINUE =3D 0x3C, > + MIPI_DCS_SET_3D_CONTROL =3D 0x3D, > MIPI_DCS_READ_MEMORY_CONTINUE =3D 0x3E, > + MIPI_DCS_GET_3D_CONTROL =3D 0x3F, > + MIPI_DCS_SET_VSYNC_TIMING =3D 0x40, > MIPI_DCS_SET_TEAR_SCANLINE =3D 0x44, > MIPI_DCS_GET_SCANLINE =3D 0x45, > MIPI_DCS_SET_DISPLAY_BRIGHTNESS =3D 0x51, /* MIPI DCS 1.3 */ > @@ -126,7 +134,9 @@ enum { > MIPI_DCS_SET_CABC_MIN_BRIGHTNESS =3D 0x5E, /* MIPI DCS 1.3 */ > MIPI_DCS_GET_CABC_MIN_BRIGHTNESS =3D 0x5F, /* MIPI DCS 1.3 */ > MIPI_DCS_READ_DDB_START =3D 0xA1, > + MIPI_DCS_READ_PPS_START =3D 0xA2, > MIPI_DCS_READ_DDB_CONTINUE =3D 0xA8, > + MIPI_DCS_READ_PPS_CONTINUE =3D 0xA9, > }; > =20 > /* MIPI DCS pixel formats */ > --=20 > 2.20.1 I only have a copy of DCS 1.2, which doesn't seem to have these values. Let me see if I can find a more updated version. Thierry --Fig2xvG2VGoz8o/s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl3AQ90ACgkQ3SOs138+ s6GN0A/+MT8SM17Trcby7MBsnDtUZ/YfcYgZr+gVQ5oWS4sOs7bAAO7HcZPGokQi BMsX5sNj0KYPaHVf9S2LCOK6zQusdxBmUXPkSYEC0WatfpQXQHWmCOZIxaOiBSB2 GCH8ayRw1J9UCYaaQOMqXgwmDpNo3ZGk9IT0NlUJRMOjOShoFcjUUYclbT8RqwKm JoRf+IQcF6WrzVibIsK0UNLv3nMyhnA9yTKf9L+Li/FSg2DB+EImlHTERq9oNYvK M8i498C7UM4Gw3g5XByMgIK3S+egYsrYKW5m4xJhhHe1rq32lCzoZIJeEb9Gr7ES 4QKfcftl0eZ7PCsSmojCtJRB5dOcVk8RWfTr/hf0qJZM35E2ne65g5lUdSIInMmW SAzIriZ/XsACmGtQWKuhtrlwHJ2LUTxMthxdIGzAdxJNHCv7IZk8bLcjafRwy/2t wVHCnLSonz/UZlvoeHJFWyc2G0BADULi3sZkO4UCIXot3O85mNycZW3//OgGECG3 Y3rCFmn0KEo7N+SZLIK8r509BI7cLjDe8u/wbqy1W3YXCyq7QFCA7HwDs+AcXqmQ ew9S0mFn8Xcat08c2lY/91RKraBLUbxRNxWQDCSM+CGTyBYRVsrWWt3EQomcrZcd wi7nV/9OF/xw+nKfpJr7C6vpDO1zirGSPP7lLWfyJ05Q3e1nsl8= =xGHW -----END PGP SIGNATURE----- --Fig2xvG2VGoz8o/s-- --===============2000811433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============2000811433==--