From: Dmitry Torokhov Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Date: Mon, 4 Nov 2019 16:40:50 -0800 Message-ID: <20191105004050.GU57214@dtor-ws> References: <20191014184320.GA161094@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191014184320.GA161094@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org To: Andrzej Hajda , Neil Armstrong Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Linus Walleij , Heikki Krogerus , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote: > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but > works with arbitrary firmware node. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Dmitry Torokhov > --- > > Andrzej, Neil, > > This depends on the new code that can be bound in > ib-fwnode-gpiod-get-index immutable branch of Linus' Walleij tree: > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git ib-fwnode-gpiod-get-index > > I hope that it would be possible to pull in this immutable branch and > not wait until after 5.5 merge window, or, alternatively, merge through > Linus Walleij's tree. Any chance this could be merged, please? > > Thanks! > > drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index aa3198dc9903..6f6d6d1e60ae 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -285,8 +285,8 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi) > else > dvi->connector_type = DRM_MODE_CONNECTOR_DVID; > > - dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode, > - "hpd-gpios", 0, GPIOD_IN, "hpd"); > + dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode, > + "hpd", 0, GPIOD_IN, "hpd"); > if (IS_ERR(dvi->hpd)) { > ret = PTR_ERR(dvi->hpd); > dvi->hpd = NULL; > -- > 2.23.0.700.g56cf767bdb-goog > > > -- > Dmitry -- Dmitry