Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A67EC5DF65 for ; Wed, 6 Nov 2019 15:23:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A3012173B for ; Wed, 6 Nov 2019 15:23:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A3012173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD3AC6B0007; Wed, 6 Nov 2019 10:23:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C3D6B0008; Wed, 6 Nov 2019 10:23:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFCAE6B000A; Wed, 6 Nov 2019 10:23:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id A011F6B0007 for ; Wed, 6 Nov 2019 10:23:38 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 50E1C4408 for ; Wed, 6 Nov 2019 15:23:38 +0000 (UTC) X-FDA: 76126222116.05.pear69_76f156c914c44 X-HE-Tag: pear69_76f156c914c44 X-Filterd-Recvd-Size: 3050 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 15:23:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D6EB9B57E; Wed, 6 Nov 2019 15:23:35 +0000 (UTC) Date: Wed, 6 Nov 2019 16:23:35 +0100 From: Michal Hocko To: "Ben Dooks (Codethink)" Cc: linux-kernel@lists.codethink.co.uk, Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memory_hotplug: move definitions of {set,clear}_zone_contiguous Message-ID: <20191106152335.GC8138@dhcp22.suse.cz> References: <20191106123911.7435-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20191106123911.7435-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 06-11-19 12:39:11, Ben Dooks (Codethink) wrote: > The {set,clear}_zone_contiguous are built whatever the > configuraiton so move the definitions outside the current > ifdef to avoid the following compiler warnings: >=20 > mm/page_alloc.c:1550:6: warning: no previous prototype for =E2set_zone_= contiguous=E2 [-Wmissing-prototypes] > mm/page_alloc.c:1571:6: warning: no previous prototype for =E2clear_zon= e_contiguous=E2 [-Wmissing-prototypes] >=20 > Signed-off-by: Ben Dooks (Codethink) Acked-by: Michal Hocko > --- > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > include/linux/memory_hotplug.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotp= lug.h > index f46ea71b4ffd..6a6456040802 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -229,9 +229,6 @@ void put_online_mems(void); > void mem_hotplug_begin(void); > void mem_hotplug_done(void); > =20 > -extern void set_zone_contiguous(struct zone *zone); > -extern void clear_zone_contiguous(struct zone *zone); > - > #else /* ! CONFIG_MEMORY_HOTPLUG */ > #define pfn_to_online_page(pfn) \ > ({ \ > @@ -339,6 +336,9 @@ static inline int remove_memory(int nid, u64 start,= u64 size) > static inline void __remove_memory(int nid, u64 start, u64 size) {} > #endif /* CONFIG_MEMORY_HOTREMOVE */ > =20 > +extern void set_zone_contiguous(struct zone *zone); > +extern void clear_zone_contiguous(struct zone *zone); > + > extern void __ref free_area_init_core_hotplug(int nid); > extern int __add_memory(int nid, u64 start, u64 size); > extern int add_memory(int nid, u64 start, u64 size); > --=20 > 2.24.0.rc1 --=20 Michal Hocko SUSE Labs