Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE77C5DF63 for ; Wed, 6 Nov 2019 17:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E816B217F4 for ; Wed, 6 Nov 2019 17:58:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KQdk3qrQ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="B8h1EXJE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732465AbfKFR6Z (ORCPT ); Wed, 6 Nov 2019 12:58:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37728 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732409AbfKFR6Z (ORCPT ); Wed, 6 Nov 2019 12:58:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9A1586092C; Wed, 6 Nov 2019 17:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573063104; bh=BDkAFvmpP1pqvsT6Ptd54Z3W97BS25Pu4BZBWg081j8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KQdk3qrQO/QFwJgsk9+7l9g23W/Dyz6tjw4vi3xfYgWpRMDOInHB/9XAMCfJIj6VJ As0qvMV3YmaKrpP0viilXBXmrUYq7CUyjjnoRLcVVmj7kPaqwQf70F+T0uL25AnRXa 5ikD125pZ+IX06AJI3LnLKBfMO6zvbqpjG06/ILY= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1748260923; Wed, 6 Nov 2019 17:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573063102; bh=BDkAFvmpP1pqvsT6Ptd54Z3W97BS25Pu4BZBWg081j8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=B8h1EXJEVIHADkYdPp6KfUPQ4lDWOCsH2wc3lA+/WzIz16khnjBmzK2U9tVdl5uhv mMNPcd1v+Zt3VIgrdF+Y/NrFCa4zlcmn6bWqX9eSoyMCJATn9c/1WfQM0sFDCA9Kys W3EPkeefOufInrvc6zK+IVANCr1IIqtWAsM5GbqI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1748260923 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: fix potential NULL pointer access for firmware From: Kalle Valo In-Reply-To: <20191105090442.8378-1-yhchuang@realtek.com> References: <20191105090442.8378-1-yhchuang@realtek.com> To: Cc: , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191106175823.9A1586092C@smtp.codeaurora.org> Date: Wed, 6 Nov 2019 17:58:23 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > From: Yan-Hsuan Chuang > > Driver could access a NULL firmware pointer if we don't > return here. > > Fixes: 5195b90426409 ("rtw88: avoid FW info flood") > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > Signed-off-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. f530c1961af2 rtw88: fix potential NULL pointer access for firmware -- https://patchwork.kernel.org/patch/11227185/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches